Re: [Github-comments] [geany/geany] added a bibtex parser that extracts identifiers of entries in bib-fil… (#2212)

2019-09-20 Thread Matthew Brush
codebrainz approved this pull request. Looks good to me. After the next release I'll merge this, remind me if I forget. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Wrong folding mark for SVG file (#2308)

2019-09-20 Thread elextr
The folding marks are provided by the Scintilla editor widget which is a separate project that Geany just uses. Please check if the problem exists on the Scite editor which is the reference editor for Scintilla and report to the Scintilla project if it does. -- You are receiving this because

[Github-comments] [geany/geany] Wrong folding mark for SVG file (#2308)

2019-09-20 Thread Nguyễn Hồng Quân
Please see the screenshot ![image](https://user-images.githubusercontent.com/314607/65367815-b221aa80-dc61-11e9-9842-ef1bf2e56b75.png) Sample SVG file: [parkingspace_coord.zip](https://github.com/geany/geany/files/3638291/parkingspace_coord.zip) -- You are receiving this because you are

Re: [Github-comments] [geany/geany] added a bibtex parser that extracts identifiers of entries in bib-fil… (#2212)

2019-09-20 Thread Mirco Schönfeld
TwlyY29 commented on this pull request. > @@ -67,6 +67,7 @@ enum TM_PARSER_PHP, TM_PARSER_PYTHON, TM_PARSER_LATEX, + TM_PARSER_BIBTEX, I've moved `TM_PARSER_BIBTEX`to the end and updated the ctags/parsers.h accordingly -- You are receiving this because you are

Re: [Github-comments] [geany/geany] added a bibtex parser that extracts identifiers of entries in bib-fil… (#2212)

2019-09-20 Thread Mirco Schönfeld
@TwlyY29 pushed 1 commit. 1d94ba2c32f2b57a059dcf7eff3cbeb5ea5003c5 moved bibtex definition to the end of filetypes and parser definitions -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] Terminal/console feature on Windows (#675)

2019-09-20 Thread elextr
@duttaditya18 Pull requests are welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/675#issuecomment-533754837

Re: [Github-comments] [geany/geany] Add 'Select to enclosing brackets' keybinding (#2264)

2019-09-20 Thread elextr
Looks ok by inspection, not tested. A couple of suggestions for improvement: 1. include `<>` if the `brace_match_ltgt` is set 2. the search for `]})` will find those characters in comments and strings so the selection is probably not what the user intended. Not sure how to cure that though

Re: [Github-comments] [geany/geany] Easier project creation (#2245)

2019-09-20 Thread elextr
> Yes, this is a long standing issue. Having a separate session file would fix > this. Yeah, there are discussions going back to 2013 on the Geany devel ML, eg https://www.mail-archive.com/devel@lists.geany.org/msg01278.html was the first that searching for "session file" found, but no actual

Re: [Github-comments] [geany/geany] Terminal/console feature on Windows (#675)

2019-09-20 Thread Aditya Dutt
It would be amazing if this could be implemented. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/675#issuecomment-533751426

Re: [Github-comments] [geany/geany] [Windows] MSYS2 causes `realpath` to be redeclared in `tm_source_file.c` (#2261)

2019-09-20 Thread elextr
Closed #2261 via #2263. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2261#event-2651799961

Re: [Github-comments] [geany/geany] configure: check for realpath function now MSYS2 has it (#2263)

2019-09-20 Thread elextr
Merged #2263 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2263#event-2651799958

Re: [Github-comments] [geany/geany] configure: check for realpath function now MSYS2 has it (#2263)

2019-09-20 Thread elextr
Two approvals is enough for me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2263#issuecomment-533749190

Re: [Github-comments] [geany/geany] Autotools: Really slow on Windows (#2305)

2019-09-20 Thread Thomas Martitz
(it compiled in the past but it's too late for me to make the adoption for latest geany master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2305#issuecomment-533724440

Re: [Github-comments] [geany/geany] Autotools: Really slow on Windows (#2305)

2019-09-20 Thread Thomas Martitz
Here's meson branch. It doens't quite build because I needed fox merge conflicts fpr .135 The branch does not compile, haps someone beats me to it. https://github.com/kugel-/geany/tree/meson -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [Github-comments] [geany/geany] build system: Don't use `seq` that is not available on OpenBSD (#2060)

2019-09-20 Thread Thomas Martitz
I can't believe this is still not resolved. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2060#issuecomment-533711669

Re: [Github-comments] [geany/geany] configure: check for realpath function now MSYS2 has it (#2263)

2019-09-20 Thread Thomas Martitz
Should probably merge this for 1.36? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2263#issuecomment-533711400

Re: [Github-comments] [geany/geany] Fixes and refactorings to utils_strv_shorten_file_list() and friends (#2262)

2019-09-20 Thread Thomas Martitz
Merged #2262 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2262#event-2651549682

Re: [Github-comments] [geany/geany] Fixes and refactorings to utils_strv_shorten_file_list() and friends (#2262)

2019-09-20 Thread Thomas Martitz
Almost 4 weeks passed, I'll go ahead. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2262#issuecomment-533702542

Re: [Github-comments] [geany/geany] Easier project creation (#2245)

2019-09-20 Thread Nick Treleaven
> the file list and project config are the same file so it's simply not > possible to check it into VCS. Yes, this is a long and standing issue. Having a separate session file would fix this. Conceivably other project settings would fit there too, not just session info. -- You are receiving

Re: [Github-comments] [geany/geany] Easier project creation (#2245)

2019-09-20 Thread Nick Treleaven
> The current really lightweight "named sessions" feature Geany has is really > good in many cases, so it should be kept (but renamed) There are many project specific settings besides sessions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [Github-comments] [geany/geany] [Feature request] Select to matching brace (#2260)

2019-09-20 Thread Nick Treleaven
BTW pull #2264 implements this, please test. The selection doesn't include the enclosing braces. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2260#issuecomment-533602268

Re: [Github-comments] [geany/geany] build.c: Replace unhygienic `return_cmd_if` macros with CommandSet array (#2301)

2019-09-20 Thread Nick Treleaven
@ntrel pushed 1 commit. 7ec1ff0372fa598c49305ce8114c81765b96f040 Replace non-standard C `= {}` with `= {0}` and remove trailing commas -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] [WIP] Build: Separate geany.conf/project non-filetype execute commands from FT execute (#2307)

2019-09-20 Thread Nick Treleaven
@ntrel pushed 1 commit. 3241224b2ecae51e740be39a0889a3c2cfd979f1 More robust fix for uninitialized BuildDestination::dst -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] filetypesprivate.h: Don't include build.h (#2299)

2019-09-20 Thread Nick Treleaven
Closed #2299. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2299#event-2650132716

Re: [Github-comments] [geany/geany] Build: Separate geany.conf/project non-filetype execute commands from FT execute (#2307)

2019-09-20 Thread elextr
> Are you saying the wiki is required reading? Yes, in the case where you are making changes to the way the program operates, then it is a professional approach to use all sources of information to understand the current operation. -- You are receiving this because you are subscribed to this

Re: [Github-comments] [geany/geany] Build: Separate geany.conf/project non-filetype execute commands from FT execute (#2307)

2019-09-20 Thread Nick Treleaven
> sound like you made these major changes without actually reading how the > current system works. I have read the manual and the code. Are you saying the wiki is required reading? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on