As I said above, I can't access my development machine ATM, and although I had
tested this there, I didn't have time to make the PR so I just made it "by
hand" on Github from my tablet using the little editing pencil. Just to try to
be helpful.
I am not sure if there is any way of adding the
@elextr commented on this pull request.
> @@ -21,7 +21,7 @@ AC_DEFUN([GEANY_CHECK_GTKDOC_HEADER],
[test "x$geany_enable_gtkdoc_header" != "xno"],
[
dnl python
- AM_PATH_PYTHON([2.7], [have_python=yes], [have_python=no])
+
@kugel- commented on this pull request.
> @@ -21,7 +21,7 @@ AC_DEFUN([GEANY_CHECK_GTKDOC_HEADER],
[test "x$geany_enable_gtkdoc_header" != "xno"],
[
dnl python
- AM_PATH_PYTHON([2.7], [have_python=yes], [have_python=no])
+
> > We use MSYS2 packages exclusively.
>
> Ok, are there any build time python scripts we control? (except
> `gen-api-gtkdoc.py` run from
> [here](https://github.com/geany/geany/blob/6ffaf515ef66d84ebece41abffda3bcdc390ab44/doc/Makefile.am#L136))
>
> If any I guess they use the shebang, so we
@eht16 commented on this pull request.
> @@ -21,7 +21,7 @@ AC_DEFUN([GEANY_CHECK_GTKDOC_HEADER],
[test "x$geany_enable_gtkdoc_header" != "xno"],
[
dnl python
- AM_PATH_PYTHON([2.7], [have_python=yes], [have_python=no])
+
> Ahhh, s/b installing python3-lxml package I think, I'm not on my dev machine
> for a few days (which is why I made this by hand)
Yes. The following could fix the pipeline:
```
diff --git a/.travis.yml b/.travis.yml
index 03c03e0c..ebb28ffc 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -16,10
@kugel- requested changes on this pull request.
> @@ -21,7 +21,7 @@ AC_DEFUN([GEANY_CHECK_GTKDOC_HEADER],
[test "x$geany_enable_gtkdoc_header" != "xno"],
[
dnl python
- AM_PATH_PYTHON([2.7], [have_python=yes], [have_python=no])
+
If you put the same effort into the commit message that you put into the
discussion we would be green.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2903#issuecomment-926144798
Well, the shell lexer maintainer in Scintilla noted they were busy and inviting
submissions to fix it, so its up to "somebody" to do it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I just wanted to add that as far as I know this is standard behavior. It is
consistent in bash, dash (the closest thing to a POSIX shell I've seen), zsh,
and even the heavily nonstandard csh.
It seems to be quite extended too, to the point that some scripts rely on that
behavior. For
10 matches
Mail list logo