[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)

2023-03-02 Thread xiota via Github-comments
I've recently learned about [LuaJIT](https://github.com/LuaJIT/LuaJIT). It appears to be a drop-in replacement for Lua 5.1 that would require only build script or other minor changes. Based on Git activity, LuaJIT appears to be actively maintained. -- Reply to this email directly or view it

[Github-comments] [geany/geany-plugins] [GeanyLua] Switch to LuaJIT? (Issue #1228)

2023-03-02 Thread xiota via Github-comments
Lua 5.1 has been deprecated (in a few years, will be two decades). [LuaJIT](https://github.com/LuaJIT/LuaJIT) appears to be a drop-in replacement for Lua 5.1 that would require only build script or other minor changes. Based on Git activity, LuaJIT is actively maintained. -- Reply to this ema

[Github-comments] [geany/geany-plugins] [GeanyLua] geany.activate not activating document (Issue #1229)

2023-03-02 Thread xiota via Github-comments
`geany.activate()` is supposed activate a document and return true. If it is unable, it returns false. However, it is not activating the document. Accepted arguments are a tab id (negative numbers), document id (positive numbers), or full document path. Test code attempting to call `geany.a

[Github-comments] Re: [geany/geany] Use GtkApplication instead of gtk_main (PR #3417)

2023-03-02 Thread Colomban Wendling via Github-comments
No, you can use GAction without. And I'm not against GtkApplication, but we should then embrace it rather than fight it, otherwise I really don't see the point. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3417#issuecomment-1452533187 You are receiv

[Github-comments] Re: [geany/geany] Use GtkApplication instead of gtk_main (PR #3417)

2023-03-02 Thread Jiří Techet via Github-comments
Seems to work on macOS without any problems. And I agree that we should start using GtkApplication (if, in the far future, we switch to GMenuModel for menus, we could avoid using the mac-integration library because the global menu should be then handled by GtkApplication). -- Reply to this ema

[Github-comments] Re: [geany/geany] TypeScript Parser: Does Not Always Display Complete List of Methods (Issue #3416)

2023-03-02 Thread Jordan Irwin via Github-comments
Sorry, I didn't answer sooner. The two files that I used as examples are located here: - [User.ts](https://github.com/arianne/stendhal/blob/master/srcjs/stendhal/entity/User.ts) - [Player.ts](https://github.com/arianne/stendhal/blob/master/srcjs/stendhal/entity/Player.ts) > ...see whether [univ

[Github-comments] Re: [geany/geany] TypeScript Parser: Does Not Always Display Complete List of Methods (Issue #3416)

2023-03-02 Thread Colomban Wendling via Github-comments
Playing a tad with it, I see it's the `()`s in the members initialization (e.g. `singletons.getSoundManager()`): if you remove the `()`s it keeps on parsing. Now somebody will have to fix it… :slightly_smiling_face: -- Reply to this email directly or view it on GitHub: https://github.com/gean

[Github-comments] Re: [geany/geany] TypeScript Parser: Does Not Always Display Complete List of Methods (Issue #3416)

2023-03-02 Thread Colomban Wendling via Github-comments
This seems to fix it, not sure it's perfect though: ```diff diff --git a/ctags/parsers/typescript.c b/ctags/parsers/typescript.c index 7dcc338ef..3fcd956a8 100644 --- a/ctags/parsers/typescript.c +++ b/ctags/parsers/typescript.c @@ -1820,8 +1820,11 @@ static void parseClassBody (const int scope, to

[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)

2023-03-02 Thread elextr via Github-comments
As I noted above, the plugin is orphaned, so somebody needs to take it over and then make the change. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1133#issuecomment-1452721785 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)

2023-03-02 Thread xiota via Github-comments
I am willing to look into what would be necessary to switch to LuaJIT, but if there would be opposition to such a change, it wouldn't be worth the effort. In principle, switching to LuaJIT should be easier than switching to Lua 5.4+ because LuaJIT is intended to be a drop-in replacement for Lua

[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)

2023-03-02 Thread elextr via Github-comments
Well, there is no plugin maintainer to object ;-) The simplest solution would be just to make it a new plugin ("Geanyluajit" maybe) until its stable and supports the platforms the existing one does. That also means a Geanylua is still available while the distros get their heads around the new

[Github-comments] Re: [geany/geany] Improve code commenting-out global config files (PR #3413)

2023-03-02 Thread elextr via Github-comments
> I just had a look at a few filetype's configurations and it's really a mixed > bag of styles. Thats the problem with software development that is contributed by lots of different people :-D I am not sure about the suggestion to document only in `filetypes.common`, in one way I see your point