[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)

2023-03-05 Thread Chow Loong Jin via Github-comments
@elextr > @hyperair how do we make sure packagers are aware that the dependency of a > plugin changed? Just change the dependency of the plugin in `build/geanylua.m4`, and packagers should figure out that something changed when the next version fails at the configure step with the old build-de

[Github-comments] Re: [geany/geany] changing cursor blinking rate (Issue #3410)

2023-03-05 Thread joomlafun via Github-comments
@b4n could you please tell me the location of the file on Kubuntu which contains the [SCI_SETCARETPERIOD]? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3410#issuecomment-1455162277 You are receiving this because you are subscribed to this thread. M

[Github-comments] Re: [geany/geany] changing cursor blinking rate (Issue #3410)

2023-03-05 Thread Colomban Wendling via Github-comments
@joomlafun it's defined in *Scintilla.h*, which is bundled with Geany. If you wanna patch Geany, you probably don't have to change anything to the includes, and if you want to make a plugin, you'll just need `#include `. -- Reply to this email directly or view it on GitHub: https://github.com/

[Github-comments] Re: [geany/geany-plugins] GeanyLua has an X11 dependency (Issue #1230)

2023-03-05 Thread xiota via Github-comments
`geany.keygrab()` doesn't work on X11. Looks like the callback function either doesn't return or doesn't set the flag to signal that a key has been pressed. Built and tested with both Lua 5.1 and LuaJIT with same result. Example Lua code: ``` geany.status("keygrab - start") key = geany.keygra

[Github-comments] [geany/geany-plugins] geanylua: Migrate to Lua 5.3 (PR #1235)

2023-03-05 Thread Jiří Techet via Github-comments
This PR migrates geanylua to Lua 5.3 (my oldish distro doesn't provide lua 5.4 so I didn't test, maybe it works too). There were mostly just simple changes. From my limited testing, everything seems to work. Posting as an (in my opinion better) alternative to #1233 You can view, comment on, or

[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)

2023-03-05 Thread Jiří Techet via Github-comments
@elextr @xiota I think we maybe didn't understand each other - I have no real problem with using LuaJIT, I just think it's more beneficial to migrate to a new Lua version than being stuck at 5.1 - IMO it's just a workaround and not a real fix. I just created this PR migrating GeanyLua to Lua 5.

[Github-comments] Re: [geany/geany-plugins] geanylua: Migrate to Lua 5.3 (PR #1235)

2023-03-05 Thread Jiří Techet via Github-comments
OK, I just tried on another VM and it compiles and runs with Lua 5.4 too, without any modifications. The only time some modifications were needed was for 5.1->5.2 transition, the 5.2->5.3 transition didn't require any change either. -- Reply to this email directly or view it on GitHub: https://

[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)

2023-03-05 Thread xiota via Github-comments
@techee I tried migrating to 5.4 shortly before this issue was opened. I got it to compile, but segfaults on load. Maybe gave up to quickly. I did not know about LuaJIT at the time. Stepwise migration would have been easier, but the distro I was using at the time made that difficult. Proble

[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)

2023-03-05 Thread Jiří Techet via Github-comments
I just tried and on my other linux VM geanylua with the PR runs with Lua 5.4 without any modifications needed. I'm not really convinced by the performance argument - I just don't see how anyone would notice. The whole Geany except Scintilla lexers and ctags parsers could be written in a scripti

[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)

2023-03-05 Thread xiota via Github-comments
> I just tried and on my other linux VM geanylua with the PR runs with Lua 5.4 > without any modifications needed. I saw that note. The problem is the Lua language changes between versions. And there may be subtle API differences that work fine on the C side, but result in different Lua execu

[Github-comments] [geany/geany-plugins] GeanyLua: Fix geany.keygrab (PR #1236)

2023-03-05 Thread xiota via Github-comments
* Make platform agnostic * Fix infinite loop * Update documentation Resolves #1230. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1236 -- Commit Summary -- * GeanyLua: Fix geany.keygrab -- File Changes -- M geanylua/docs/ge

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix geany.keygrab (PR #1236)

2023-03-05 Thread xiota via Github-comments
@xiota pushed 1 commit. 3c2e16a9d5834b1f153a2557ac819386481a9c2e Use g_signal_handler_disconnect instead of g_clear_signal_handler -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1236/files/b061ff8aa1ef04402905339ad655043564d07207..3c2e16a9d5834b1f153a2557ac819386481a9c2e You

[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)

2023-03-05 Thread elextr via Github-comments
@techee > But I suspect users of this plugin will use it for smaller utilities related > to their workflow and they won't use any advanced features from the language > where they might see differences. (@elextr chuckles to self) Of course that argument could be run backwards, if scripts won'

[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)

2023-03-05 Thread xiota via Github-comments
> ... performance issues... I will ask someone who is having some performance issues while using some GeanyLua scripts whether he's willing to try LuaJIT to see if there's any noticeable difference. But I think the problem is that the computer is just slow. > True, and https://github.com/gean