> after the patch it still goes through strlen characters and computes the hash
> (at least up to maxlen)
The key is that it's up to maxLen and not potentially the whole-file-len.
Assume, for instance, that you have a 1MB file and this problem happens at the
beginning of the file. Also assume t
Maybe just to be clear, when storing values in the hash table, the `1000` here
https://github.com/geany/geany/blob/dea43baf477ab71650cdfc54fa976714def9c170/ctags/main/keyword.c#L121
means "infinity", not a real limit (the table is used for keywords only, there
will, hopefully, be no languages wi
> there may be similar problems in other parsers too and better to prevent
> complete parser freezes at the hash table level for all parsers than relying
> on the parser logic.
Firstly I'm definitely in favour of applying this to limit the impact of issues
with badly written parsers. After all
The right-click menus, and submenues appear. But the action when clicking a
submenu stopped working. Was working earlier.
I suspect that it was a homebrew command (not related to geany) that destroyed
this, maybe changing GTK (saw that flashing by). I am not sure, though.
Geany was install
The right-click menus, and submenues appear. But the action when clicking a
submenu stopped working. Was working earlier.
I suspect that it was a homebrew command (not related to geany) that destroyed
this, maybe changing GTK (saw that flashing by). I am not sure, though.
Geany was install
> But the point was that the real problem is the parser, and that should be
> fixed to be smarter, as you say:
> 1. see $$
> 2. scan until first non-keyword character
> 3. now look it up in the keyword table
> 4. if not keyword skip string to $$
This part of the parser is quite tricky. The strin
Interesting. I see the same problem with the official releases but recently I
made new binaries with the latest gtk-osx here and these don't seem to exhibit
the problem:
https://download.geany.org/snapshots/geany-1.38_osx_arm64.dmg
https://download.geany.org/snapshots/geany-1.38_osx.dmg
These b
```
$SOME_STRING$real string here$SOME_STRING$
```
Yes, and IIRC in some SQLs `$thing` is also meaningful, but only plain `$$`
strings can clash with keywords that are going to be looked up in the table.
> Not undoable, but I just don't want to be the one writing the proper fix ;-).
Yeah, but s
> Yes, and IIRC in some SQLs `$thing` is also meaningful, but only plain `$$`
> strings can clash with keywords that are going to be looked up in the table.
Oh yeah, totally, and these can also be keywords and looked up in the table - I
just added support to the parser for C-preprocessor-like if
Thanks!
This works great — tested on the arm64 version
/Jan
> 22 mars 2023 kl. 14:33 skrev Jiří Techet ***@***.***>:
>
>
> Interesting. I see the same problem with the official releases but recently I
> made new binaries with the latest gtk-osx here and these don't seem to
> exhibit the prob
OK, great. Just curious, are you using macOS 13?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/43#issuecomment-1479998557
You are receiving this because you are subscribed to this thread.
Message ID:
Ventura, whatever version that is/JanSkickat från min iPhone22 mars 2023 kl.
18:40 skrev Jiří Techet ***@***.***>:
OK, great. Just curious, are you using macOS 13?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you authored the thread.Message ID:
> Ventura, whatever version that is
OK, so it's 13 (I remember the numbers, not the names ;-)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/43#issuecomment-1480217216
You are receiving this because you are subscribed to this thread.
Message ID:
13 matches
Mail list logo
