@eli-schwartz thanks for that, yeah, looks like all should be true/false.
I guess the intention was to replicate the olde timey idiom of not defining
`THING` or `#define THING 1` if it was defined.
As you say most of the actual tests just look for "defined" and don't care what
value, so hop
Closed #3436.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3436#event-8835092370
You are receiving this because you are subscribed to this thread.
Message ID:
Thank you. That clears things up for me.
Going to close the PR. I will open a new one with the recommendation by
@eli-schwartz when I get a chance.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1482308804
You are receiving this bec
See my comment on the issue, but tl;dr version checks are totally irrelevant,
meson is NOT changing the internal type produced by `cdata.set('HAVE_THING',
1)`.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3436#issuecomment-1482262648
You are receivin
Based on the bug report submitted to meson, I've analyzed the geany build.
The problem is here:
https://github.com/geany/geany/blob/f0e3ee273e67387f85506ea629b9dbe34d47b8ca/meson.build#L93-L110
All `HAVE_` cdatas are defined to be either integer 1 or boolean false. This
means it's impossible to
According to the [Meson
log](https://github.com/geany/geany/files/11058531/meson-log.txt), it's calling
`cc`, which I believe is just a copy of the `gcc` executable:
```
$ which cc
/mingw64/bin/cc
$ ls -l /mingw64/bin/[^g]*cc.exe
-rwxr-xr-x 1 antum antum 2350907 Jan 23 00:22
/mingw64/bin/x86_6
Okay, I changed the solution to add checks for Meson versions older than 1.0.
Let me know if this is acceptable.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3436#issuecomment-1482232690
You are receiving this because you are subscribed to this thread
@AntumDeluge pushed 1 commit.
d59c7bcd42d040f8f071742e0206a0d9e92d8c04 Meson: Add checks for compatibility
with version 1.0
--
View it on GitHub:
https://github.com/geany/geany/pull/3436/files/de06f67feb2f2af66e31cbebc0efd75710cf7e6d..d59c7bcd42d040f8f071742e0206a0d9e92d8c04
You are receiving
Yes, changing back works:
https://github.com/AntumDeluge/geany/actions/runs/4507422669/jobs/7935187800
Perhaps this PR is all for naught. I'm going to see if I can get a response
from Meson devs about 1.0.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pul
Maybe push the ` == 1` back to the PR to see if it works with 0.61, but yeah,
dunno what is up with 1.0.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3436#issuecomment-1482173863
You are receiving this because you are subscribed to this thread.
Messa
Then why would `if cdata.get('HAVE_FNMATCH') == 1` fail in version `1.0`?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3436#issuecomment-1482170047
You are receiving this because you are subscribed to this thread.
Message ID:
I bet `HAVE_FNMATCH` is actually `#define`d as `1` and Meson is now honoring
that rather than considering it boolean
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3436#issuecomment-1482158898
You are receiving this because you are subscribed to this t
Done.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3436#issuecomment-1482155183
You are receiving this because you are subscribed to this thread.
Message ID:
@AntumDeluge pushed 1 commit.
de06f67feb2f2af66e31cbebc0efd75710cf7e6d Update workflow jobs to run on Ubuntu
Jammy
--
View it on GitHub:
https://github.com/geany/geany/pull/3436/files/13ed79b8433f087aef8edbe93176ef400f0ba79c..de06f67feb2f2af66e31cbebc0efd75710cf7e6d
You are receiving this beca
> @AntumDeluge don't think 22.04.2 is valid see
> [here](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on)
Yes, you are correct. I switched it to `22.04` on my fork, but there is a new
error. I'll fix the version for this PR anyway though.
Simply adds `workflow_dispatch` trigger to CI Build workflow to allow
dispatching manually.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3438
-- Commit Summary --
* Allow dispatching CI Build workflow manually
-- File Changes --
M
@AntumDeluge don't think 22.04.2 is valid see
[here](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3436#issuecomment-1482133430
You are receiving t
Fixed workflow run by changing Ubuntu version from `22.04.2` to `22.04`. But,
now Meson reports this error:
```
meson.build:440:9: ERROR: Object <[IntegerHolder] holds [int]: 1> of type int
does not support the `bool()` operator.
```
So it appears meson version somewhere newer than `0.61.2` is r
…window. Missing showing SearchBar in sidebar or other tweaks.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1242
-- Commit Summary --
* Porting devhelp plugin for gtk3. Working display in sidebar and main
window. Missing showing
Done.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1482046835
You are receiving this because you are subscribed to this thread.
Message ID:
@AntumDeluge pushed 1 commit.
13ed79b8433f087aef8edbe93176ef400f0ba79c Update workflow jobs to run on Ubuntu
Jammy
--
View it on GitHub:
https://github.com/geany/geany/pull/3436/files/4d1179342be5ac9f817511bbbe5bde9e21b3f3cf..13ed79b8433f087aef8edbe93176ef400f0ba79c
You are receiving this beca
@eht16 Thanks for the response. I switched to GNU Autotools & the build
succeeded. I didn't realize that building with Meson is still experimental.
> Is the gcc command you posted above the same which is used to build Geany?
I'll have to do some digging to make sure.
--
Reply to this email dir
My local MSYS2 setup on a native Windows system does *not* have `alloca.h` nor
does the CI build image has it
(https://github.com/geany/infrastructure/pkgs/container/geany-mingw64-ci) and
both cleanly build Geany.
How do you start your build?
Is the `gcc` command you posted above the same which
> @elextr on the other hand seems to be always on
By the majik [sic] of time zones it can seem that way :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/43#issuecomment-1481977021
You are receiving this because you are subscribed to this th
Nah, you were just lucky that I noticed this quickly and had time to test it
and reply (@elextr on the other hand seems to be always on :-).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/43#issuecomment-1481030985
You are receiving this because y
> Want me to update the workflow to build on Jammy and add it to my pull
> request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480906378
You are receiving this because you are subscribed to this thread.
Message ID:
Want me to update the workflow to build on Jammy and add it to my pull request?
https://packages.ubuntu.com/search?keywords=meson&searchon=names&suite=jammy§ion=all
Package version says `0.61.2`.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#is
> meson support is still experimental. I would be OK to only support version
> 0.60+.
Well, that would make my life easier. 🙂 Meson seems like a nice build system,
but I'm struggling finding when the change happened. And it doesn't appear that
variables can be type checked.
--
Reply to this e
meson support is still experimental. I would be OK to only support version
0.60+.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480802030
You are receiving this because you are subscribed to this thread.
Message ID:
My turn to be curious. I am so amazed about response time for this and previous
issues I have posted. Does Geany have developers that are somehow supported so
you don’t have to do all development on your own time? If so, is it big
companies chipping in?Happy if you answer, but understand if you
Thanks, sorry for the ytpos and edits above, I'm on a tablet with screen
keyboard and no Geany access.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480764813
You are receiving this because you are subscribed to this thread.
Messa
I'll test it out and update the PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480761979
You are receiving this because you are subscribed to this thread.
Message ID:
Neat
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480758502
You are receiving this because you are subscribed to this thread.
Message ID:
https://mesonbuild.com/Syntax.html#version_compare
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480755920
You are receiving this because you are subscribed to this thread.
Message ID:
Oh! I was *just* looking at meson's docs. I think there is a `version_compare`
method.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480755070
You are receiving this because you are subscribed to this thread.
Message ID:
`meson.version()` but its a string, so value comparisons might be difficult
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480754005
You are receiving this because you are subscribed to this thread.
Message ID:
> OS: Windows 10 64-bit
Environment: MSYS2/MinGW-w64
Geany source: f0e3ee273e67387f85506ea629b9dbe34d47b8ca
My compiler complains that the `alloca.h` header is missing.
```
FAILED: libregex.a.p/ctags_gnu_regex_regex.c.obj
"cc" "-Ilibregex.a.p" "-I." "-I.." "-I../ctags/fnmatch"
"-fdiagnostics-col
Probably, and those compares will need to be guarded pre/post 0.60.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480749723
You are receiving this because you are subscribed to this thread.
Message ID:
Perhaps it's possible meson version can be checked within `meson.build`?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480748663
You are receiving this because you are subscribed to this thread.
Message ID:
Yeah, that was the "Oh dear" :(
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480748192
You are receiving this because you are subscribed to this thread.
Message ID:
"If clause 1 does not evaluate to true or false". I guess `cdata.get()` does
return int in older versions.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480747476
You are receiving this because you are subscribed to this thread.
M
I wonder what version that changed on, I didn't notice it in release notes but
might have missed it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480746109
You are receiving this because you are subscribed to this thread.
Message
Oh dear
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480744126
You are receiving this because you are subscribed to this thread.
Message ID:
Our CI runs Meson 0.53 so if there is a backward compatibility problem it will
show up on the PR hopefully.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480741319
You are receiving this because you are subscribed to this thread.
Done.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480740335
You are receiving this because you are subscribed to this thread.
Message ID:
Closes: https://github.com/geany/geany/issues/3435
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3436
-- Commit Summary --
* Meson: Don't compare objects of type bool with int
-- File Changes --
M meson.build (4)
-- Patch Links --
Oh, okay. I understand what you are saying. Sure, I will make a PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480737233
You are receiving this because you are subscribed to this thread.
Message ID:
I'm not a great expert on meson, but I can't see where `cdata.get()` would have
returned other than bool, but if you can find it between about 0.54 (Ubuntu
20.04 LTS IIRC) then yeah that will be a problem.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issu
Won't that break backward compatibility?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3435#issuecomment-1480734593
You are receiving this because you are subscribed to this thread.
Message ID:
Meson has made an incompatible change at
[0.60](https://mesonbuild.com/Release-notes-for-0-60-0.html#comparing-two-objects-with-different-types-is-now-an-error)
so can't compare bool and int. And since `cdata.get()` returns no change is
needed any more, so your suggested change is fine, care to
> OS: Windows 10 64-bit
Environment: MSYS2/MinGW-w64
Meson version: 1.0.1
Geany source: f0e3ee273e67387f85506ea629b9dbe34d47b8ca
Trying to build the Geany source code, meson complains "meson.build:440:9:
ERROR: The `==` operator of bool does not accept objects of type int
(1)". I am wondering if
51 matches
Mail list logo
