[Github-comments] [geany/geany] correction bug 3387 (PR #3453)

2023-04-11 Thread Guiikcar via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3453 -- Commit Summary -- * correction bug 3387 -- File Changes -- M src/document.c (7) -- Patch Links -- https://github.com/geany/geany/pull/3453.patch https://github.com/geany/geany

[Github-comments] Re: [geany/geany] File not found message remains after Save As (Issue #3387)

2023-04-11 Thread Guiikcar via Github-comments
I have reproduce the bug, and I have worked on that i did a pull request, i m new in free-software and i think i have resolve the bug (don't hesitate to give me some feedback/tell me if i do something bad i m here to learn) thanks you! -- Reply to this email directly or view it on GitHub: https

[Github-comments] Re: [geany/geany] Config file commenting does not seem to work. (Issue #3451)

2023-04-11 Thread Colomban Wendling via Github-comments
> It would be good to fix it. IMO (at least on my Mint machine) meson used the > right place, and autotools used the wrong one. Geany was the only thing in > the location autotools chose, but meson chose the same place as all the other > stuff installed by the distro. It's IMO a **serious** iss

[Github-comments] [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)

2023-04-11 Thread Colomban Wendling via Github-comments
Having 2 files, *xx.foo* and *something.c* open as C (assume the *.foo* was a header or something): xx.foo ```c int xx_foo(int n); ``` something.c ```c int main(void) { xx_foo(); // (1) } ``` At `(1)`, neither autocompletion nor "go to tag" works, but calltip does. Quick code look suggest

[Github-comments] Re: [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)

2023-04-11 Thread elextr via Github-comments
If the filetype of `xx.foo` is manually set to `C` the symbols are parsed, and at `(1)` (well the line after) `xx_space` correctly shows `xx_foo` and typing the `(` shows the calltip correctly, so tags parsing seems ok. So its more likely in the Geany code of auto-autocompletions and goto symb

[Github-comments] Re: [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)

2023-04-11 Thread Colomban Wendling via Github-comments
> If the filetype of `xx.foo` is manually set to `C` the symbols are parsed, > and at `(1)` (well the line after) `xx_space` correctly shows `xx_foo` > and typing the `(` shows the calltip correctly, so tags parsing seems ok. Well, if you add a line after the existing `xx_foo()`, `xx_space` will

[Github-comments] [geany/geany] Toggle long line marker from menubar (Issue #3455)

2023-04-11 Thread Delany via Github-comments
To toggle the long line marker I need to navigate to `Edit > Preferences > Editor > Display > (Long line marker) Enabled` when I should probably be able to `View > Show Long Line Marker` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3455 You are rece

[Github-comments] Re: [geany/geany] Config file commenting does not seem to work. (Issue #3451)

2023-04-11 Thread elextr via Github-comments
It's IMO a serious issue with the Autotools setup if it install by default in` $prefix/lib` rather than `$prefix/lib/x86_64-linux-gnu` (or `i386-linux-gnu` or `aarch64` or whatever as appropriate). I certainly don't want manually built software to clutter `$prefix/lib` by default, and I expect d

[Github-comments] Re: [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)

2023-04-11 Thread elextr via Github-comments
> will likely complete from the content of the file rather than the symbols here Well `Edit->Preferences->Editor->Completions->Autocomplete all words in the document` is off, so it shouldn't, that sounds like a bug (another one). -- Reply to this email directly or view it on GitHub: https://git

[Github-comments] Re: [geany/geany] File not found message remains after Save As (Issue #3387)

2023-04-11 Thread Nick Treleaven via Github-comments
Thanks - #3453 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3387#issuecomment-1503591412 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] correction bug 3387 (PR #3453)

2023-04-11 Thread Nick Treleaven via Github-comments
@ntrel commented on this pull request. > @@ -1820,6 +1820,13 @@ gboolean document_save_file_as(GeanyDocument *doc, > const gchar *utf8_fname) gboolean ret; gboolean new_file; + // if the personne want to save as a file who dosnt exsist + if (doc->priv->info_bars[MS

[Github-comments] Re: [geany/geany] correction bug 3387 (PR #3453)

2023-04-11 Thread Guiikcar via Github-comments
@Guiikcar commented on this pull request. > @@ -1820,6 +1820,13 @@ gboolean document_save_file_as(GeanyDocument *doc, > const gchar *utf8_fname) gboolean ret; gboolean new_file; + // if the personne want to save as a file who dosnt exsist + if (doc->priv->info_bars

[Github-comments] Re: [geany/geany] [C, C++] Move built-in type keywords to secondary list (PR #3448)

2023-04-11 Thread Nick Treleaven via Github-comments
@ntrel pushed 1 commit. e079381556b8ce8a3a1fcdfcf8b572ec0f303c10 Add const, signed, unsigned, void -- View it on GitHub: https://github.com/geany/geany/pull/3448/files/9a2a3821be59a717d5f6ba1a480bf3e3fb947046..e079381556b8ce8a3a1fcdfcf8b572ec0f303c10 You are receiving this because you are subsc

[Github-comments] Re: [geany/geany] [C, C++] Move built-in type keywords to secondary list (PR #3448)

2023-04-11 Thread Nick Treleaven via Github-comments
Also added const as it may as well include type modifiers. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3448#issuecomment-1503668285 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] [filetypes] Update Kotlin basic types (PR #3456)

2023-04-11 Thread Nick Treleaven via Github-comments
Also remove NaN as it is just a property of floating-point types, it's not a reserved word: https://github.com/JetBrains/kotlin/blob/30788566012c571aa1d3590912468d1ebe59983d/core/builtins/native/kotlin/Primitives.kt#L1763 You can view, comment on, or merge this pull request online at: https://g

[Github-comments] Re: [geany/geany] correction bug 3387 (PR #3453)

2023-04-11 Thread Nick Treleaven via Github-comments
@ntrel commented on this pull request. > @@ -1820,6 +1820,13 @@ gboolean document_save_file_as(GeanyDocument *doc, > const gchar *utf8_fname) gboolean ret; gboolean new_file; + // if the personne want to save as a file who dosnt exsist + if (doc->priv->info_bars[MS

[Github-comments] Re: [geany/geany] [trivial] [filetype config] Remove outdated build command substitution comment (PR #3449)

2023-04-11 Thread Nick Treleaven via Github-comments
Merged #3449 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3449#event-8975929689 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Config file commenting does not seem to work. (Issue #3451)

2023-04-11 Thread Jiří Techet via Github-comments
> It's IMO a serious issue with the Meson setup if it install by default in > /usr rather than /usr/local I think this is not what @elextr meant - he meant that when using autotools, it places things directly under `/user/local` and not under the architecture-based subdirectory. I had a look

[Github-comments] Re: [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)

2023-04-11 Thread Jiří Techet via Github-comments
Good catch! The problem is actually #3268. After a closer inspection the ctags "local" flag detection isn't very profound - it checks source file names and if the file name has a header extension, then the flag is non-local, otherwise it's local. So for the `*.foo` extension, it's assumed to be

[Github-comments] Re: [geany/geany] [config files] Don't comment global content unless it is Conf (PR #3450)

2023-04-11 Thread Jiří Techet via Github-comments
@ntrel As @elextr said, I think you are not using an up-to-date Geany, the code looks a bit different now. In #3413 I wasn't sure what to do with the non-conf files and left the old code here https://github.com/geany/geany/blob/5298f51f41bb29e41970456652d2314ce609bcce/src/ui_utils.c#L2166-L2171

[Github-comments] [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-04-11 Thread Jiří Techet via Github-comments
While it would be nice to get rid of some extra tags, this field is generated in ctags using file name and also some questionable heuristics which doesn't lead to completely reliable results so better to avoid this field. Reverts #3268. Fixes #3454. You can view, comment on, or merge this pull

[Github-comments] Re: [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)

2023-04-11 Thread Jiří Techet via Github-comments
So I had a closer look at what ctags does and I think we can actually never be sure whether the flag is valid or not so let's revert #3268 to be on the safe side. See PR #3457. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3454#issuecomment-15040800

[Github-comments] Re: [geany/geany] docs: Document Open dialog options (#2355) (b143e48)

2023-04-11 Thread Jiří Techet via Github-comments
Dammit, this was the anniversary 1th Geany commit - I wanted to be the one who makes it ;-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/commit/b143e481ef472da1d49c8aabb3842ff20ba7b32c#commitcomment-108526081 You are receiving this because you are subs

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-04-11 Thread Jiří Techet via Github-comments
I maybe have a better idea how to fix this issue - I think it's fixable in uctags. Will try to prepare a patch. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3457#issuecomment-1504235949 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-04-11 Thread elextr via Github-comments
The thing that will complicate it is that a Geany user can set filetype, and really uctags should use that, not its own determination. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3457#issuecomment-1504348370 You are receiving this because you are sub

[Github-comments] Re: [geany/geany] docs: Document Open dialog options (#2355) (b143e48)

2023-04-11 Thread elextr via Github-comments
> Dammit, this was the anniversary 1th Geany commit - I wanted to be the > one who makes it ;-) Nah, it should have been left for @eht16 :grin: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/commit/b143e481ef472da1d49c8aabb3842ff20ba7b32c#commitcomment-

[Github-comments] Re: [geany/geany] [C, C++] Move built-in type keywords to secondary list (PR #3448)

2023-04-11 Thread elextr via Github-comments
> Also added const as it may as well include type modifiers. Actually for C++ these are all reserved [keywords](https://en.cppreference.com/w/cpp/keyword), so should be in the primary list with the other keywords. If you are going to include qualifiers then it should include `volatile` `consti

[Github-comments] Re: [geany/geany] [C, C++] Move built-in type keywords to secondary list (PR #3448)

2023-04-11 Thread elextr via Github-comments
@elextr requested changes on this pull request. Do not apply to C++, C++ use of keywords is too complex to neatly split into categories like this, see more detailed comment on the PR. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3448#pullrequestrev

[Github-comments] Re: [geany/geany] [filetypes] Update Kotlin basic types (PR #3456)

2023-04-11 Thread Jan Dolinár via Github-comments
@dolik-rce commented on this pull request. > @@ -4,7 +4,7 @@ # https://kotlinlang.org/docs/reference/keyword-reference.html primary=abstract assert break case catch class const continue default do else enum extends final finally for goto if implements import instanceof interface native new p

[Github-comments] [geany/geany] [FR] Use XDG desktop portal filechooser instead GTK (Issue #3458)

2023-04-11 Thread redtide via Github-comments
I'm using Geany 1.38 in an Arch system with a LXQt DE and I would like to use the LXQt file chooser, which it's possible if the application uses [XDG desktop portal](https://flatpak.github.io/xdg-desktop-portal/#gdbus-org.freedesktop.portal.FileChooser). -- Reply to this email directly or view