[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-22 Thread Colomban Wendling via Github-comments
Yeah, but it means not only the set of defines is different between meson and autotools, but also their value. We could be careful (and we probably are), but that sound like a great receipt for weird differences -- Reply to this email directly or view it on GitHub: https://github.com/geany/gea

[Github-comments] Re: [geany/geany] 2.0.0: inconsistency in versioning (Issue #3644)

2023-10-22 Thread elextr via Github-comments
Well [semver](https://semver.org/) requires a three part version, always, and I doubt users of Geany (an IDE after all) will be worried about `X.0.0`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3644#issuecomment-1774531436 You are receiving this b

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-22 Thread elextr via Github-comments
> So I'd rather not do it just now. We just done a major release, its the perfect time to do it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3642#issuecomment-1774514876 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-22 Thread Colomban Wendling via Github-comments
Yeah well, meson has its own complicated handling depending on whether the value is a boolean or not…we probably could just use a boolean as IIRC it would just make for a define without a value, but that'd be different from what we have currently, so theoretically it could impact the C code usin

[Github-comments] Re: [geany/geany] Feature request: Split Norwegian into `nb_NO` and `nn_NO` (Issue #3638)

2023-10-22 Thread elextr via Github-comments
>From what I can see there has been no update of actual translation for `nn.po` >since 2012. Although the cost of having both is not high, perhaps it would be >better to have one unified `no.po` rather than both `nn.po` and `nb.po` since >there doesn't seem much interest in maintaining translat

[Github-comments] Re: [geany/geany] Do not show charset "None" in the list of encodings (PR #3640)

2023-10-22 Thread elextr via Github-comments
@elextr approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3640#pullrequestreview-1691603136 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update some paths in HACKING (PR #3641)

2023-10-22 Thread elextr via Github-comments
LGBI and @b4n's suggestion. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3641#issuecomment-1774302675 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-22 Thread elextr via Github-comments
Arrhh, C programmers! Using `1` for `true`, its boolean dammit, not a count Use `true` [end rant] Anyway LOBI. (O==Ok, not Good, see above :-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3642#issuecomment-1774301438 You are rec

[Github-comments] Re: [geany/geany] Feature request (Issue #3530)

2023-10-22 Thread elextr via Github-comments
> Did you actually read the post? Did you read my [question](https://github.com/geany/geany/issues/3530#issuecomment-1771807478) above? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3530#issuecomment-1774297359 You are receiving this because you ar

[Github-comments] Re: [geany/geany] 2.0.0: inconsistency in versioning (Issue #3644)

2023-10-22 Thread Tomasz Kłoczko via Github-comments
Sorry forgot that I've already mention about that. As I wrote I'm using autogenerated from git tag tar balls as input resources to package geany. Usually geany-plugins requires the same version of the geany on build stage. Reason of using that is that with such In geany-plugins.spec I have line:

[Github-comments] [geany/geany] Portuguese translation update (PR #3645)

2023-10-22 Thread Hugo Carvalho via Github-comments
Minor corretcion You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3645 -- Commit Summary -- * Portuguese translation update -- File Changes -- M po/pt.po (10) -- Patch Links -- https://github.com/geany/geany/pull/3645.patch https://g

[Github-comments] Re: [geany/geany] 2.0.0: inconsistency in versioning (Issue #3644)

2023-10-22 Thread Colomban Wendling via Github-comments
This sounds like a continuation of https://github.com/geany/geany/commit/13bc05d80f456d8ed745e4fbfbf4286a49d1acaf#commitcomment-130441271, but I still don't understand what's the actual problem. Yes, it's not the same version string, but what harm does it do? For me, the rationale here is: * t

[Github-comments] [geany/geany] 2.0.0: inconsistency in versioning (Issue #3644)

2023-10-22 Thread Tomasz Kłoczko via Github-comments
https://github.com/geany/geany/blob/4a1fda547fecdd3b5cb49d8f345cef84741210c3/meson.build#L3 At the same time git tag is `2.0.0`. It would be good to keep version and git tag in sync. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3644 You are receiving

[Github-comments] [geany/geany] Move "Virtual Spaces" preference to "Editor -> Features" (PR #3643)

2023-10-22 Thread Colomban Wendling via Github-comments
"Editor -> Display" is very crowded already, and virtual spaces are not merely a display feature, but rather a tool for editing. Close #3605. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3643 -- Commit Summary -- * Move "Virtual Spaces

[Github-comments] Re: [geany/geany] Feature request: Split Norwegian into `nb_NO` and `nn_NO` (Issue #3638)

2023-10-22 Thread Colomban Wendling via Github-comments
> Probably would be good if "somebody" provided a preliminary `nb.po` file > rather than rushing the whole translation at string freeze. Yes, and it's unlikely a large amount of the translation would be invalidated anyway, so most of it would still be usable by then. -- Reply to this email dir

[Github-comments] Re: [geany/geany] Feature request: Split Norwegian into `nb_NO` and `nn_NO` (Issue #3638)

2023-10-22 Thread Colomban Wendling via Github-comments
I'm not sure I entirely get this. We have `nn` translation indeed. We don't have `nb`. I am not sure how the locale selection is made for Norwegian (I guess when the configured language is either `no_NO` or `nb_NO`) as we rely on the system/on the gettext library to perform this step; but from

[Github-comments] Re: [geany/geany] Feature request (Issue #3530)

2023-10-22 Thread HimoriK via Github-comments
> Well that can mark anything, not just keywords. > > Better to find out what the OP wants before we jump to solutions Did you actually read the post? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3530#issuecomment-1774186103 You are receiving this

[Github-comments] Re: [geany/geany] "Name" and "Value" is not translatable in Preferences dialog (Issue #3628)

2023-10-22 Thread Colomban Wendling via Github-comments
Closed #3628 as completed via 656b03bc00fe3a17b6b369f41b436c1473fa953d. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3628#event-10733916371 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Enable translations in the "Various" tab in preferences dialog (PR #3634)

2023-10-22 Thread Colomban Wendling via Github-comments
Merged #3634 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3634#event-10733916374 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-22 Thread Colomban Wendling via Github-comments
When a value could either be defined or not, we used to call either `set(varname, 1)` or `set(varname, false)` respectively. This however leads to the value type of `varname` to be conditional, making it virtually unusable for testing its value. Instead, just do not emit anything when we used t

[Github-comments] Re: [geany/geany] Update some paths in HACKING (PR #3641)

2023-10-22 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -658,7 +658,7 @@ https://github.com/universal-ctags/ctags Method `` -* Add foo.c to SRCS in Makefile.am and meson.build. +* Add foo.c to SRCS in ctags/Makefile.am and meson.build. It's in `parsers` inside `ctags/Makefile.am` ```suggestion * Add

[Github-comments] Re: [geany/geany] Add Prolog filetype support (PR #3171)

2023-10-22 Thread Jiří Techet via Github-comments
@rdipardo I just rebased this PR on top of master and also made the necessary updates related to the updated lexer. Since you are probably the most proficient prolog user around, would you have a look at it if it looks alright? -- Reply to this email directly or view it on GitHub: https://githu

[Github-comments] Re: [geany/geany] Add Prolog filetype support (PR #3171)

2023-10-22 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. 76925635112c447415142b31d69abf573efeed29 Add Prolog filetype support b4e795754e32a59081eb8e819516b988b4893096 Update to the latest Prolog lexer -- View it on GitHub: https://github.com/geany/geany/pull/3171/files/823ee03f5948d9ef79352bd68072a574866ace09..b4e795754e32a

[Github-comments] [geany/geany] Update some paths in HACKING (PR #3641)

2023-10-22 Thread Jiří Techet via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3641 -- Commit Summary -- * Update some paths in HACKING -- File Changes -- M HACKING (10) -- Patch Links -- https://github.com/geany/geany/pull/3641.patch https://github.com/geany/ge

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2023-10-22 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. a9363bc15d2c66ea91eeec923961f93e41bff216 Add Raku (Perl 6) filetype support (lexer and ctags parser) -- View it on GitHub: https://github.com/geany/geany/pull/3169/files/eb6efa91e364c40a841000ceb3e5fa4463120d56..a9363bc15d2c66ea91eeec923961f93e41bff216 You are receivin

[Github-comments] Re: [geany/geany] Add meson.build to release howto and replace IRC by Matrix (PR #3633)

2023-10-22 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3633#pullrequestreview-1691455022 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson error: meson.build:446:32: ERROR: The `==` operator of bool does not accept objects of type int (1) (Issue #3618)

2023-10-22 Thread Colomban Wendling via Github-comments
Actually, its has nothing to do with the Meson version I think, it's just that `fnmatch` isn't found on the OP system, and the code uses either [`cfg_data.set(varname, 1)`](https://mesonbuild.com/Reference-manual_returned_cfg_data.html#cfg_dataset) or [`cfg_data.set(name, false)`](https://meso

[Github-comments] Re: [geany/geany] Feature Request: write to file/export to text... (Issue #3623)

2023-10-22 Thread stephenboston via Github-comments
Oh I see I see... Well yes, of course. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3623#issuecomment-1774094610 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Menu item string "Without encoding (None)" is not fully translatable (Issue #3624)

2023-10-22 Thread Enrico Tröger via Github-comments
I agree with removing "(None)" from the string as it is redundant and making it translatable does not give any value. See #3640. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3624#issuecomment-1774082839 You are receiving this because you are subscri

[Github-comments] [geany/geany] Do not show charset "None" in the list of encodings (PR #3640)

2023-10-22 Thread Enrico Tröger via Github-comments
The charset "None" would be shown for the encoding name "Without encoding" and so it would be rather redundant and the special value "None" should be translatable but isn't. Closes #3624. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3640

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread Enrico Tröger via Github-comments
> No wait, "likely" is correct, not "unlikely". The point I was just making Ok, good. Now I got it and also your ammendment "when I mistype "UNlikely" which I got initally wrong. > But the OP was about inconsistencies in casing, and "Unknown" is different to > "UTF-8" or "EUC-JP", should it be

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread elextr via Github-comments
> I don't think "unknown" is likely to be confused with the name of a real > encoding, No wait, "likely" is correct, not "unlikely". The point I was just making is it will NOT be confused, unlike [scope](https://github.com/geany/geany/issues/3632#issuecomment-1773950714) where "unknown" is a

[Github-comments] Re: [geany/geany] Prefs: move "virtual spaces" to the "Features" tab (Issue #3605)

2023-10-22 Thread Enrico Tröger via Github-comments
Yes, it won't solve the crowded dialog problem until the end of time but at least for now :). @b4n's argument that the setting itself is more a behavior setting than a visual only setting still counts and so I think we should do it. -- Reply to this email directly or view it on GitHub: https:/

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread Enrico Tröger via Github-comments
You won't, I'm sure :). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3632#issuecomment-1774061129 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-22 Thread Enrico Tröger via Github-comments
> Maybe a smidgen more? I tried with the desktop font set to 12 point and it > needed the sidebar set to 208 pixels to avoid Document being hidden and the > scroll arrows appearing. But this system (Mint Cinnamon) doesn't have the big > padding to the right of "Documents" that shows in the Adwai

[Github-comments] Re: [geany/geany] Prefs: move "virtual spaces" to the "Features" tab (Issue #3605)

2023-10-22 Thread elextr via Github-comments
> Anyway, back to "not using Windows" again... That is of course another solution. But really the point was, is it a common problem? Or is it only rare systems with silly themes that have the problem? Of course the solution suggested by @b4n will work for now, until this or another of the dia

[Github-comments] Re: [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-22 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. c77b33d63c3f71714ef8e395ad0908cdd7b29873 Increase the default width for the sidebar -- View it on GitHub: https://github.com/geany/geany/pull/3637/files/6a4627c04661d0bd1b3c98ef041ce9bea215113f..c77b33d63c3f71714ef8e395ad0908cdd7b29873 You are receiving this because you

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread elextr via Github-comments
> how should the suggested encoding name "Unknown"conflict with "UTF-8" or > "EUC-JP"? when I mistype "UNlikely" :-D -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3632#issuecomment-1774059497 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] Feature request: Split Norwegian into `nb_NO` and `nn_NO` (Issue #3638)

2023-10-22 Thread elextr via Github-comments
Probably would be good if "somebody" provided a preliminary `nb.po` file rather than rushing the whole translation at string freeze. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3638#issuecomment-1774059302 You are receiving this because you are sub

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread Enrico Tröger via Github-comments
> Damn, I was following the functions from > `ui_utils.c::create_statusbar_statistics()` and was only one function call > away when I gave up :-) `git grep` is your friend :). > So both the first two need to be changed (and kept the same into the future)? Yes, we could use a constant, easy. >

[Github-comments] Re: [geany/geany] Prefs: move "virtual spaces" to the "Features" tab (Issue #3605)

2023-10-22 Thread Jiří Techet via Github-comments
> @techee plug in a bigger screen, or better get a theme that doesn't include > so much padding. Or both 😀 Or none of these and use my normal solution "don't use Windows" :-) Testing Geany was just a good opportunity to install one and half years worth of updates... > Seriously though, compare

[Github-comments] [geany/geany] feature request: toggle button or keybinding for message window position (bottom|right) (Issue #3639)

2023-10-22 Thread pyfortin via Github-comments
Depending on the output screen used and the text layout, I often find myself switching between the two message windows positions (bottom or right). I think it would be most useful to be able to switch with a keybinding or a button. I did not find neither, so I'm writing this suggestion as a "fea

[Github-comments] [geany/geany-osx] On macOS 14 windows sometimes disappear when resized (Issue #48)

2023-10-22 Thread Jiří Techet via Github-comments
While resizing the main window or dialogs like the preferences dialog, they disappear at certain sizes: https://github.com/geany/geany-osx/assets/713965/99af9540-3d8d-4a2c-b43a-0a0b7531cc6b";> When the cursor is moved over the dialog or the window is minimized and then re-shown, it starts showi

[Github-comments] [geany/geany] Norwegian has two different locales, `nb_NO` and `nn_NO` (Issue #3638)

2023-10-22 Thread Olav Rønnestad Birkeland via Github-comments
Norwegian has two locales: * `nb_NO`: Norwegian Bokmål, most used. * `nn_NO`: Norwegian Nynorsk, least used. Currently Geany has `nn` for norwegian nynorsk (`nn_NO`). We also have `nb`, norwegian bokmål (`nb_NO`). Please add `nb_NO`, rename `nn` to `nn_NO`, and don't choose `nn_NO` in Geany if

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread elextr via Github-comments
Damn, I was following the functions from `ui_utils.c::create_statusbar_statistics()` and was only one function call away when I gave up :-) So both the first two need to be changed (and kept the same into the future)? I don't think "unknown" is likely to be confused with the name of a real enc

[Github-comments] Re: [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-22 Thread elextr via Github-comments
Maybe a smidgen more? I tried with the desktop set to 12 point and it needed the sidebar set to 208 pixels to avoid Document being hidden and the scroll arrows appearing. But this system (Mint Cinnamon) doesn't have the big padding to the right of "Documents" that shows in the Adwaita example

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread Enrico Tröger via Github-comments
Probably the first two hits: ``` src/symbols.c:1947: *tagname = g_strdup(_("unknown")); src/symbols.c:1963: cur_tag = g_strdup(_("unknown")); src/ui_utils.c:286: doc->encoding ? doc->encoding : _("unknown")); ``` The third hit shows that we proba

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread Jiří Techet via Github-comments
> Where is "unknown" set? I pinged you on the assumption it was deep in the > bowels of tagmanager? It's outside the tag manager: https://github.com/geany/geany/blob/fefef55569424b72e540bafa4bec514e7e2fd6f5/src/symbols.c#L1947 -- Reply to this email directly or view it on GitHub: https://githu

[Github-comments] Re: [geany/geany] Maybe the default sidebar width is too narrow (Issue #3630)

2023-10-22 Thread Enrico Tröger via Github-comments
Well, easy enough. #3637 increases the default sidebar width to about 25% of the default window width. We could also think about increasing the default window altogether, this is how it looks like with Adwaita now: ![Screenshot_2023-10-22_10-56-53](https://github.com/geany/geany/assets/617017/4c

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread elextr via Github-comments
Where is "unknown" set? I pinged you on the assumption it was deep in the bowels of tagmanager? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3632#issuecomment-1774036682 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Increase the default width for the sidebar (PR #3637)

2023-10-22 Thread Enrico Tröger via Github-comments
This should prevent the sidebar from being cutoff or clipped of the window. The new value is about 25% of the default window width. Closes #3630. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3637 -- Commit Summary -- * Increase the def

[Github-comments] Re: [geany/geany] In status bar "None" and "unknown" are not using same style big/small starting character (Issue #3632)

2023-10-22 Thread Jiří Techet via Github-comments
> Perhaps it should show something that is less > commonly[1](https://github.com/geany/geany/issues/3632#user-content-fn-1-6f42eafda92f7637071dab0f8cb444e5) > a valid scope, perhaps - @techee? Can be. (I personally don't care much as I use Geany with hidden statusbar.) -- Reply to this email d

[Github-comments] Re: [geany/geany] `Use Windows native dialogs` is broken (Issue #3627)

2023-10-22 Thread elextr via Github-comments
Reopened #3627. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3627#event-10732870640 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] `Use Windows native dialogs` is broken (Issue #3627)

2023-10-22 Thread elextr via Github-comments
If the setting is in `geany.glade` how come it doesn't show on Linux? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3627#issuecomment-1774035389 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] `Use Windows native dialogs` is broken (Issue #3627)

2023-10-22 Thread Enrico Tröger via Github-comments
Yes. I was very surprised as I jst noticed it is still in the Glade file. Sorry, will remove it soon. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3627#issuecomment-1774032078 You are receiving this because you are subscribed to this thread. Message

[Github-comments] Re: [geany/geany] Add meson.build to release howto and replace IRC by Matrix (PR #3633)

2023-10-22 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -24,7 +24,8 @@ version number (e.g. `/home/geany/publish-release 1.36`). Make sure the public part of the GPG key used to sign the archives can be found on the download page. -Windows builds (enrico?). +Windows builds are created mostly by Enrico f

[Github-comments] Re: [geany/geany] Add meson.build to release howto and replace IRC by Matrix (PR #3633)

2023-10-22 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -24,7 +24,8 @@ version number (e.g. `/home/geany/publish-release 1.36`). Make sure the public part of the GPG key used to sign the archives can be found on the download page. -Windows builds (enrico?). +Windows builds are created mostly by Enrico f

[Github-comments] Re: [geany/geany] `Use Windows native dialogs` is broken (Issue #3627)

2023-10-22 Thread Thomas Martitz via Github-comments
Still a bug if the pref is still on the UI -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3627#issuecomment-1774024049 You are receiving this because you are subscribed to this thread. Message ID: