[Github-comments] Re: [geany/geany] [RFC] API for LSP plugins (PR #3571)

2023-11-17 Thread elextr via Github-comments
### On the implementation I had some time to look at it finally. There are no glaring issues I can see at first scan. @b4n > I'm not fond of the implementation, but it might be a good first step. I'll > have to check the plugin to get a better grasp on some design decisions > maybe, but bas

[Github-comments] Re: [geany/geany-plugins] Error: Most Plugins not binary compatible with this release of geany. Therefore not available in Plugin Manager Dialog (Issue #1292)

2023-11-17 Thread elextr via Github-comments
There is `Edit->Preferences->General->Startup->Extra plugin path` but the install should put the plugins in the right place. But I don't know Windows, @eht16 any ideas? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1292#issuecomment-1817315

[Github-comments] Re: [geany/geany] Another way to select whole words with the mouse (Discussion #3693)

2023-11-17 Thread elextr via Github-comments
On LM it works on 1.38 as well. Maybe LM default time between button release and a second click to to be treated as double click is set longer so its easier to do. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3693#discussioncomment-7604341 You

[Github-comments] Re: [geany/geany] Correction of issue #3678 (PR #3681)

2023-11-17 Thread Pascal Baillehache via Github-comments
I've tested @b4n correction and it works for me. I agree that using `scrolledwindow2` is a better way of correcting the problem, so I've modified the PR accordingly. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3681#issuecomment-1817308052 You are r

[Github-comments] Re: [geany/geany] Other warnings hidden inside all the ELEMENT ones. (Issue #3689)

2023-11-17 Thread elextr via Github-comments
> it's supported by GCC and clang If `G_GNUC` identifies clang as well then fine. > Does anybody actually cares about warnings from a non-GNUC compiler? Neat, we can remove 90% of the autotools test crap :-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/i

[Github-comments] Re: [geany/geany] [RFC] API for LSP plugins (PR #3571)

2023-11-17 Thread elextr via Github-comments
@b4n, generally a well reasoned and fair assessment given its a first impression, it took me a while to get used to it, and I have been using Vscode for C++ for a while. ### Jumping to the conclusion > Not good without a proper project setup (expected I guess). Yes its expected, LSPs are __com

[Github-comments] Re: [geany/geany] Correction of issue #3678 (PR #3681)

2023-11-17 Thread Pascal Baillehache via Github-comments
@BayashiPascal pushed 1 commit. 0c099631b18d5ce14216ce5b2ea60347624dfdff Correction of issue #3678 with modification suggested by @b4n instead of my previous one -- View it on GitHub: https://github.com/geany/geany/pull/3681/files/2a8e9dd1442d6a0b300e157ff6887966838aa837..0c099631b18d5ce14216c

[Github-comments] Re: [geany/geany] Other warnings hidden inside all the ELEMENT ones. (Issue #3689)

2023-11-17 Thread Colomban Wendling via Github-comments
> Well, thats GUNC only IIUC, unlike G_NORETURN which supports multiple > compilers. Does anybody *actually* cares about warnings from a non-GNUC compiler? I mean, it's supported by GCC and clang, and I don't think any of us is using anything else? > Of course C++ indicates it with no name on

[Github-comments] Re: [geany/geany] Other warnings hidden inside all the ELEMENT ones. (Issue #3689)

2023-11-17 Thread elextr via Github-comments
Oh, __NO__unused_parameters, yeah. > we could also sprinkle the code with G_GNUC_UNUSED all over the place; but is > it worth it? Well, thats GUNC only IIUC, unlike G_NORETURN which supports multiple compilers. So probably not. (unless "somebody" created b4nlib and B_UNUSED :-) Of course C++

[Github-comments] Re: [geany/geany] Correction of issue #3678 (PR #3681)

2023-11-17 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. This is way too specific and fragile. Do this instead: ```diff diff --git a/src/sidebar.c b/src/sidebar.c index 9d004f392..435e31394 100644 --- a/src/sidebar.c +++ b/src/sidebar.c @@ -1649,7 +1649,7 @@ void sidebar_focus_symbols_tab(void) if (

[Github-comments] Re: [geany/geany] Correction of issue #3678 (PR #3681)

2023-11-17 Thread Colomban Wendling via Github-comments
I don't really care either for which it is; but maybe restoring this to the previous state is the safer solution. FWIW, I don't use that shortcut (didn't even know it existed :smile:) so I don't mind. > works for me, and I too really don't understand why the same call on > `treeview2` (the init

[Github-comments] Re: [geany/geany] Symbol list does not get the focus when access through key binding (Issue #3678)

2023-11-17 Thread Colomban Wendling via Github-comments
> especially as it works if focus is switched to the document list first. Well, not really surprising if you don't actually check it *does* work per se: if the notebook is already focused, the code will switch active page and that'll be enough to bring focus to whatever make sense there. -- Re

[Github-comments] Re: [geany/geany] Other warnings hidden inside all the ELEMENT ones. (Issue #3689)

2023-11-17 Thread Colomban Wendling via Github-comments
> How are you gonna get rid of the unused parameter warnings on all the GTK > callbacks? `-Wno-unused-parameter` :smile: If we really want that one, we could also sprinkle the code with `G_GNUC_UNUSED` all over the place; but is it worth it? -- Reply to this email directly or view it on GitHub

[Github-comments] Re: [geany/geany] [RFC] API for LSP plugins (PR #3571)

2023-11-17 Thread Colomban Wendling via Github-comments
:warning: **Disclaimer**: Big chunk ahead! I started this taking notes reading the above discussion, and more, and I might not have re-written it that nicely, so bear with me -- but I think I should reply before the decade is over :) First of all: I was thrilled by seeing this, LSP support seem

[Github-comments] Re: [geany/geany] Symbol list does not get the focus when access through key binding (Issue #3678)

2023-11-17 Thread Pascal Baillehache via Github-comments
Done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3678#issuecomment-1806617928 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Another way to select whole words with the mouse (Discussion #3693)

2023-11-17 Thread Nick Treleaven via Github-comments
I just discovered something. I knew you can double click on a word and drag to start selecting by whole words, and this works across many apps. But on my Linux Mint 21.2 system, Geany seems to be unique in allowing the following: * Click and drag on a word character, hovering over another word c

[Github-comments] Re: [geany/geany-plugins] Error: Most Plugins not binary compatible with this release of geany. Therefore not available in Plugin Manager Dialog (Issue #1292)

2023-11-17 Thread masla84 via Github-comments
I still have Geany 1.38 & Plugins installed, seems Geany 2.0 looks into Plugins 1.38 folder. If I rename Geany-Plugins 1.38 folder Geany 2.0 doesn't find any plugins, but no error messages anymore. How to tell Geany in which plugins folder it should search for? Am Freitag, 17. November 2023 sc

[Github-comments] Re: [geany/geany-osx] Line wrapping disabled for new/freshly opened files (Issue #51)

2023-11-17 Thread Christian Schmidt via Github-comments
Oh, wow, that was unexpected. Not sure why/when this one came along. I use geany since 2009 or so... Thx -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/51#issuecomment-1816484122 You are receiving this because you are subscribed to this thread. M

[Github-comments] Re: [geany/geany-ev-charter] Update charter for online general assemblies (PR #2)

2023-11-17 Thread Frank Lanitz via Github-comments
Merged #2 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-ev-charter/pull/2#event-10993865778 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-ev-charter] Update charter for online general assemblies (PR #2)

2023-11-17 Thread Frank Lanitz via Github-comments
MV has approved this version at 2022.1 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-ev-charter/pull/2#issuecomment-1816341852 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-osx] Line wrapping disabled for new/freshly opened files (Issue #51)

2023-11-17 Thread elextr via Github-comments
Problem solved, @chrschm `Menu->Project->Properties->Editor->Line Wrapping` overrides the system setting. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/51#issuecomment-1815908124 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany-osx] Line wrapping disabled for new/freshly opened files (Issue #51)

2023-11-17 Thread elextr via Github-comments
Just FTR Geany-lsp on Linux seems to behave as described here, might not be mac specific after all. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/51#issuecomment-1815901797 You are receiving this because you are subscribed to this thread. Messag