Yeah, it would need an inter-process lock around the critical section "test for
existence of socket and create it if not" which would have to be [windows
specific](https://learn.microsoft.com/en-us/windows/win32/sync/interprocess-synchronization)
code since glib doesn't seem to have any
@gnikit thanks.
I just noticed a comment on the OP that some names are in more than one list.
That won't break anything, but it will have performance effects. The lexer has
to search all lists for every identifier it finds (so all your variable names,
function names, etc as well as keywords,
Couple of comments:
1. write the documentation explaining what this plugin is supposed to do,
sounds like it does something different to what @eht16 understood "pin" to
mean, and I have always been confused about what it was meant to do. (and do
not describe it in terms of some other
Closed #3770.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3770#event-11843007945
You are receiving this because you are subscribed to this thread.
Message ID:
This break `document_get_current()` when the document has no filename. That
means any functionality that uses `document_get_current()` won't work on a
document that the user has not given a filename.
I will add further comments on the plugin.
--
Reply to this email directly or view it on
I ran into a little problem when testing my pinner plugin. When using
document_get_current(), the file_name member was NULL even if the
value returned by document_get_current() was not NULL and is_valid
was 1.
You can view, comment on, or merge this pull request online at:
they probably use negative margins or paddings and (probably empty) element
ends up with negative dimensions
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3768#issuecomment-1951467425
You are receiving this because you are subscribed to this thread.
> Sounds good.
>
> * For the next time, a description to describe what is the PR about and
> more importantly why, is generally a good idea.
Understood!
>
> * We could add `*.py` to the patterns and `python` to the matrix to also
> cover the Python helper scripts in the repository.
This pull request sets up GitHub code scanning for this repository. Once the
scans have completed and the checks have passed, the analysis results for this
pull request branch will appear on [this
overview](/geany/geany/security/code-scanning?query=pr%3A3769+is%3Aopen). Once
you merge this
@andy5995 pushed 1 commit.
2c58e9dcc9f9fc5250e57b1eb53d66a9cd393448 strip comments, add workflow_patch
trigger, enable python
--
View it on GitHub:
https://github.com/geany/geany/pull/3769/files/14ef5fe702b42309fcd9e0fd1088b28e871cb6c5..2c58e9dcc9f9fc5250e57b1eb53d66a9cd393448
You are
@gnikit approved this pull request.
Things look fine, albeit a bit hard to read.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3656#pullrequestreview-1887316150
You are receiving this because you are subscribed to this thread.
Message ID:
I tried the standard adwaita theme.. no more errrors or warnings from Geany
anymore!
so now i finally know why, thanks a lot!
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3768#issuecomment-1951428551
You are receiving this because you are
@intact
that might be the problem, never thought of that.
I use Matcha theme
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3768#issuecomment-1951421313
You are receiving this because you are subscribed to this thread.
Message ID:
Your gtk theme probably do that
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3768#issuecomment-1951413412
You are receiving this because you are subscribed to this thread.
Message ID:
Adding ` workflow_dispatch:` might be a good idea to manually re-run the
workflow.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#issuecomment-1951381789
You are receiving this because you are subscribed to this thread.
Message ID:
> @eht16 It looks like we were working on something different but similar? ;) I
> think incorporating something like that into this plugin would be suitable.
Yes, my approach was for a different use case. I like to have a tab/document
always in the visible area of the notebook tab list for easy
Sounds good.
- For the next time, a description to describe what is the PR about and more
importantly why, is generally a good idea.
- We could add `*.py` to the patterns and `python` to the matrix to also cover
the Python helper scripts in the repository.
- Also, could you strip the commented
Good guess.
I tested this and Windows Explorer in fact spawns a single Geany process per
selected file and then this happens what @elextr described above.
There is probably no easy solution. Making the initial startup faster until the
socket connection is checked or implementing some other kind
I moved this to https://github.com/andy5995/pinner
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#issuecomment-1951367227
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #1308.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1308#event-11840560015
You are receiving this because you are subscribed to this thread.
Message ID:
Also, these fonts are Windows fonts and it would be illegal to redistribute
them. As it says
[here](https://learn.microsoft.com/en-us/typography/fonts/font-faq#redistribution-and-extended-rights)
"you may not redistribute the Windows fonts".
--
Reply to this email directly or view it on
@Asmageddon fonts have to be installed on windows, they are not part of Geany.
If a user wants a font with CJK characters they need to install one.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1805#issuecomment-1950999406
You are receiving this
@eht16 Perhaps at least, you could switch the default font to one of those, and
include Asian characters in the preview in order to notice and prevent the
problem on user side?
--
Reply to this email directly or view it on GitHub:
23 matches
Mail list logo
