[Github-comments] Re: [geany/geany] Change name of assign keybinding dialog header title (Issue #4185)

2025-02-01 Thread Colomban Wendling via Github-comments
#4192 has been merged, so this is fixed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/4185#issuecomment-2629150162 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Change name of assign keybinding dialog header title (Issue #4185)

2025-02-01 Thread Colomban Wendling via Github-comments
Closed #4185 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/4185#event-16151315948 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Allow shrinking the preferences dialog again (PR #4224)

2025-02-01 Thread Colomban Wendling via Github-comments
Use a more flexible way of setting the default preference window size to allow shrinking the window if desired. Related to #4195. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/4224 -- Commit Summary -- * Allow shrinking the preferences

[Github-comments] Re: [geany/geany-plugins] Remove redundant check (PR #1404)

2025-02-01 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. Not tested, but LGTM -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1404#pullrequestreview-2588402901 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Version locally the script geany-release.py so far hosted in the wiki… (PR #4223)

2025-02-01 Thread Giuseppe Penone via Github-comments
@giuspen pushed 1 commit. 8959111d480374bdb9cc5e662131c97067ff4ea2 renamed geany-release.py to make it clear it is for windows/msys2 -- View it on GitHub: https://github.com/geany/geany/pull/4223/files/4f61bcd61643337fdba499119a92ecc1499c76e3..8959111d480374bdb9cc5e662131c97067ff4ea2 You are r

[Github-comments] Re: [geany/geany] Version locally the script geany-release.py so far hosted in the wiki… (PR #4223)

2025-02-01 Thread Giuseppe Penone via Github-comments
Makes sense @b4n I will rename to msys2-geany-release.py if that's ok Forgot to mention: the original script from @eht16 is https://wiki.geany.org/_media/howtos/win32/geany-release.py.txt linked from https://wiki.geany.org/howtos/win32/msys2 -- Reply to this email directly or view it on GitHub

[Github-comments] Re: [geany/geany] Version locally the script geany-release.py so far hosted in the wiki… (PR #4223)

2025-02-01 Thread Colomban Wendling via Github-comments
If this file is in the repository, its name should reflect that it's for *Windows* releases, not the usual source releases (which is covered by *doc/making-a-release*). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4223#issuecomment-2629059978 You are

[Github-comments] Re: [geany/geany] Version locally the script geany-release.py so far hosted in the wiki… (PR #4223)

2025-02-01 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > +SOURCE_DIR = join(os.environ['HOME'], 'git', 'geany') +BUILD_DIR = join(os.environ['HOME'], 'git', 'geany', '_build') +RELEASE_DIR_ORIG = join(BASE_DIR, 'release', 'geany-orig') +RELEASE_DIR = join(BASE_DIR, 'release', 'geany') +BUNDLE_BASE_DIR = join(BASE

[Github-comments] Re: [geany/geany] Wanted: New maintainer for Windows builds of Geany (Issue #4189)

2025-02-01 Thread Giuseppe Penone via Github-comments
Ok I got also the installer for the plugins working. I will submit a PR for the changes I had to apply. [geany-plugins-release.zip](https://github.com/user-attachments/files/18629729/geany-plugins-release.zip) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/i

[Github-comments] Re: [geany/geany] Fix documentation of rectangular selection (PR #4222)

2025-02-01 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -759,8 +759,8 @@ Column mode editing (rectangular selections) There is basic support for column mode editing. To use it, create a -rectangular selection by holding down the Control and Shift keys -(or Alt

[Github-comments] [geany/geany] Version locally the script geany-release.py so far hosted in the wiki… (PR #4223)

2025-02-01 Thread Giuseppe Penone via Github-comments
- version locally the script `geany-release.py` so far hosted in the wiki - applied fix for building without signing (missing key/certificate in the filesystem) - added copying geany.nsi from the build directory into the root directory so that no need to run configure twice - changed version num

[Github-comments] Re: [geany/geany-themes] adding octagon.conf (PR #83)

2025-02-01 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > +keyword_2=yellow;;true;false +keyword_3=keyword_1 +keyword_4=keyword_1 + +identifier=default +identifier_1=identifier +identifier_2=identifier_1 +identifier_3=identifier_1 +identifier_4=identifier_1 + +string=red +string_1=string +string_2=string_1 +stri

[Github-comments] Re: [geany/geany-themes] adding octagon.conf (PR #83)

2025-02-01 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > + +keyword=#be95ff;;true;false +keyword_1=keyword +keyword_2=keyword_1 +keyword_3=keyword_1 +keyword_4=keyword_1 + +identifier=default +identifier_1=identifier +identifier_2=identifier_1 +identifier_3=identifier_1 +identifier_4=identifier_1 + +string=#25b

[Github-comments] Re: [geany/geany-themes] adding octagon.conf (PR #83)

2025-02-01 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. Thanks for your contribution! Here are a few remarks: - could you add your themes to the `AUTHORS` file as well, please - for the `carbonfox` theme is the screenshot missing > @@ -0,0 +1,99 @@ +# Colors selected by DrewG @ justaguylinux(dot)com Could you a

[Github-comments] Re: [geany/geany] Wanted: New maintainer for Windows builds of Geany (Issue #4189)

2025-02-01 Thread Giuseppe Penone via Github-comments
Clear, thanks @eht16 I will submit a PR. Still having some issues with the installer for geany-plugins as it doesn't find the languages ` File /r "${GEANY_PLUGINS_RELEASE_DIR}\share\locale\*"` Will update here when I find the reason. -- Reply to this email directly or view it on GitHub: ht

[Github-comments] Re: [geany/geany-plugins] New IncDec plugin for Geany (PR #1351)

2025-02-01 Thread Enrico Tröger via Github-comments
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1351#pullrequestreview-2588359745 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] New IncDec plugin for Geany (PR #1351)

2025-02-01 Thread Enrico Tröger via Github-comments
Thanks. I think it's ok to merge. @scresto09 if you change the code the next time, I suggest to remove the mixed indentation (spaces and tabs). It's not utterly important but makes the code a bit nicer and easier to read. -- Reply to this email directly or view it on GitHub: https://github.com

[Github-comments] Re: [geany/geany] Fix initial sensitivity of the inconsistent line end pref (PR #4221)

2025-02-01 Thread Enrico Tröger via Github-comments
LGTM (also tested). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4221#issuecomment-2629005914 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix documentation of rectangular selection (PR #4222)

2025-02-01 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -759,8 +759,8 @@ Column mode editing (rectangular selections) There is basic support for column mode editing. To use it, create a -rectangular selection by holding down the Control and Shift keys -(or Al

[Github-comments] Re: [geany/geany] Fix documentation of rectangular selection (PR #4222)

2025-02-01 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > @@ -759,8 +759,8 @@ Column mode editing (rectangular selections) There is basic support for column mode editing. To use it, create a -rectangular selection by holding down the Control and Shift keys -(or Al

[Github-comments] Re: [geany/geany] Wanted: New maintainer for Windows builds of Geany (Issue #4189)

2025-02-01 Thread Enrico Tröger via Github-comments
> Hello [@eht16](https://github.com/eht16) I have reached the point of creating > the installers Hooray! Nice to hear. > but I am in the need of key/certificate in order to sign (`codesign_key.pem`, > `codesign.pem`). Should I get a unique set myself? I haven't done this > before, can you poi

[Github-comments] Re: [geany/geany] Wanted: New maintainer for Windows builds of Geany (Issue #4189)

2025-02-01 Thread Giuseppe Penone via Github-comments
I successfully generated the installer with a few changes to the original script linked from the wiki: [geany-release.zip](https://github.com/user-attachments/files/18629185/geany-release.zip) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/4189#issue

[Github-comments] Re: [geany/geany] Wanted: New maintainer for Windows builds of Geany (Issue #4189)

2025-02-01 Thread Giuseppe Penone via Github-comments
For now I changed sign_files to skip if the SIGN_CERTIFICATE_KEY is missing. There was already an instruction to do that but with a bug as `isfile()` was missing. Wouldn't be better to version geany-release.py and geany-plugins-release.py in the respective git repos rather than hosting in the wik

[Github-comments] Re: [geany/geany] Wanted: New maintainer for Windows builds of Geany (Issue #4189)

2025-02-01 Thread Giuseppe Penone via Github-comments
Hello @eht16 I have reached the point of creating the installers but I am in the need of key/certificate in order to sign (`codesign_key.pem`, `codesign.pem`). Should I get a unique set myself? I haven't done this before, can you point me to where you did get yours? ``` Execute command: osslsign