b4n left a comment (geany/geany#4303)
Yeah, the issue is that the columns are just wrong, and `mio_new_mio()` gets
several things wrong in these cases. With `mini-geany` I get another issue
(that the C library allows seeking off-bounds, and the rest of the code doesn't
do enough checking until
b4n left a comment (geany/geany#4303)
BTW, thanks for the investigation!
One last thing: IMO `mio_new_mio()` might not be in the right place, and should
be outside MIO, as I see the latter as an abstraction over the FILE API to
allow memory streams, and features not directly related to that sho
techee left a comment (geany/geany#4303)
To be clear, what I did in (2) isn't the right solution - what I think should
happen is:
1. Harden MIO against invalid values - in this case, for `size <= -2`
`mio_new_mio()`should return NULL. Possibly other MIO functions should be
updated this way too.
techee left a comment (geany/geany#4303)
I get this backtrace:
```
#0 __memcpy_generic () at ../sysdeps/aarch64/multiarch/../memcpy.S:118
#1 0xf7e386c8 in mio_read
(nmemb=, size=, ptr_=,
mio=0xac24ce90) at main/mio.c:574
#2 mio_read
(mio=0xac24ce90, ptr_=, size=,
nmem
frlan left a comment (geany/geany-plugins#1436)
I think pining directly will have a better resolt as some plugins are kind of
ready and don't need any patches e.g.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1436#issuecomment-2927651971
Y
When project is open and we load the plugin from the plugin manager, we
can't read the exact project configuration because the
"project-open" signal that delivers the config file was fired when
the plugin wasn't loaded. This means we don't know whether the project
enables LSP support or not. Ri
techee left a comment (geany/geany#4303)
> OK, actually CRLF is a big part of it. ./ctags --extras=+rg -o- wp-guest.php
> leads to the issue as well. I'll look into it.
OK, I probably misinterpreted your previous comment - I thought CRLF should be
disabled to reproduce it and I copy/pasted you
b4n left a comment (geany/geany#4303)
OK, actually CRLF is a big part of it. `./ctags --extras=+rg -o- wp-guest.php`
leads to the issue as well. I'll look into it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4303#issuecomment-2927384758
You are re
b4n left a comment (geany/geany#4303)
Didn't find a relevant option that would make regular uctags crash. However,
if I tricky mini-geany into parsing the file as PHP it does crash, so I guess
there's still an issue over there.
--
Reply to this email directly or view it on GitHub:
https://git
techee left a comment (geany/geany#4303)
We possibly use different 'command line' flags by default. Check what's enabled
in tm_ctags.c.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4303#issuecomment-2927232260
You are receiving this because you are s
b4n left a comment (geany/geany#4303)
Hum, CTags 6.2.0 synced still crashes here… I'll look into whether I messed it
up or there's something specific in our end for this to happen.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4303#issuecomment-292719
techee left a comment (geany/geany#4303)
> @techee I'm about to try that, I started the ssync but got interrupted. You
> can try if it helps, or wait for me to do it :)
I could get to it in the evening so you might be faster.
I don't see the crash though (no CRLFs) but it could be the ARM64 pro
@b4n commented on this pull request.
> + * @brief Replace %-placeholders in a string
+ * @param str Format string including placeholders
+ * @param insert_replacement Callback function to insert placeholder
replacements.
+ * It gets called with the buffer to which appe
@techee commented on this pull request.
> + * @brief Replace %-placeholders in a string
+ * @param str Format string including placeholders
+ * @param insert_replacement Callback function to insert placeholder
replacements.
+ * It gets called with the buffer to which a
b4n left a comment (geany/geany#4303)
@techee I'm about to try that, I started the ssync but got interrupted. You can
try if it helps, or wait for me to do it :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4303#issuecomment-2927138882
You are receiv
b4n left a comment (geany/geany#4303)
@techee it might be related to CRLF endings (not sure), is your local file
using those? I'll try various things again, but I could crash opening the file
normally, and the CI failures suggest there is *something* wrong.
--
Reply to this email directly or v
@techee commented on this pull request.
> + * @brief Replace %-placeholders in a string
+ * @param str Format string including placeholders
+ * @param insert_replacement Callback function to insert placeholder
replacements.
+ * It gets called with the buffer to which a
techee left a comment (geany/geany#4303)
I just tried it with the php file you provided but I don't seem to be able to
reproduce the crash when the file is opened normally in Geany. Am I supposed to
do something else to reproduce it?
What I could also try to do is to do a full ctags sync (possi
@b4n pushed 0 commits.
--
View it on GitHub:
https://github.com/geany/geany/pull/4303/files/64871a67e74de9d280d5444a06d3d2074a5baefb..79fb41516f746c588a52b1b01aa805cdf31da852
You are receiving this because you are subscribed to this thread.
Message ID:
As Autotools don't show the full error on test suite failure, manually show
the relevant log files. Example showing the result:
https://github.com/geany/geany/actions/runs/15373890993/job/43256494593?pr=4303
(as this PR builds OK and thus don't show the difference)
You can view, comment on, or
@b4n pushed 1 commit.
64871a67e74de9d280d5444a06d3d2074a5baefb WIP: CI: show test logs on test
failures
--
View it on GitHub:
https://github.com/geany/geany/pull/4303/files/e38f06d4c95b6a45e3ca73ecd38925973a50c871..64871a67e74de9d280d5444a06d3d2074a5baefb
You are receiving this because you are
@b4n pushed 1 commit.
e38f06d4c95b6a45e3ca73ecd38925973a50c871 WIP: CI: show test logs on test
failures
--
View it on GitHub:
https://github.com/geany/geany/pull/4303/files/ead4ba5e53faca9358de5e1dbc4e345cf1780a20..e38f06d4c95b6a45e3ca73ecd38925973a50c871
You are receiving this because you are
@b4n pushed 1 commit.
ead4ba5e53faca9358de5e1dbc4e345cf1780a20 WIP: CI: show test logs on test
failures
--
View it on GitHub:
https://github.com/geany/geany/pull/4303/files/79fb41516f746c588a52b1b01aa805cdf31da852..ead4ba5e53faca9358de5e1dbc4e345cf1780a20
You are receiving this because you are
@b4n pushed 1 commit.
79fb41516f746c588a52b1b01aa805cdf31da852 Add test for PHP parser crash
--
View it on GitHub:
https://github.com/geany/geany/pull/4303/files/9b22c6eaac961d80f374db09c46a10377d7978be..79fb41516f746c588a52b1b01aa805cdf31da852
You are receiving this because you are subscribed
@b4n pushed 1 commit.
9b22c6eaac961d80f374db09c46a10377d7978be Add test for PHP parser crash
--
View it on GitHub:
https://github.com/geany/geany/pull/4303/files/17f60e8af441c7b97198ba90cca453a8434be6da..9b22c6eaac961d80f374db09c46a10377d7978be
You are receiving this because you are subscribed
b4n left a comment (geany/geany#4303)
Unfortunately it seems that those don't fix the issue (but it does work with
uctags…). I'll look into this if you don't have an idea of what got missed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4303#issuecom
@b4n commented on this pull request.
> @@ -623,7 +623,7 @@ static void save_dialog_prefs(GKeyFile *config)
build_save_menu(config, NULL, GEANY_BCS_PREF);
/* printing */
- g_key_file_set_string(config, "printing", "print_cmd",
printing_prefs.external_print_cmd ? printing_
@b4n pushed 3 commits.
e37e7ca6c4f372b9bbc61f727bd903ff53c820fd Early NEWS draft for 2.1
e5d793832123b64af6fb4d65e163494362777d22 Integrate Jiří's comments
a3883859c104a42ac0706e8fe56a0ea4e0b87b75 Merge a couple items, sort items by
"importance" and add a few missing links
--
View it on GitH
28 matches
Mail list logo
