asifamin13 left a comment (geany/geany-plugins#1221)
One last ping attempt until the new version :sweat_smile: @eht16 @b4n
@rdipardo @elextr
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-3032866745
You are receiving this be
asifamin13 left a comment (geany/geany-plugins#1221)
Ping, any chance this can make it into 2.1?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-2974829397
You are receiving this because you are subscribed to this thread.
Mess
@b4n @elextr @eht16 @rdipardo I just pushed a bug fix for
[this](https://github.com/geany/geany-plugins/pull/1221#issuecomment-2347381734)
I did a clean build of geany 2.1 and verified my plugin works as expected.
```
arlut@trix:~/geany-plugins$ geany -V
geany 2.1 (git >= 30f84de9a) (built on 20
@asifamin13 pushed 1 commit.
a99f196faaaff437170d53304348aee746b56f0a bracketcolors: Handle when
bracematching occurs across different styles
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1221/files/44de64d1050b2f32c574c842e7ffdc80dda59084..a99f196faaaff437170d53304348aee74
Funnily enough as I was trying to color the indent guides I found a bug with my
bracketcolors plugin.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/122
> Good thing to ping it so "somebody" is reminded to try it and merge if they
> get a chance. Otherwise things get lost/forgotten, if it happens that nobody
> has time immediately, don't leave it nearly a year until the next ping.
Understood! Would someone be so kind as to approve my latest chan
I think it would be useful and cool to colorize the indentation guides in a
similar manner. Would this functionality be better as a separate plugin or
would it make more sense to include it here but maybe rename the plugin?
--
Reply to this email directly or view it on GitHub:
https://github.c
Any chance this could make it into geany-plugins v2.0? 👀
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1754053448
You are receiving this because you are subscribed to this thread.
Message ID:
It's from [the pull
request](https://github.com/asifamin13/geany-plugins/pull/5) on my fork.
I'd appreciate any feedback, I added some GUI elements to specify custom colors
on the plugin preferences page.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plu
@eht16 I did the rebase, verified it compiles/works as expected on my rhel 8
workstation. Shall we give the CI another shot?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1622136258
You are receiving this because you are subs
@asifamin13 pushed 2 commits.
694d69d7402125f91a567734c16828f67978d0b2 Bracket Colors
44de64d1050b2f32c574c842e7ffdc80dda59084 Bracket Colors: Support user defined
colors (#5)
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1221/files/f176f5c7713be823f03a172393361b8a8fd61e9f
@alecGraves, I'd appreciate any feedback if you ever get the chance to give
this [pull request](https://github.com/geany/geany-plugins/pull/1221) a try
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1148#issuecomment-1577438588
You are receivi
Hmmm, the other CI builds seem to work without a problem. For some reason this
one isn't getting picked up:
```
This request was automatically failed because there were no enabled runners
online to process the request for more than 1 days.
```
> Ideally needs someone who isn't the author to tes
I've been daily driving this plugin for several months now. I think it's stable
enough to be merged.
The latest [CI build
failure](https://github.com/geany/geany-plugins/actions/runs/4631643800) seems
to be from misconfigured runners.
--
Reply to this email directly or view it on GitHub:
ht
I added support for loading/saving settings via a `GKeyFile`
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1522541119
You are receiving this because you are subscribed to this thread.
Message ID:
@asifamin13 pushed 1 commit.
f176f5c7713be823f03a172393361b8a8fd61e9f Bracket Colors: Support user defined
colors (#5)
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1221/files/7bef4fd162d61057ed8df89d9a47a6473e89830e..f176f5c7713be823f03a172393361b8a8fd61e9f
You are receivi
> In the future, though, I would concentrate on just getting a minimal working
> version merged, then touch it up later in small, traceable iterations. To
> paraphrase [the famous saying of
> Valéry](https://quoteinvestigator.com/2019/03/01/abandon), a pull request is
> never finished; it's aba
Fixed a bug to address a case when nested brackets weren't getting their color
updated when their parent gets updated
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1499424966
You are receiving this because you are subscribed t
@asifamin13 pushed 1 commit.
48fdf9e06f6ebdbb6ba7af8d9e649927a9173469 Bracket Colors
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1221/files/50ae4036e73836f54a37d4636d2ecfc448eeac22..48fdf9e06f6ebdbb6ba7af8d9e649927a9173469
You are receiving this because you are subscribed
Closed #1244 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1244#event-8857179553
You are receiving this because you are subscribed to this thread.
Message ID:
You are right, it does. I needed to enable `show markers margin` in
Preferences->Editor->Display. to get the "gutter" functionality
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1244#issuecomment-1485662679
You are receiving this because you
Geany is my favorite IDE, but sometimes I use VSCode in certain instances. One
feature that I really wish was in Geany is the "Gutter Indicators" that show
when a line is modified, deleted, or added.
Here is an example from VS Code
I got too aggressive squashing commits between my work and home workstations
and ended up getting other unrelated commits from upstream into my feature
branch :sweat_smile:
--
Reply to this emai
# Bracketcolors plugin
- Color { }, [ ], ( ) based on nesting order to make it easier to see the
start/end bracket
- Ignore brackets in non source code (strings, comments, doc strings, etc.)
- Language agnostic
## How it works
Allocates 3 indicators (starting at `INDICATOR_IME` - 3) to colo
Closed #1221.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#event-8723027077
You are receiving this because you are subscribed to this thread.
Message ID:
@asifamin13 pushed 1 commit.
7cd6454107f45540a1f62f4d471d78fecdd9583c Bracketcolors v1 codereview 3/10/23
(#3)
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1221/files/0850594b6132956e8a813db85020473e33c7aa6a..7cd6454107f45540a1f62f4d471d78fecdd9583c
You are receiving this
@asifamin13 commented on this pull request.
> +static gchar char_at(ScintillaObject *sci, gint pos)
+/*
+
+-
*/
+{
+return sci_get_char_at(sci, pos);
+}
When I was writing this, I was using the `autoclose` plug
@eht16 I incorporated your suggested changes. I'm still learning Github, I
apologize if I'm not navigating this pull request correctly 😅 (at my work, I'm
used to Gitlab)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-141827606
Reopened #1221.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#event-8441755413
You are receiving this because you are subscribed to this thread.
Message ID:
>
> Looks good! Thanks.
>
> > While "rainbow colours" sounds nice "Bracketcolors" is more descriptive, so
> > a user looking for it is more likely to find it.
>
> Full agree. @asifamin13 maybe you could just mention "rainbow colors" in the
> README, that might already suffice that users can
Closed #1221.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#event-8441754664
You are receiving this because you are subscribed to this thread.
Message ID:
@asifamin13 commented on this pull request.
> @@ -0,0 +1,32 @@
+Color brackets, parenthesis, and braces
+===
thanks, fixed!
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#discussion_r1096813044
You are receiving this beca
@asifamin13 commented on this pull request.
> +// nested bracket
+orderStack.push(endPos);
+}
+
+GetOrder(bracket) = orderStack.size() - 1;
+}
+}
+
+
+
+//
-
+void Bracket
@asifamin13 commented on this pull request.
> @@ -0,0 +1,35 @@
+# =
yes, is there a better way to handle this? I'm new to the autotools world, so
any recommendations would be appreciated
--
Reply to this email dire
@asifamin13 commented on this pull request.
> +
+static Length& GetLength(Bracket &bracket) {
+return std::get<0>(bracket);
+}
+static Order& GetOrder(Bracket &bracket) {
+return std::get<1>(bracket);
+}
+
+static const Length& GetLength(const Bracket &bracket
@asifamin13 commented on this pull request.
> @@ -0,0 +1,143 @@
+/*
+ * BracketMap.cc
+ *
+ * Copyright 2013 Asif Amin
thanks for catching this, fixed!
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#discussion_r1096812623
You
@asifamin13 pushed 1 commit.
0ac738a0532a8638bbe9d9bd55aed0eac671df78 Bracket Colors, initial code review
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1221/files/b75167c3c1d56d476abc06458a84ee84b7d907ca..0ac738a0532a8638bbe9d9bd55aed0eac671df78
You are receiving this becaus
I implemented this [here](https://github.com/geany/geany-plugins/pull/1221). It
also colors brackets and braces.
I took inspiration from the VSCode "bracket-pair-colorizer" extension and
copied the default colors for light and dark backgrounds.
--
Reply to this email directly or view it on G
I updated the commit message with a reference to that issue. Raindow brackets
sounds cool, I wish I knew of that issue before starting this
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1416857959
You are receiving this beca
45 matches
Mail list logo
