[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)

2024-05-20 Thread Christoph Reiter via Github-comments
lgtm -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3878#issuecomment-2120623130 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Use only a single type for a given configuration data item (PR #3642)

2023-10-26 Thread Christoph Reiter via Github-comments
I can confirm that things build with this at least. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3642#issuecomment-1781184462 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

2023-10-26 Thread Christoph Reiter via Github-comments
An alternative would be to replace all checks for WIN32 in the code with _WIN32, but there are lots of places.. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3660#issuecomment-1781180150 You are receiving this because you are subscribed to this

[Github-comments] [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

2023-10-26 Thread Christoph Reiter via Github-comments
To match the autotools build. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3660 -- Commit Summary -- * meson: correctly set WIN32 in config.h -- File Changes -- M meson.build (4) -- Patch Links --

[Github-comments] [geany/geany] meson error: meson.build:446:32: ERROR: The `==` operator of bool does not accept objects of type int (1) (Issue #3618)

2023-10-20 Thread Christoph Reiter via Github-comments
$ meson --version 1.2.2 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3618 You are receiving this because you are subscribed to this thread. Message ID: