[Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-17 Thread Edgar
It would be nice if the selected text would be inserted into the "Search for:" input when pressing [Ctrl]+[F]. I know this behaviour from Notepad++ and it is very helpful. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: htt

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-18 Thread Edgar
I noticed that the default behaviour of Geany is to put the selected text into the "Search for:" as long the search dialog is not opened. If you open it using [Ctrl]+[F] or via the menu does not matter. Since the feature is already implemented I think it should be a little bit easier to just a

[Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' (default: FALSE) [...] (#2695)

2020-12-20 Thread Edgar
See issue #2693. Adds hidden preference 'always_set_from_selected' (default: FALSE) which updates search phrase with selected text when search/replace dialog is reopened. Default behaviour is not changed. You can view, comment on, or merge this pull request online at: https://github.com/geany

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-20 Thread Edgar
I created a pull request now, see #2695. Is it okay if I do another PL for the manual later? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#issuecomment-748676763

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' (default: FALSE) [...] (#2695)

2020-12-20 Thread Edgar
> Where is the preference set? It should be on the find dialog not just read > from the config file. Since I don't think there is a need to often turn on/off this preference, I don't think we should extend the search/replace dialog with this setting, so I choosed the way of making it a hidden p

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' (default: FALSE) [...] (#2695)

2020-12-21 Thread Edgar
> The name of the option always_set_from_selected suggested it was automatic, > but having had a chance to look at the PR code it appears to only happen on > ctrl-f (or whatever the search shortcut is set to). Correct, the update of "Search phrase:" with the selected text only happens on the "r

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' (default: FALSE) [...] (#2695)

2020-12-21 Thread Edgar
Closed #2695. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2695#event-4134789904

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' (default: FALSE) [...] (#2695)

2020-12-21 Thread Edgar
@etkaar pushed 0 commits. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2695/files/30b2a5c2e81801c36a324b649ecf7c8b57aed37d..d2740f21feb84b6f951398c6f683674b2b56bfed

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' (default: FALSE) [...] (#2695)

2020-12-21 Thread Edgar
@elextr Short question: How do I update the docs? By manually editing both _geany.txt_ and _geany.html_ or is there a another way? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2695#issu

[Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-21 Thread Edgar
See issue #2693. Adds hidden preference 'always_set_from_selected' (editable in the various preferences) which always updates the search phrase in search dialogs with selected text after reopening the dialog (esp. using shortcuts), since default behaviour is to insert selected text as search ph

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-21 Thread Edgar
Closed because of pending Pull Request: #2697 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#issuecomment-748866968

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-21 Thread Edgar
Closed #2693. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#event-4135081562

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' (default: FALSE) [...] (#2695)

2020-12-21 Thread Edgar
@elextr Yes, the next time I should better use Comment and not delete it. I deleted it because I in the meanwhile found out that _geany.html_ is automatically updated when I edit _geany.txt_. I made a new Pull Request (#2697) and think now all is correct (but the .html is not transferred to Git

[Github-comments] [geany/geany] Transparent search/replace dialogs when out of focus (#2698)

2020-12-21 Thread Edgar
I am used to have the Find/Replace dialogs opened all the time and would like to have an option to make it a little bit transparent (50% or something) while out of focus. I believe there is no such preference yet implemented. I think it can be also a useful feature for other users, so I think ab

Re: [Github-comments] [geany/geany] Transparent search/replace dialogs when out of focus (#2698)

2020-12-21 Thread Edgar
Way more easy then I initially thought – I was not aware that I can use CSS since it is the first time at all I work with GTK: Add at the end of _Tools > Configuration Files > geany.css_: ``` /* make search dialogs transparent if out of focus */ #GeanyDialogSearch:backdrop { background-c

[Github-comments] [geany/geany] Suppress "... was not found" message (#2699)

2020-12-21 Thread Edgar
Is there a way to suppress the "... was not found" message? I would rather like to only have the "Search for:" highlighted (which already happens) instead of _additionally_ getting and needing to interact with this dialog. --- ![Screenshot from 2020-12-21 19 05 58](https://user-images.githubuse

Re: [Github-comments] [geany/geany] Suppress "... was not found" message (#2699)

2020-12-21 Thread Edgar
Closed #2699. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2699#event-4137113112

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-21 Thread Edgar
@codebrainz Correct, intention is **1**. I closed the old PR because of the branch issue **and** because I changed the PL to also apply to _Search > Find in Files_. If I understand your patch correct, it would change the default behaviour to do exactly that what my PL does, but per default and

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-21 Thread Edgar
> Perhaps I'm missing the use case for not wanting the search text to be > updated. Well, I also personally don't see a use case for it, but on the other side, I don't see that many users complained. Also there must be a reason why the search phrase is (seems intentionally?) not updated in the

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-27 Thread Edgar
How should we proceed here? 1. Not changing default behaviour, but adding the hidden preference with default FALSE (= **this PR**). 2. Changing default behaviour by adding the hidden preference with default TRUE (= only a _slight_ change on this PR). 3. Changing default behaviour without adding

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-28 Thread Edgar
@elextr @kugel- Thanks a lot for your votes, then we will go with **3**. @elextr However, I feel it would make more sense for me to create a new branch (and so a new PL) for that, since it is more a fix than a feature and so the original changes would be kept. Would that be okay? -- You are re

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-28 Thread Edgar
@codebrainz Perfect, then I will do that. I am not so familiar with all of that, but it makes fun! Thanks for your help. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2697#issuecomment-7

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-28 Thread Edgar
@etkaar pushed 1 commit. 6185afa4241d9861394af82fca61c63fcd53c107 Update search phrase for search/replace dialogs always with selected text on dialog reopening (especially when using shortcuts). -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://g

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-28 Thread Edgar
@etkaar pushed 0 commits. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2697/files/6185afa4241d9861394af82fca61c63fcd53c107..d2740f21feb84b6f951398c6f683674b2b56bfed

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-28 Thread Edgar
Closed #2697. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2697#event-4152334810

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-28 Thread Edgar
Reopened #2697. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2697#event-4152365533

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-28 Thread Edgar
I was a bit struggling, sorry for any inconvinience, but I think now the correct commit is used for this PL now. @codebrainz I have used your patch, it seems to work as intended after compiling and testing. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' [...] (#2697)

2020-12-28 Thread Edgar
@codebrainz You're welcome, thanks for the help :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2697#issuecomment-751859461

[Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

2021-01-03 Thread Edgar
If I create files (`Ctrl+N`) then new files _untitled_, _untitled_, ... will be created. Once Geany gets closed, a save dialog is going to be opened for each of these files. Is there a way to preserve those files in the editor without being forced to save them, so they and their content would b

[Github-comments] [geany/geany] No .conf file for the default color scheme? (#2718)

2021-01-03 Thread Edgar
Is there no .conf file for the default color scheme of geany? In `geany/data/colorschemes` I was only able to find _alt.conf_. It would be interesting what exactly is possible to change using a colorscheme.conf in `~/.config/geany`. -- You are receiving this because you are subscribed to this

Re: [Github-comments] [geany/geany] No .conf file for the default color scheme? (#2718)

2021-01-03 Thread Edgar
Thank you! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2718#issuecomment-753684395

Re: [Github-comments] [geany/geany] No .conf file for the default color scheme? (#2718)

2021-01-03 Thread Edgar
Closed #2718. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2718#event-4162850416

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

2021-01-04 Thread Edgar
What about a native feature which 1. changes the naming behaviour from `untitled, untitled, ...` to `untitled 1, untitled 2, ...`, and 2. keeps all those files opened in the editor after restart, without being forced to save them on disk. **Reason** People may use these untitled files just for

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

2021-01-04 Thread Edgar
Why not as a native feature via Pull Request? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2717#issuecomment-753847098

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

2021-01-04 Thread Edgar
> Its not something that appears to be vastly desired or needed in the core > since this is the first time its been asked for, so it should be in a plugin, > at least to start with. Okay! What are the general reasons for when it is better to make a plugin instead of a core feature? E.g. there i

[Github-comments] [geany/geany] Are different colorschemes possible for embed code? (#2719)

2021-01-04 Thread Edgar
I try to modify my colorscheme, but I am not sure if my approach would work at all, so I want to ask: I have an HTML file where PHP and JavaScript code is embed. Usually my JavaScript code would have a bluish background color, while HTML has a white and PHP a yellowish/greenish background color

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

2021-01-04 Thread Edgar
I had now a look into the builtin plugin `Save Actions`. I think the asked feature could fit into this plugin; however it seems, it would need an additional tab because it is a very different approach. I for instance do not wish any autosaving of already existing, opened files, I only want that

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

2021-01-04 Thread Edgar
> To be clear, the editing notebook is for _files_ it doesn't handle anything > else, and changing that is a big change. Would do you mean by _editing notebook_? > Your other option is to add tabs to the message window, like extra scribble > tabs, but that would be a whole new plugin. It would

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

2021-01-04 Thread Edgar
I see, so changing the naming behaviour can be risky. > Beware, there are things that assume unsaved tabs are called "untitled" so > its likely that change will break other stuff, including in templates IIRC, > and in plugins that are not part of Geany itself. > To be clear, if they are to surv

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

2021-01-04 Thread Edgar
@codebrainz Yes, looks like a duplicate. @elextr Since multiple users are asking for it, are we still looking for a plugin (which seems to not exist), or could we implement it as core feature using a Pull Request? I will close this issue in favor of continuing the discussion in #905. -- You ar

Re: [Github-comments] [geany/geany] Preserving the 'untitled' files (#2717)

2021-01-04 Thread Edgar
Closed #2717. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2717#event-4164267737