[Github-comments] Re: [geany/geany] Wrong filename in titlebar after launch (Issue #3684)

2024-04-28 Thread Jiří Techet via Github-comments
I've bisected this to https://github.com/geany/geany/pull/3267. The original code contained the `switch_to_session_page()` function which emitted the `switch-page` signal even in the case when the right tab was already selected (so no real switch happened) which then lead to correct "document-ac

[Github-comments] [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-04-28 Thread Jiří Techet via Github-comments
This is an experiment to use GtkFileChooserNative on Windows and macOS to address issues like https://github.com/geany/geany-osx/issues/14 where the GTK dialogs don't offer the best user experience. I kept using GtkFileChooser on Linux because it adds extra widgets to the dialog like file enco

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Jiří Techet via Github-comments
> To confirm, the first is Windows? The second macOS? Both with GIO? Only speaking for the macOS part - yes, the second message is on macOS with GIO. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081536322 You are receiving t

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Jiří Techet via Github-comments
So I get ``` 17:47:11.712578: Updatechecker MESSAGE : Checking for updates (querying URL "https://geany.org/service/version/";) 17:47:14.085164: Updatechecker WARNING : Unable to perform version check: Operation not supported ``` in debug messages and also the corresponding popup error :-(. --

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Jiří Techet via Github-comments
> What do you mean, with GIO, with libsoup, with anything? If it doesn't work > neither on macos not Windows, it starts to feel like nobody is gonna be using > it 😆 Yeah, it was with libsoup which, when using gtk-osx for building dependencies, depends on gnutls: https://gitlab.gnome.org/GNOME/

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-04-28 Thread Jiří Techet via Github-comments
@b4n Thanks for having a look at it - I'll address the changes you suggested. > Apart from that, I was kind of disappointed that the "goto file" only lists > Geany open documents rather than the project's documents -- maybe you'd like > to add that? Definitely makes sense for projectorganizer w

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread Jiří Techet via Github-comments
> @techee any chance you could check whether gvfs works with HTTP(S) under > macos? The thing is that I didn't even manage to get tls running correctly (it compiled but https didn't work afterwards, probably some configuration issue) so the updatechecker plugin isn't part of the macOS release.

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-04-27 Thread Jiří Techet via Github-comments
I also added a commit updating the matlab parser to the upstream regex-based one. I'd like to avoid the situation that we have to maintain our (non-regex) version of the parser like in: https://github.com/geany/geany/pull/3358 https://github.com/geany/geany/pull/3563 Also, the kinds generated b

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-04-27 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. aa0c796b5c1e6a1b6a4050086309a5864819eca3 Switch to uctags regex-based matlab parser d515bce2167fd8623c83dc51e38562a4b822d019 Use repoinfo.h with the used tag version -- View it on GitHub: https://github.com/geany/geany/pull/3859/files/978eb03e3bb33612013495054238fbc

[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-04-27 Thread Jiří Techet via Github-comments
@techee pushed 8 commits. 7943b7d9ec47805caac6b071ca13da4a73c14326 Add ldscript parser f21e1de08482a73fdc41694e7dbc81c9735a29dc Update parser kind mappings e00a2684d34446ae7426ee8e00349f8d3595e2fc Map title/subtitle of the rst parser cdf1aa1fbc7ba8d93dc3373a0c8600a80a4c03be Map defines to tm_t

[Github-comments] [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)

2024-04-27 Thread Jiří Techet via Github-comments
There were mostly expected "problems" like new source files that had to be added, rename of `perl6.c` to `raku.c`, update of kind mappings, etc. The only unexpected thing is the behavior of the javascript parser - this is from the javascript commit message: There are lots of differences because

[Github-comments] [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)

2024-04-26 Thread Jiří Techet via Github-comments
This feature allows quick navigation do document/workspace symbols based on their names, open files, and line numbers. The panel's code is mostly stolen from the LSP plugin which in turn stole it from the Colomban Wendling's Commander plugin. You can view, comment on, or merge this pull request

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-04-25 Thread Jiří Techet via Github-comments
Looks good in general, but I think folding should work when the cursor is anywhere in the block, not just on the fold point (vim seems to work this way). I played with it a little and came up with something like this: ```C static gint prepare_fold(CmdParams *p) { /* foldparent of the next

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-04-25 Thread Jiří Techet via Github-comments
Seems to make sense, just curious when the problem exactly happens - could you give an example when the output of the plugin differs from vim? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1328#issuecomment-2077625275 You are receiving this bec

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-04-25 Thread Jiří Techet via Github-comments
I'm not sure this is the correct way to address the issue. I think we should take the folds into account and perform the motion commands on top of the visible lines instead of the document lines. I tried to replace this PR with https://github.com/geany/geany-plugins/pull/1338 Please let me know

[Github-comments] [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-04-25 Thread Jiří Techet via Github-comments
This PR addresses some issues of the plugin with folded lines - see the individual commits. I'd also like to automatically set the cursor position when a block gets folded to be set on the visible line (and not hidden somewhere inside the fold) but right now I don't know how to correctly react

[Github-comments] Re: [geany/geany] non-deterministic anon_struct (Issue #3717)

2024-04-23 Thread Jiří Techet via Github-comments
Closed #3717 as completed via #3785. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3717#event-12582302054 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-23 Thread Jiří Techet via Github-comments
Merged #3785 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3785#event-12582301897 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-23 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -241,6 +241,33 @@ void tm_ctags_clear_ignore_symbols(void) } +static gboolean replace_str(gchar **where, const gchar *what, gsize what_len, + const gchar *replacement, gsize replacement_len) +{ + if (where && *where) + { +

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-23 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. aa4e901807e8f0294f25d9f4ef3516b775ce0b8d Rename both scope and var_type of anonymous types -- View it on GitHub: https://github.com/geany/geany/pull/3785/files/5196a10f764402fc3f0f55af0c9236b30df80e71..aa4e901807e8f0294f25d9f4ef3516b775ce0b8d You are receiving this bec

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-23 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -241,6 +241,33 @@ void tm_ctags_clear_ignore_symbols(void) } +static gboolean replace_str(gchar **where, const gchar *what, gsize what_len, + const gchar *replacement, gsize replacement_len) +{ + if (where && *where) + { +

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-23 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -241,6 +241,33 @@ void tm_ctags_clear_ignore_symbols(void) } +static gboolean replace_str(gchar **where, const gchar *what, gsize what_len, + const gchar *replacement, gsize replacement_len) +{ + if (where && *where) + { +

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-23 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -241,6 +241,33 @@ void tm_ctags_clear_ignore_symbols(void) } +static gboolean replace_str(gchar **where, const gchar *what, gsize what_len, + const gchar *replacement, gsize replacement_len) +{ + if (where && *where) + { +

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-23 Thread Jiří Techet via Github-comments
I had to make one more change, replace `guint` with `gsize` in `what_len` and `replacement_len`: ```C static gboolean replace_str(gchar **where, const gchar *what, gsize what_len, const gchar *replacement, gsize replacement_len) ``` because otherwise ```C gchar *str = g_malloc(where_len +

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-23 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 5196a10f764402fc3f0f55af0c9236b30df80e71 Rename both scope and var_type of anonymous types -- View it on GitHub: https://github.com/geany/geany/pull/3785/files/fb85cc0766c9e0d8fac18183fcf97add1fd87fa0..5196a10f764402fc3f0f55af0c9236b30df80e71 You are receiving this bec

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-23 Thread Jiří Techet via Github-comments
@b4n Thanks for the review! I've just re-pushed the version with the changes you suggested. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3785#issuecomment-2073401138 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-23 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. fb85cc0766c9e0d8fac18183fcf97add1fd87fa0 Rename both scope and var_type of anonymous types -- View it on GitHub: https://github.com/geany/geany/pull/3785/files/b8f94bea10a6c525f206ce18c5c5320f77136268..fb85cc0766c9e0d8fac18183fcf97add1fd87fa0 You are receiving this bec

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-23 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -241,6 +241,29 @@ void tm_ctags_clear_ignore_symbols(void) } +static void replace_str(gchar **where, const gchar *what, guint what_len, + const gchar *replacement, guint replacement_len) +{ + if (where && *where) + { +

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Use g_pattern_spec_match_string() instead of g_pattern_match_string() (PR #1334)

2024-04-23 Thread Jiří Techet via Github-comments
Merged #1334 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1334#event-12578774929 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] geanyctags: Use g_pattern_spec_match_string() instead of g_pattern_match_string() (PR #1333)

2024-04-23 Thread Jiří Techet via Github-comments
Merged #1333 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1333#event-12578767327 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] projectorganizer: Use g_pattern_spec_match_string() instead of g_pattern_match_string() (PR #1334)

2024-04-23 Thread Jiří Techet via Github-comments
Eliminates a warning on newer glib versions. Adds a fallback on older versions. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1334 -- Commit Summary -- * projectorganizer: Use g_pattern_spec_match_string() instead of g_pattern_ma

[Github-comments] [geany/geany-plugins] geanyctags: Use g_pattern_spec_match_string() instead of g_pattern_match_string() (PR #1333)

2024-04-23 Thread Jiří Techet via Github-comments
With a fallback on older glib versions. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1333 -- Commit Summary -- * geanyctags: Use g_pattern_spec_match_string() instead of g_pattern_match_string() -- File Changes -- M geanyc

[Github-comments] Re: [geany/geany-plugins] vimode: eliminate a warning (PR #1332)

2024-04-23 Thread Jiří Techet via Github-comments
Merged #1332 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1332#event-12578572469 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] vimode: eliminate a warning (PR #1332)

2024-04-23 Thread Jiří Techet via Github-comments
This is just a binary for testing and the missing icons don't matter. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1332 -- Commit Summary -- * vimode: eliminate a warning -- File Changes -- M vimode/src/backends/backend-viw

[Github-comments] Re: [geany/geany-plugins] [WIP] Add LSP plugin (PR #1331)

2024-04-23 Thread Jiří Techet via Github-comments
@techee pushed 4 commits. 5927a2d03d773173f5927c167dba021f24ec435e Move json and jsonrpc libraries to a separate directory 609db8491771845e8263e2381ab96c3acbd5a65f Don't use ifdef within a macro da340f53c5b1214defafd68f9f9c771317e6ba95 Don't send SIGTERM on Windows where sending signals is no

[Github-comments] Re: [geany/geany-plugins] [WIP] Add LSP plugin (PR #1331)

2024-04-22 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 4eef8fc8d81cf4c43139a3b16979037b6f5cae60 Add LSP plugin files to POTFILES.in -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/d66f8e6081c2ef3a10bd7dc5c01054ccf149a699..4eef8fc8d81cf4c43139a3b16979037b6f5cae60 You are receiving this because yo

[Github-comments] Re: [geany/geany-plugins] [WIP] Add LSP plugin (PR #1331)

2024-04-22 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. d66f8e6081c2ef3a10bd7dc5c01054ccf149a699 Check glib version for function availability -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/35a584636d67f8b8c782e4e4372c444adecd9fa1..d66f8e6081c2ef3a10bd7dc5c01054ccf149a699 You are receiving this

[Github-comments] [geany/geany-plugins] [WIP] Add LSP plugin (PR #1331)

2024-04-22 Thread Jiří Techet via Github-comments
This is a work-in-progress PR to add the LSP plugin. There are still some things missing like the documentation but in general the plugin should work. There are 3 modes of operation: 1. Without Geany LSP support 2. With basic LSP support using https://github.com/geany/geany/pull/3849 3. With ful

[Github-comments] Re: [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-04-21 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 1931fcc2f4d5de46871c85a782903d8c4d41e699 Export some types/functions so plugins have access to Geany symbol icons -- View it on GitHub: https://github.com/geany/geany/pull/3849/files/6db24b8a5f6eb56d3b883ea7c1ae2f78401e4692..1931fcc2f4d5de46871c85a782903d8c4d41e699 You

[Github-comments] [geany/geany] Complete plugin extensions patches (PR #3850)

2024-04-21 Thread Jiří Techet via Github-comments
This is the complete counterpart of #3849, including the sidebar symbol patches and also https://github.com/geany/geany/pull/3707 and https://github.com/geany/geany/pull/3572. These are all the diffs against Geany itself from https://github.com/techee/geany-lsp. You can view, comment on, or mer

[Github-comments] [geany/geany] Plugin extensions (aka LSP API) (PR #3849)

2024-04-21 Thread Jiří Techet via Github-comments
This is my second attempt on the LSP API as originally proposed by #3571. I changed several things: 1. I renamed the struct `Lsp` to `PluginExtension` - there's nothing LSP-specific in this interface and it could be used by other plugins too (or possibly extended in the future if some plugins wa

[Github-comments] Re: [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-04-17 Thread Jiří Techet via Github-comments
@b4n Does it look OK to you? We have to rename the anonymous tag name both in scope and var_type so I moved the renaming to a separate function and call the function both on scope and var_type. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3785#issue

[Github-comments] Re: [geany/geany] Erlang: display module node in the symbols tree (PR #3837)

2024-04-17 Thread Jiří Techet via Github-comments
@techee approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3837#pullrequestreview-2006227960 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Erlang: display module node in the symbols tree (PR #3837)

2024-04-17 Thread Jiří Techet via Github-comments
LGTM. By the way, I think there are quite a few of these `tm_tag_undef_t` as I just grabbed the upstream parsers and only mapped those kinds we used previously and left the rest unmapped. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3837#issuecommen

[Github-comments] Re: [geany/geany] Update HACKING with find_shebang() and editor_set_indentation_guides() (PR #3795)

2024-03-20 Thread Jiří Techet via Github-comments
Merged #3795 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3795#event-12191048939 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Update HACKING with find_shebang() and editor_set_indentation_guides() (PR #3795)

2024-03-19 Thread Jiří Techet via Github-comments
Inspired by https://github.com/geany/geany/pull/3169 which was missing the update of find_shebang(), we should mention this in HACKING. I also noticed we kind of neglected updating editor_set_indentation_guides() - not sure if it's very important but at least worth mentioning in HACKING. You ca

[Github-comments] Re: [geany/geany] Add Ocaml ctags parser (PR #3163)

2024-03-19 Thread Jiří Techet via Github-comments
@eht16 @b4n What do you think about including the ocaml ctags parser? It's not strictly necessary but since it's in ctags and "for free", I'd say why not. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3163#issuecomment-2008215856 You are receiving this

[Github-comments] Re: [geany/geany] Add Ocaml ctags parser (PR #3163)

2024-03-19 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. c509b9000633acd9c9af93f15a84a3f4e6dd5ad3 Add Ocaml ctags parser -- View it on GitHub: https://github.com/geany/geany/pull/3163/files/d25365aed87acd92065a02962142d848cd301bbf..c509b9000633acd9c9af93f15a84a3f4e6dd5ad3 You are receiving this because you are subscribed to t

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-19 Thread Jiří Techet via Github-comments
Meh, I forgot how github handles fixup commits and kind of assumed they get auto-squashed when merging a PR (which didn't happen). So there's a slight mess as the fixup commits were preserved. Sorry for that. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/p

[Github-comments] Re: [geany/geany] Raku comment #`{comment} not recognized properly (Issue #3053)

2024-03-19 Thread Jiří Techet via Github-comments
Closed #3053 as completed via #3169. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3053#event-12176146469 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Raku Syntax Highlighting (#2456)

2024-03-19 Thread Jiří Techet via Github-comments
Closed #2456 as completed via #3169. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2456#event-12176146516 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-19 Thread Jiří Techet via Github-comments
Merged #3169 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3169#event-12176146188 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] RFE: please add support for Perl6 (Raku) (Issue #3054)

2024-03-19 Thread Jiří Techet via Github-comments
Closed #3054 as completed via #3169. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3054#event-12176146420 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-18 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -604,6 +605,7 @@ static GeanyFiletype *find_shebang(const gchar > *utf8_filename, const gchar *line { "sh", GEANY_FILETYPES_SH }, { "bash", GEANY_FILETYPES_SH }, {

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-18 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. fad5af87e74dbb3850c0e3a5cb764894dbc2151c fixup! Add Raku (Perl 6) filetype support (lexer and ctags parser) -- View it on GitHub: https://github.com/geany/geany/pull/3169/files/3b666ca60dc70039b6ede71a9323eb994256f6b4..fad5af87e74dbb3850c0e3a5cb764894dbc2151c You are r

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-18 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + { 2, "types_basic", FALSE }, + { 3, "types_composite", FALSE }, + { 4, "types_domain",FALSE }, + { 5, "types_exceptions",FALSE }, If I understand it correctly, TRUE indicates the gr

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-18 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > +functions=ACCEPTS AT-KEY EVALFILE EXISTS-KEY Filetests IO STORE abs accept > acos acosec acosech acosh acotan acotanh alarm and antipairs asec asech asin > asinh atan atan2 atanh base bind binmode bless break caller ceiling chars > chdir chmod chomp

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-17 Thread Jiří Techet via Github-comments
> I gave it some testing and it works fine. I want to repeat I'm really bad at > Perl and saw Raku the first time now. Btw, I did not fell in love with it :D. Good, I was worried we'd have to rewrite Geany in it :-) > The perl6.c parser is taken from uctags, I assume. If so, we probably should

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-17 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 3b666ca60dc70039b6ede71a9323eb994256f6b4 fixup! Add Raku (Perl 6) filetype support (lexer and ctags parser) -- View it on GitHub: https://github.com/geany/geany/pull/3169/files/1f3c9d53effcf0c242430f4cdd5ab843d9b4c1bd..3b666ca60dc70039b6ede71a9323eb994256f6b4 You are r

[Github-comments] Re: [geany/geany-plugins] Hiding Some Type of Files in the Explorer (Issue #1258)

2024-03-17 Thread Jiří Techet via Github-comments
Closed #1258 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1258#event-12144105120 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] projectorganizer: prjorg-sidebar.c: returning 'void **' from a function with incompatible return type 'gchar **' (Issue #1297)

2024-03-17 Thread Jiří Techet via Github-comments
Closed #1297 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1297#event-12144100618 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] projectorganizer: prjorg-sidebar.c: Cast g_ptr_array_free to gchar** (PR #1298)

2024-03-17 Thread Jiří Techet via Github-comments
Ah, OK, I noticed this PR only after merging https://github.com/geany/geany-plugins/pull/1315 which eliminates some more warnings including this one. So I'm closing this and https://github.com/geany/geany-plugins/issues/1297. -- Reply to this email directly or view it on GitHub: https://github

[Github-comments] Re: [geany/geany-plugins] projectorganizer: prjorg-sidebar.c: Cast g_ptr_array_free to gchar** (PR #1298)

2024-03-17 Thread Jiří Techet via Github-comments
Closed #1298. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1298#event-12144100215 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] geanyctags: eliminate some warnings and update the readtags library (PR #1317)

2024-03-17 Thread Jiří Techet via Github-comments
Merged #1317 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1317#event-12144095700 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] projectorganizer: Eliminate some compiler warnings (PR #1315)

2024-03-17 Thread Jiří Techet via Github-comments
Merged #1315 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1315#event-12144095081 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Disable autocompletion for most non-programming/non-scripting languages (PR #3575)

2024-03-17 Thread Jiří Techet via Github-comments
Closed #3575. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3575#event-12144078537 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-osx] Open dialog enter file path text (#14)

2024-03-11 Thread Jiří Techet via Github-comments
> its GTK4, not GTK3 which is used by Geany It's GTK3, it's only deprecated in GTK4 (there's some other class for it in GTK4). Native dialogs would definitely be nice and if FileChooserNative works, it might be a way to go. I'll try to have a look at it if it would require many changes in Gean

[Github-comments] Re: [geany/geany-osx] Bug in Geany theme (Issue #54)

2024-03-08 Thread Jiří Techet via Github-comments
Closing here in favor of https://github.com/geany/geany-themes/issues/70 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/54#issuecomment-1986535698 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-osx] Bug in Geany theme (Issue #54)

2024-03-08 Thread Jiří Techet via Github-comments
Closed #54 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/54#event-12061363928 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-osx] Line wrapping disabled for new/freshly opened files (Issue #51)

2024-03-08 Thread Jiří Techet via Github-comments
Closed #51 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/51#event-12061353291 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-osx] Vertical Scrollbar nearly invisible after update to Geany 2.0 (Issue #55)

2024-03-08 Thread Jiří Techet via Github-comments
Closed #55 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/55#event-12061350152 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-osx] Vertical Scrollbar nearly invisible after update to Geany 2.0 (Issue #55)

2024-03-08 Thread Jiří Techet via Github-comments
Great, good to hear! I'm closing this issue as I believe the scrollbars are reasonably sized by default and overriding their size works too. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/55#issuecomment-1986533488 You are receiving this because

[Github-comments] Re: [geany/geany] non-deterministic anon_struct (Issue #3717)

2024-03-06 Thread Jiří Techet via Github-comments
@bmwiedemann I believe I fixed it in #3785. Can you confirm it fixes all the problems with glfw sources? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3717#issuecomment-1981942218 You are receiving this because you are subscribed to this thread. Mes

[Github-comments] [geany/geany] Rename both scope and var_type of anonymous types (PR #3785)

2024-03-06 Thread Jiří Techet via Github-comments
In addition to scope, anonymous type can appear also inside var_type which should be renamed as well. Fixes #3717. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3785 -- Commit Summary -- * Rename both scope and var_type of anonymous typ

[Github-comments] Re: [geany/geany-osx] "Change Font" does not seem to have effect (Issue #53)

2024-03-06 Thread Jiří Techet via Github-comments
> As a side note, web libraries (like Gnutls) are quite active as they address > CVEs, so using a non-native library that is included in your release means > you would be releasing a continuous stream of security updates. It should use > a native library that is part of Macos and so is regularly

[Github-comments] Re: [geany/geany-osx] Vertical Scrollbar nearly invisible after update to Geany 2.0 (Issue #55)

2024-03-06 Thread Jiří Techet via Github-comments
Are you sure you don't have some syntax error in `geany.css` that would possibly prevent its loading? I'd suggest that you make a backup of this file somewhere and then place just ```css scrollbar slider { min-width: 20px; } ``` in it and restart geany. If it works, you'd have to figure

[Github-comments] Re: [geany/geany-plugins] 2.0.0: build fails end compile time warnings (Issue #1303)

2024-03-05 Thread Jiří Techet via Github-comments
Well, there's also the competing https://github.com/geany/geany-plugins/pull/1238 that tries to support about everything. I haven't checked if it works, I personally would prefer supporting only a single version since nobody will be able to test all the versions (especially when the plugin is u

[Github-comments] Re: [geany/geany-plugins] Make updatechecker plugin for MacOS (Issue #1314)

2024-03-05 Thread Jiří Techet via Github-comments
See https://github.com/geany/geany-osx/issues/53#issuecomment-1978795993 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1314#issuecomment-1979741533 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] 2.0.0: build fails end compile time warnings (Issue #1303)

2024-03-05 Thread Jiří Techet via Github-comments
I've just created #1315, #1316, and #1317 to eliminate some of the warnings in my plugins. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1303#issuecomment-1979739779 You are receiving this because you are subscribed to this thread. Message I

[Github-comments] [geany/geany-plugins] geanyctags: eliminate some warnings and update the readtags library (PR #1317)

2024-03-05 Thread Jiří Techet via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1317 -- Commit Summary -- * geanyctags: fix some warnings * geanyctags: update the readtags library -- File Changes -- M geanyctags/src/geanyctags.c (12) M geanyctags/src/

[Github-comments] [geany/geany-plugins] vimode: eliminate a warning (PR #1316)

2024-03-05 Thread Jiří Techet via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1316 -- Commit Summary -- * vimode: eliminate warning -- File Changes -- M vimode/src/backends/backend-viw.c (2) -- Patch Links -- https://github.com/geany/geany-plugins/pull/

[Github-comments] [geany/geany-plugins] projectorganizer: Eliminate some compiler warnings (PR #1315)

2024-03-05 Thread Jiří Techet via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1315 -- Commit Summary -- * projectorganizer: fix invalid string comparison * projectorganizer: Add missing includes to header files * projectorganizer: fix various warnings * p

[Github-comments] Re: [geany/geany-plugins] 2.0.0: build fails end compile time warnings (Issue #1303)

2024-03-05 Thread Jiří Techet via Github-comments
> Unless "somebody" with the time and ability takes the plugin under their wing > it won't be updated to newer versions. This happened in https://github.com/geany/geany-plugins/pull/1235. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1303#is

[Github-comments] Re: [geany/geany] [RFC] API for LSP plugins (PR #3571)

2024-03-05 Thread Jiří Techet via Github-comments
I'll try to clarify my position on this PR. I didn't really receive any valuable input regarding the implementation itself (not blaming anyone, I completely understand each of us has other duties and limited time for Geany). The feedback from @elextr and @b4n was mostly related to the functiona

[Github-comments] Re: [geany/geany-osx] Vertical Scrollbar nearly invisible after update to Geany 2.0 (Issue #55)

2024-03-05 Thread Jiří Techet via Github-comments
Just have a look at the theme file at ``` /Applications/Geany.app/Contents/Resources/share/themes/Prof-Gnome/gtk-3.0/main-light.css ``` (assuming you are using the light theme, the dark one would be configured in main-dark.css) Scrollbar styling starts at line 3235. I just tried to modify ```css

[Github-comments] Re: [geany/geany-osx] "Change Font" does not seem to have effect (Issue #53)

2024-03-05 Thread Jiří Techet via Github-comments
If I remember correctly, I didn't manage to compile/configure gnutls correctly so https didn't work which is needed for the update checker plugin. Maybe things have changed, I just haven't tried recently. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/i

[Github-comments] Re: [geany/geany-osx] "Change Font" does not seem to have effect (Issue #53)

2024-03-05 Thread Jiří Techet via Github-comments
Closed #53 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/53#event-12014060462 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-osx] Bug in Geany theme (Issue #54)

2024-02-26 Thread Jiří Techet via Github-comments
The extra themes are taken from https://github.com/geany/geany-themes so you can submit a pull request fixing the bug. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/54#issuecomment-1964189770 You are receiving this because you are subscribed to t

[Github-comments] Re: [geany/geany-osx] Shortcut to toggle case does not work (Issue #52)

2024-02-26 Thread Jiří Techet via Github-comments
> Well, I don't have a globbal keybinding for ctrl+alt+u, so I don't think > there is a conflict. Some key combinations don't work for some mysterious reason - I haven't figured out why. > This is currently set to u. I guess is the denotation > of the "Apple" key (labelled command on the Appl

[Github-comments] Re: [geany/geany-osx] Bug in Geany theme (Issue #54)

2024-02-26 Thread Jiří Techet via Github-comments
Maybe you don't want to modify the theme but the ruby filetype settings: Tools->Configuration Files->Filetype Configuration->Scripting Languages->filetypes.ruby. Under the `[styling]` section you apply the colors defined in the theme to the syntactic features of the given language. The commente

[Github-comments] Re: [geany/geany-osx] "Change Font" does not seem to have effect (Issue #53)

2024-02-26 Thread Jiří Techet via Github-comments
Settings should be preserved - `~/.config/geany` isn't modified in any way when you copy-over the binary. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/53#issuecomment-1964133596 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany-osx] Shortcut to toggle case does not work (Issue #52)

2024-02-25 Thread Jiří Techet via Github-comments
The default keybindings are currently identical for all platforms (linux/Windows/macOS) and some of them don't work on macOS correctly (because they conflict with other global keybindings specific to macOS). Just change the keybinding to something that works. -- Reply to this email directly or

[Github-comments] Re: [geany/geany-osx] Bug in Geany theme (Issue #54)

2024-02-25 Thread Jiří Techet via Github-comments
You can either copy it from ``` /Applications/Geany.app/Contents/Resources/share/geany/colorschemes ``` or from https://github.com/geany/geany-themes. After its modification you can just copy it under `.config/geany/colorschemes`. -- Reply to this email directly or view it on GitHub: https://gi

[Github-comments] Re: [geany/geany-osx] "Change Font" does not seem to have effect (Issue #53)

2024-02-25 Thread Jiří Techet via Github-comments
Hmm, works for me (on Geany 2.0, macOS 14.3.1). I haven't tried 1.38 - could just be a bug in the older GTK shipped with that release. Do you have any specific reason for not using Geany 2.0? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/53#issu

[Github-comments] Re: [geany/geany] [RFC] API for LSP plugins (PR #3571)

2024-02-25 Thread Jiří Techet via Github-comments
> Doesn't matter if it works (which it seems to) it not a beauty contest or a > school homework assignment ;-). It can be beautified later if needed (but > much like the build commands implementation probably never will). But this is an API thing so it shouldn't be to terrible. I think the worst

[Github-comments] Re: [geany/geany] [RFC] API for LSP plugins (PR #3571)

2024-02-09 Thread Jiří Techet via Github-comments
@elextr I don't think this PR is in the state that it should be merged. Some things (like the symbol tree LSP API) are quite ugly and should be replaced by something better. I just needed to create "something" quickly so the LSP plugin could be tested and where it's easy to see for others what G

[Github-comments] Re: [geany/geany-plugins] How to install markdown plugin on Mac M1 (Issue #1305)

2024-01-28 Thread Jiří Techet via Github-comments
If I remember correctly, the markdown plugin has a webkit dependency which I'd have to build during the bundle creation and this would pretty much double the build time. Also, I'd like to avoid dependencies that have possible security-related bugs in them so I don't have to recompile Geany every

[Github-comments] Re: [geany/geany] non-deterministic anon_struct (Issue #3717)

2023-12-11 Thread Jiří Techet via Github-comments
> This generated name is created by the ctags CXX parser > [here](https://github.com/geany/geany/blob/512e88df8d97284c191459450bce4dd7877b9c2b/ctags/main/parse.c#L4795). And then we rename these in this nice function: https://github.com/geany/geany/blob/512e88df8d97284c191459450bce4dd7877b9c2b/s

[Github-comments] Re: [geany/geany] Add "session-opening" signal emitted when session opening starts/stops (PR #3707)

2023-12-01 Thread Jiří Techet via Github-comments
> Does this fix https://github.com/geany/geany/issues/3684? No. I'm not sure what is the right way to fix #3684 - whether "document-activate" should be fired also for the first tab or how exactly it should behave. But the "session-opening" signal could be used to detect this case and handle it.

[Github-comments] Re: [geany/geany] Wrong filename in titlebar after launch (Issue #3684)

2023-12-01 Thread Jiří Techet via Github-comments
There's one more problem, the MRU file list isn't updated either when the first tab is selected after Geany start so when you switch to another tab and want to go back, the first tab's document isn't in the MRU list. -- Reply to this email directly or view it on GitHub: https://github.com/geany

<    1   2   3   4   5   6   7   8   9   10   >