@kugel- approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3982#pullrequestreview-2353643515
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- commented on this pull request.
> @@ -16,9 +16,11 @@ AM_PROG_CC_C_O
AC_DISABLE_STATIC
AC_PROG_LIBTOOL
-dnl i18n
-IT_PROG_INTLTOOL([0.35.0])
-GP_I18N
Sorry for the delay. Yes, you're right, we can remove the file.
For LOCALEDIR, it seems we only use it really in C code, and we alrea
@kugel- commented on this pull request.
> GETTEXT_PACKAGE=geany-plugins
AC_SUBST(GETTEXT_PACKAGE)
AC_DEFINE_UNQUOTED(
-[GETTEXT_PACKAGE],
+o[GETTEXT_PACKAGE],
typo, file will be removed
--
Reply to this email directly or view it on GitHub:
https://github.com/gea
GI synthesizes an enum type "TMTagAttrType" with the members none_t,
name_t and so on (common prefix "tm_tag_attr_" removed). In that
context, tm_tag_attr_time_ aka. time_t clashes with the global time_t type.
Since the member is unused so far simply rename it as an easy way out.
You can view, c
As long as we don't put out a release I wouldn't worry much with API changes.
Whoever uses the development head gets the development head.
But speaking of releases, wasn't there the plan make one in the near future?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany
I have made some progress, in that peasy currently cannot generate GI stuff
against Geany's master. Need to repair that first.
Then, I would probably try to implement a python-lsp plugin in python, or do
you have a better idea?
I don' think this needs to block this PR, if you're OK that the AP
@kugel- commented on this pull request.
> + gboolean (*goto_perform)(GeanyDocument *doc, gint pos, gboolean
> definition, gpointer data);
+
+ /**
+* Pointer to function called by Geany to check whether the plugin
implements
+* additional symbol (e.g. type) highlightin
@kugel- commented on this pull request.
> + gboolean (*goto_perform)(GeanyDocument *doc, gint pos, gboolean
> definition, gpointer data);
+
+ /**
+* Pointer to function called by Geany to check whether the plugin
implements
+* additional symbol (e.g. type) highlightin
@kugel- commented on this pull request.
> + * to the members ending with @c _perform are called by Geany at appropriate
+ * moments to inform the plugin when to perform the given feature.
+ *
+ * The extension is defined by the pointers in the PluginExtension structure
and
+ * is registered in
@kugel- commented on this pull request.
> + * to the members ending with @c _perform are called by Geany at appropriate
+ * moments to inform the plugin when to perform the given feature.
+ *
+ * The extension is defined by the pointers in the PluginExtension structure
and
+ * is registered in
@kugel- commented on this pull request.
> + gboolean (*goto_perform)(GeanyDocument *doc, gint pos, gboolean
> definition, gpointer data);
+
+ /**
+* Pointer to function called by Geany to check whether the plugin
implements
+* additional symbol (e.g. type) highlightin
FWIW, I would like to ensure peasy plugins can use this APIs. I'm going to try
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#issuecomment-2198541335
You are receiving this because you are subscribed to this thread.
Message ID:
GBoxed works for non-C. You just have to add a non-C-friendly
allocation/constructor because there's no generic `g_boxed_new()`.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3910#issuecomment-2175505360
You are receiving this because you are subscribe
Generally speaking, non-C is supported well only for GObject-based interfaces.
A python plugin can easily define a GObject-derived type purely implemented in
Python.
For anything else you need at least some supporting C code around. This is
essentially what the "lib"-part of peasy does. It defi
Would need to check in detail. Have you looked the gtkdoc that's generated from
the new interfaces?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3910#issuecomment-2173696891
You are receiving this because you are subscribed to this thread.
Message ID
If it has a refcount, why not make it a `GObject` so that it's easy to create
from non-C plugins (python via peasy for example).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3910#issuecomment-2173659025
You are receiving this because you are subscribe
Didn't we have native dialogs a while ago, at least on Windows? So this brings
that back, basically?
> To me at least this isn't the most important thing and using native dialogs
> under Windows and macOS is more important IMO.
You hard-coded the native dialogs. As they don't offer all the feat
@kugel- approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3853#pullrequestreview-2016909248
You are receiving this because you are subscribed to this thread.
Message ID:
IMO meson is still experimental and we don't need to support Ubuntu 20.04. Pick
whatever meson makes the least problems for us.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2068841524
You are receiving this because you are subscribed
@elextr please read all the comments again, mine and from @b4n . Boiling them
all down to "I don't like it" is ignorant and outright rude!
You seem to be biased towards this change, perhaps because it works so well for
you, and this is OK. But be honest about it and don't play down other people'
base64 then, the solution to just about anything?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3677#issuecomment-1797890095
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- requested changes on this pull request.
> /* Not sure if we can really continue without DISPLAY. Fake X display
> perhaps?
*
* This test seems to work, at least.
*/
- gtk_init_check(&argc, &argv);
+ if(!gtk_init_check(&argc, &argv)) {
+
> > So to my understanding both sidebar features have to be implemented using
> > the fallback.
>
> I think you misunderstand the purpose of the goto-implementation, signature
> and documentSymbol calls:
I think understand the intention of the LSP interfaces. That's why I'm pretty
clear that t
I still recommend Xvfb. Geany is a GTK program, so you can expect that future
tests will also require successful GTK initialization.
But a PR that skips the test would probably be accepted. Do you know if the
`exit 77` trick works on meson as well?
--
Reply to this email directly or view it on
Sorry, I mixed it up. I mean
[Xvfb](https://www.x.org/releases/X11R7.6/doc/man/man1/Xvfb.1.xhtml). That's a
pure software emulated X environment.
Why do you execute the tests at all?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3674#issuecomment-1
@kugel- commented on this pull request.
> SSM(sci, SCI_SETILEXER, 0, (uintptr_t) lexer);
- if (old != (gint)lexer_id)
+ if (old != sci_get_lexer(sci))
Well we'll have to start somewhere. Other places can be fixed incrementally I
would say.
--
Reply to this email directly
> Use above to move TM to plugins, perhaps with LSP like API, see
> https://github.com/geany/geany/pull/3571#issuecomment-1793696182
I think we always need something like TM to have an in-process cache for
symbols/tags. We're still a lightweight IDE so a my requirement would be to not
exchange
@techee
> I don't know what exactly you want to see in this class summary, it sounds
> like you could obtain the necessary information
We don't have to deep dive into that. I just made up an example that doesn't
have a specialized LSP interface. Your reply was expected: Use other interfaces
(m
Can we have threads here? I would like to separate GTK4 and LSP discussions.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/discussions/3675#discussioncomment-7478754
You are receiving this because you are subscribed to this thread.
Message ID:
On headless systems you should run the tests under Xephyr or something similar.
That would be preferable over skipping the tests.
That's what I do when I build geany on my local Jenkins instance.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3674#is
> Using LSP only as an alternative source of tags doesn't make sense to me
> because it won't bring any better autocompletion or symbol goto so why bother.
Sorry, I didn't want to suggest to only grab tags from LSP. My point is that we
should grab tags from LSP at a minimum (and maybe use LSP in
I like LSP in general. I have a problem with your narrow view ("in a way that
the LSP interface is supposed to be used", whoever defines what "supposed to be
used" means) that leaves the TM infrastructure behind for anyone that depends
on it. TM is still active but there is no provision that TMT
> > I just don't like this proposal because it "hacks" LSP support into each
> > relevant use case instead of augmenting the existing TM infrastructure with
> > LSP information. It adds individual band-aids for each use case and leaves
> > behind other uses of the TM infrastructure (in other pl
You seem to misunderstand my point. I'm not at all against LSP, quite the
opposite. I like LSP because it seems to be industry standard by now with lots
of server-implementations (of varying quality) that loosens our "ctags lock-in".
I just don't like *this* proposal because it "hacks" LSP suppo
OK, TM is still active, but that means I may get different results when using
LSP vs TM. I.e. the list of symbols on the GUI may be different to what a
plugin gets from quering TM. This potential inconsistency makes me nervous.
This is especially true since LSP may have more build system insight
I'm not a huge fan of this. I use plugins that depend on tagmanager, therefore
I cannot use LSP.
I think this going the wrong direction. Now, for example, when "goto
definition" is requested we start some IPC or network action which can block
and/or fail, and this is going to be a nightmare to
@kugel- commented on this pull request.
> SSM(sci, SCI_SETILEXER, 0, (uintptr_t) lexer);
- if (old != (gint)lexer_id)
+ if (old != sci_get_lexer(sci))
Must be out-dated. Clearly, because of
> Some lexers may not have a lexer ID, just a lexer name in which case 0 is
> retur
@kugel- commented on this pull request.
> SSM(sci, SCI_SETILEXER, 0, (uintptr_t) lexer);
- if (old != (gint)lexer_id)
+ if (old != sci_get_lexer(sci))
We should probably deprecate `sci_get_lexer()` and stop using it internally.
--
Reply to this email directly or view it on
Still a bug if the pref is still on the UI
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3627#issuecomment-1774024049
You are receiving this because you are subscribed to this thread.
Message ID:
sorry
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3615#issuecomment-1770894859
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3616#pullrequestreview-1687593173
You are receiving this because you are subscribed to this thread.
Message ID:
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-176945
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
> And having added the feature back then, I can tell you I didn't plan for this
> :)
Alright, I am convinced it's a bug now :-)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#issuecomment-1769240269
You are receiving this because you are subscri
@kugel- commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
@kugel- commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
Actually if it's like this in 1.38 already (and possibly earlier) I see no
compelling reason to rush this into 2.0, considering that tomorrow is release.
It's not even clear to me if this is even a bug (as on "not working as
intended"). I surely never used that pref.
--
Reply to this email dir
BTW, what's the unit of the setting? pixels, chars, apples?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3612#issuecomment-1768237069
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- commented on this pull request.
> +* Add a confirmation dialog on search & replace for the whole session
+ (PR#3033).
+* Filter entry for symbol tree (PR#3055).
+* Simplify project creation from existing directories with sources
+ (PR#3042).
+* Add option to sho
Awesome! Can't find words for how much I appreciative your effort.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-1767128585
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- commented on this pull request.
> +* Add a confirmation dialog on search & replace for the whole session
+ (PR#3033).
+* Filter entry for symbol tree (PR#3055).
+* Simplify project creation from existing directories with sources
+ (PR#3042).
+* Add option to sho
@kugel- commented on this pull request.
On doc/images/main_window.png:
I like the proportions of the older screenshot better (msgwin is huge now)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#pullrequestreview-1683324927
You are receiving this
@kugel- commented on this pull request.
On doc/images/pref_dialog_various.png:
Hm, the older screenshot shows some contrast between the list items. We kind of
regressed here.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#pullrequestreview-1683
@kugel- approved this pull request.
LGBI but I only understand a fraction of it anyway
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#pullrequestreview-1680935257
You are receiving this because you are subscribed to this thread.
Message ID:
agree
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3602#issuecomment-1764367172
You are receiving this because you are subscribed to this thread.
Message ID:
I NAK'd the theme but I don't want to block any Adwaita-replacement so please
go for it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3129#issuecomment-1763146890
You are receiving this because you are subscribed to this thread.
Message ID:
I don't have enough time and motivation to play with themes on windows anytime
soon. Go with whatever you agreed.
While I NAK'd #3129 on based on my preference (so biased) I was also clear that
I won't block it (or any other theme) as long as we swap out Adwaita.
So I'm in favor of merging #312
@kugel- commented on this pull request.
> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/
' -i geany_private.rc
sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac
+sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build
@kugel- approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3599#pullrequestreview-1678401360
You are receiving this because you are subscribed to this thread.
Message ID:
Fine with me
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3591#issuecomment-1757418527
You are receiving this because you are subscribed to this thread.
Message ID:
We could introduce the new action and map to ctrl+t, and "go to definition"
becomes unbound. If "go to declaration" is essentially the same thing (as of
now, until it's fixed) then unbind it too.
If I explicitly use "go to definition" when I'm on a definition, then I
probably don't want to go t
There is also ctrl+click on the symbol. This is the way what I mostly "it" and
works like @techee describes
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3585#issuecomment-1754433029
You are receiving this because you are subscribed to this thread.
@kugel- requested changes on this pull request.
>
- /* tag name */
- if (! (tab = strchr(p, '\t')) || p == tab)
- return FALSE;
- tag->name = g_strndup(p, (gsize)(tab - p));
- p = tab + 1;
+ if (entry.kind[0] && entry.kind[1])
+
I wonder why PRs like this are open or so long and then rushed into the
release. Not enough pinging?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1752640119
You are receiving this because you are subscribed to this thread.
Message I
@kugel- approved this pull request.
Sorry
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3580#pullrequestreview-1663708673
You are receiving this because you are subscribed to this thread.
Message ID:
Go for it, it's approved after all.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3568#issuecomment-1752163855
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- commented on this pull request.
> @@ -841,8 +827,8 @@ on_font_dialog_response(GtkDialog *dialog, gint response,
> gpointer user_data)
{
gchar *fontname;
- fontname = gtk_font_selection_dialog_get_font_name(
-
@techee @b4n do we still want this in 2.0?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#issuecomment-1751845522
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- requested changes on this pull request.
> @@ -841,8 +827,8 @@ on_font_dialog_response(GtkDialog *dialog, gint response,
> gpointer user_data)
{
gchar *fontname;
- fontname = gtk_font_selection_dialog_get_font_name(
-
This touches strings (doesn't it?) and we're in string freeze so I'm afraid
it's too late now.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1751834172
You are receiving this because you are subscribed to this thread.
Message ID:
I don't really want to support meson from the tarball. It's still too
experimental. If it seems to work from the tarball some guy or distro is going
to rely on it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1751683826
You are rece
> I suggest this be a setting in the filetype file, not a hard coded magic list.
Agree. And the user must be able to override this.
For Latex, I definitely disagree with this change. When I used Latex for my
master's thesis I enjoyed auto-completion for my custom macros as well as long
words.
Your call. I would welcome a first class, reference plugin for LSP support, to
show off how to do it right and to ensure Geany's support for LSP plugins
remains fully intact. I think optional dependencies are fine, Geany still works
without the plugin for the foreseeable future.
--
Reply to th
I wonder why we can't have an LSP plugin shipped with the core to ensure
support this kind of plugins properly.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3571#issuecomment-1747667145
You are receiving this because you are subscribed to this thread
@kugel- commented on this pull request.
> @@ -92,6 +92,17 @@ signal void (*document_reload)(GObject *obj, GeanyDocument
> *doc, gpointer user_d
*/
signal void (*document_before_save)(GObject *obj, GeanyDocument *doc, gpointer
user_data);
+/** Sent before save as is performed with the orig
@kugel- commented on this pull request.
> +G_BEGIN_DECLS
+
+typedef struct {
+ gboolean (*autocomplete_available)(GeanyDocument *doc);
+ void (*autocomplete_perform)(GeanyDocument *doc);
+
+ gboolean (*calltips_available)(GeanyDocument *doc);
+ void (*calltips_show)(Geany
Merged #3551 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3551#event-10555615072
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- pushed 8 commits.
19336d22946b77bbcb5131544ea0e6317cdcf6b5 Update Scintilla to version 5.3.7
9aa597e945876aa61024de1ff6398fa5eba281f0 Map new python "attribute" mapping to
identifier_2, by default.
7f78ddf694cda6a50f93dacb2d6008d6c6bcfdfe Map new ruby lex classes to existing
styles, f
CI still checks out the PR branch and runs the scripts within, doesn't it?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3568#issuecomment-1746328972
You are receiving this because you are subscribed to this thread.
Message ID:
> How should we fix it in Geany?
I don't have an answer (hence I approved this PR) but my perspective is that
Geany should the CI requirements, otherwise regular contributors might be
unable to propose certain changes without breaking CI (because they cannot fix
the CI in the same context).
Im
I would merge this just before the string freeze (which is not yet announced,
also due to #3551), but yeah I would also exclude the .po changes. Does anyone
object?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3570#issuecomment-1746280818
You are rec
Fine. I'll merge and bump the plugin API separately.
Regarding
https://groups.google.com/g/scintilla-interest/c/_tiE_nSaiG4/m/v0e8lzTjAQAJ, I
think it's a bit too early to jump on that patch. The problem seems to an
extreme edge case and the proposed solution is not yet released or even in
Sci
I'm on the 2.0 band wagon since a long time :-)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3569#issuecomment-1746221351
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3569#pullrequestreview-1656752990
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/infrastructure/pull/11#pullrequestreview-1656752200
You are receiving this because you are subscribed to this thread.
Message ID:
Following the meta-criticism on https://github.com/geany/geany/pull/3568, why
can't we make such a change on Geany?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/infrastructure/pull/11#issuecomment-1746219630
You are receiving this because you are subscribed to t
@kugel- approved this pull request.
Meta-criticism: I dislike that that we (apparently) cannot fix this in Geany
alone but need a change on geany/infrastructure. Regular contributors are not
really able to propose such changes.
--
Reply to this email directly or view it on GitHub:
https://gi
Apart from that (we can merge that patch individually if we agree on it), is
there anything blocking?
The PR adds new string thanks to the change history feature so need to merge
before the string freeze
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/
Merged #1776 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#event-10504179477
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#pullrequestreview-1649689904
You are receiving this because you are subscribed to this thread.
Message ID:
Seems trivial and enough time has passed. @Akronix can you resolve the conflict?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1776#issuecomment-1738071821
You are receiving this because you are subscribed to this thread.
Message ID:
AFAIK scintilla needs C++17 since version 4?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3551#issuecomment-1736868344
You are receiving this because you are subscribed to this thread.
Message ID:
I added a commit to enable the change history since it was trivial. Seems like
a nice, user-visible change to take along (gives a bit of a modern feeling).
Before saving
![before_save](https://github.com/geany/geany/assets/564520/2b3e306a-6523-4db8-85ed-9705fbbee23c)
After saving
![after_save](h
@kugel- pushed 1 commit.
e4feb5cab6e4e2b878fae7be7cbd20ceb729fedf Enable new Scintilla "Change History"
--
View it on GitHub:
https://github.com/geany/geany/pull/3551/files/4e4b3ed43d594577d1738759e2d99aae1358049a..e4feb5cab6e4e2b878fae7be7cbd20ceb729fedf
You are receiving this because you are
https://github.com/ScintillaOrg/lexilla/issues/206 fixed after the 5.2.7
release. I did not backport the fix. I think R is not relevant enough to carry
an additional change to Lexilla, or is it?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3551#issue
@kugel- pushed 3 commits.
e8505313619d77a162f4a0cb620b9aee28dbb22c Update scintilla_changes.patch
b7655b6920d213f8de8dfd102fe8aacae69a70ab Update to Scintilla 5.3.7 and Lexilla
5.2.7
4e4b3ed43d594577d1738759e2d99aae1358049a Update
scintilla/scintilla_changes.patch and update-scintilla.sh
--
@eht16 do you know what's wrong with the Windows CI?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3551#issuecomment-1734884952
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3178 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3178#event-10470363906
You are receiving this because you are subscribed to this thread.
Message ID:
> @kugel- don't forget
> [this](https://sourceforge.net/p/scintilla/code/ci/652df80a41a010f404be51410d921f2df8b7175a/),
> fixes crasher in
> [geany/geany-plugins#1272](https://github.com/geany/geany-plugins/issues/1272)
Scintilla 5.3.7 was released including the fix. I'll bump to that version.
LGBI
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3560#issuecomment-1732530464
You are receiving this because you are subscribed to this thread.
Message ID:
1 - 100 of 137 matches
Mail list logo