[Github-comments] Re: [geany/geany-plugins] [Plugin Request] Toggle menu bar (Issue #1380)

2024-11-01 Thread xiota via Github-comments
I wouldn't mind adding the hide menubar lua script to examples. However, I'm waiting for bug fix PR #1234 before doing anything else. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1380#issuecomment-2452303643 You are receiving this because y

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix geany.activate() (PR #1234)

2024-10-25 Thread xiota via Github-comments
> the plugin is broken, because one of its functions is not working Anything that needs changes to this PR? > Any news? I'm waiting for someone to review and commit. Maybe @frlan or @elextr ? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/123

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix geany.activate() (PR #1234)

2024-10-24 Thread xiota via Github-comments
> my voice has little weight ... I didn't find any problems. Thanks for testing. Helpful for you to have checked in case I miss something else. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2436725306 You are receiving this

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix geany.activate() (PR #1234)

2024-10-24 Thread xiota via Github-comments
@Skif-off No problem. Might help to have additional confirmation that this PR is working as expected. You've tested it after the rebase? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1234#issuecomment-2436189761 You are receiving this because

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Support for LuaJIT and Lua 5.1-5.4 (PR #1238)

2024-10-13 Thread xiota via Github-comments
@xiota pushed 1 commit. ddd7ea509c6ef5bc651b5e4f88c9039875bc35df GeanyLua: Fix Lua 5.1 compat function -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1238/files/e93bacb506b5f8d911d6d8773856ec105c15726f..ddd7ea509c6ef5bc651b5e4f88c9039875bc35df You are receiving this because

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Support for LuaJIT and Lua 5.1-5.4 (PR #1238)

2024-10-13 Thread xiota via Github-comments
@xiota pushed 3 commits. 756db853add57a776383af2152cee3423f247720 GeanyLua: Don't ignore with-lua-pkg configure option 599766dae8fce6e9e4604f5946497248c4343ebc GeanyLua: Add support for Lua 5.2+ e93bacb506b5f8d911d6d8773856ec105c15726f GeanyLua: Add compatibility for Lua 5.1 and L

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix geany.activate() (PR #1234)

2024-10-13 Thread xiota via Github-comments
Confirmed original issue described in #1229 and this PR fixes it. Used `list-open-files.lua` to test. Force pushed to rebase. Also corrected `> 0` to `>= 0`. I had misunderstood @Skif-off's previous comment. @b4n Should be ready for review and merge. -- Reply to this email directly or view

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix geany.activate() (PR #1234)

2024-10-13 Thread xiota via Github-comments
@xiota pushed 1 commit. 17fe2b18ed41b959a27b691091dc574f280b4027 GeanyLua: Fix geany.activate() -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1234/files/db1cafc56e2947d5a3e854cdb7c38dac3fd9a178..17fe2b18ed41b959a27b691091dc574f280b4027 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] FIX: GeanyLua: 'Choose' dialog size/appearance (b4n's patch) (PR #1376)

2024-10-07 Thread xiota via Github-comments
@b4n I think this is ready to merge. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1376#issuecomment-2397444149 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] FIX: GeanyLua: 'Choose' dialog size/appearance (b4n's patch) (PR #1376)

2024-10-07 Thread xiota via Github-comments
@xiota approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1376#pullrequestreview-2352487916 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix with-lua-pkg configure flag, Add option to use LuaJIT (PR #1233)

2024-10-06 Thread xiota via Github-comments
Closed #1233. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1233#event-14531553048 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] FIX: GeanyLua: 'Choose' dialog size/appearance (b4n's patch) (PR #1376)

2024-10-06 Thread xiota via Github-comments
I've updated the lua plugin and updated status to "odd fixes". I've confirmed issue #1374 and that this PR fixes it. @Skif-off Up to you whether you want to remove the gtk version check before merge. There are others, so they can be sweeped up together in a future PR. If you intend to leave

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Adopt and change status to Odd Fixes (PR #1375)

2024-10-06 Thread xiota via Github-comments
Thank you everyone. Will start looking through issues and PRs. Who should I @ when a PR looks ready for final review/merge? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1375#issuecomment-2395584115 You are receiving this because you are subs

[Github-comments] [geany/geany-plugins] GeanyLua: Adopt and change status to Odd Fixes (PR #1375)

2024-09-30 Thread xiota via Github-comments
Request to adopt and change status to Odd Fixes in hopes of facilitating bug fix commits. Open to comaintaining, if other user is interested. (@Skif-off?) If adoption is successful, would review #1234 / #1229 to ensure it's still needed and functions as expected. You can view, comment on, or m

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Fix geany.activate() (PR #1234)

2024-09-29 Thread xiota via Github-comments
I haven't looked at this in a while. Behavior originally intended is to "Actvate and focus" a document. The original inner conditional `if (idx != ...)` prevented both. Also, `gtk_notebook_set_current_page` most likely already performs necessary checks, so additional checks wastes processor c

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-06-16 Thread xiota via Github-comments
> This doesn't mean we can't still drop the plugin if people want, I still > don't mind even if I spent some time on this 🙂 This type of plugin seems inherently dangerous... But up to people to install and run what they want. -- Reply to this email directly or view it on GitHub: https://githu

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-21 Thread xiota via Github-comments
I was curious about the upper limit because of problems described as being related to "newer GLib". But I guess the "invalid syntax" will or has been fixed? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2122364199 You are re

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-20 Thread xiota via Github-comments
What's the range of glib versions this plugin is supposed to work with? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2121342610 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)

2024-04-28 Thread xiota via Github-comments
> which assumes ReST markup I added the new lines because it was easier for me to read the text version. I ran it through pandoc to preview, and saw no difference. But with a different parser or added stylesheet, there could be extra space between the items. Like the difference between: ```

[Github-comments] Re: [geany/geany-plugins] Add ability to build with meson (PR #1345)

2024-04-28 Thread xiota via Github-comments
@xiota pushed 1 commit. 442647c436a1188e07d8c9a56264436e1c989d34 meson: fix workflow -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1345/files/a7d524b70dda93657149b90a378ce91813b1d2ac..442647c436a1188e07d8c9a56264436e1c989d34 You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany-plugins] Add ability to build with meson (PR #1345)

2024-04-28 Thread xiota via Github-comments
@xiota pushed 1 commit. a7d524b70dda93657149b90a378ce91813b1d2ac meson: fixes, update, workflow -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1345/files/6efe0f6a6c798684b90ac8b2c287f4c9803ab0c9..a7d524b70dda93657149b90a378ce91813b1d2ac You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)

2024-04-28 Thread xiota via Github-comments
@xiota commented on this pull request. > +* Wizard to create new LaTeX documents in a fast and easy way + with a bunch of templates available + +* A front end for add labels ``\label{}`` and references ``\ref{}`` and + ``\pageref{}`` with getting suggestion from aux file of docum

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-28 Thread xiota via Github-comments
> `GET request failed: WinHttp error: SECURE_CHANNEL_ERROR` > > `Unable to perform version check: Operation not supported` To confirm, the first is Windows? The second macOS? Both with GIO? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#i

[Github-comments] [geany/geany-plugins] Add ability to build with meson (PR #1345)

2024-04-28 Thread xiota via Github-comments
This PR adds ability to build with meson. It does not attempt to duplicate autotools-specific functionality, like testing the presence of specific headers or functionality of build-system components. All plugins build successfully with meson. They all appear to load and unload correctly. Som

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-27 Thread xiota via Github-comments
> it uses Geany's own `utils_open_browser()`, so that suggests this doesn't > work for you either? I had seen the browser setting, but don't know what actually uses it. Same with the terminal command. What actually uses it? I also often have ... "send selection to" not working until I restar

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-27 Thread xiota via Github-comments
> has again pointed out the point I made a while back about this I realized later that you'd already said it. You're too far ahead. Takes a while to catch up. > four plugins to synchronise This number could be reduced... -- Reply to this email directly or view it on GitHub: https://github.c

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-27 Thread xiota via Github-comments
> not available in Debian before Bookworm (12, current stable) Do Debian and Ubuntu even bother rebuilding packages for old releases? After testing the plugin, I think it should be dropped. Most of the pastebins don't work. There's no confirmation of what it's sending. Half the time, there's

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-04-26 Thread xiota via Github-comments
Tested... Seems to work. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2080360294 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-04-26 Thread xiota via Github-comments
I think a problem with gio method is depends on gvfs (gnome) and not available on msys2 and brew (win/mac). Wondering now about libcurl vs libsoup. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079619971 You are receiving th

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-25 Thread xiota via Github-comments
Someone could run the test program on windows or mac to find out. I no longer have (easy) access to either. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078735830 You are receiving this because you are subscribed to this th

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-25 Thread xiota via Github-comments
It is separate from GIO. This is the project page: https://gitlab.gnome.org/GNOME/gvfs Debian package, appears to be `gvfs-backends` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078714133 You are receiving this because you

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-25 Thread xiota via Github-comments
I use whatever is provided by the package manager. Even on Debian, pkg-config is a dummy package that redirects to pkgconf. Their stance doesn't seem particularly "aggressive" in context because they call out "passive-aggressive people who try to argue with us". Seems they probably had some p

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-25 Thread xiota via Github-comments
> Unfortunately the GIO docs don't say when `g_file_new_from_URI()` and the > associated stream was supported (that I could see) but it works on the > machine I'm on ATM which is pretty olde. Looks like it depends on `gvfs`... After uninstalling... ``` $ ./test Error reading uri. ``` > PS I ex

[Github-comments] Re: [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)

2024-04-25 Thread xiota via Github-comments
I'm new to meson, but switched my preview plugin over to it. One way it could be done... * Each plugin would have its own `meson.build` and `meson.options` that can be built independently. * The files should require minimal changes between plugins. * Building and testing individual plug

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-25 Thread xiota via Github-comments
Size check is needed if this route is taken for the plugin... That code was intended to check whether `https://` is supported because I saw only `file://` mentioned in the docs. Typical version string is <8 bytes. Even with words like `alpha` or `pre-release`, I figured 32 bytes is enough for

[Github-comments] Re: [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)

2024-04-25 Thread xiota via Github-comments
The "freeze" isn't by explicit policy, but is what has effectively happened to plugins that aren't of primary interest to developers with commit privileges. If it helps facilitate bug fixes and minor improvements, I'm willing to be (interim) maintainer for the Markdown and GeanyLua plugins. I

[Github-comments] Re: [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)

2024-04-25 Thread xiota via Github-comments
Submitting a plugin to the geany-plugins collection would require freezing the code, even for bug fixes. I'm not willing to do that for a plugin I actively use, so never submitted it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1282#issuec

[Github-comments] Re: [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)

2024-04-25 Thread xiota via Github-comments
most distros until the next release. Looks like Peppermint is based on Debian Bookworm, so I'd expect the [build instructions](https://github.com/xiota/geany-preview/blob/main/docs/Building_on_Linux.md) to work with minimal changes. If not, feel free to open a new issue on the project page. I

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-25 Thread xiota via Github-comments
> `g_file_new_for_uri()` and `g_file_read()` (or > `g_file_read_async()/g_file_read_finish()` It works... ```C #include #include int main() { GFile *file = g_file_new_for_uri("https://geany.org/service/version/";); GError *error = NULL; GFileInputStream *stream = g_file_read(file, NULL

[Github-comments] Re: [geany/geany-plugins] Consider to add a plugin to support Asciidoctor (Issue #1282)

2024-04-25 Thread xiota via Github-comments
I have a plugin that shows a [preview](https://github.com/xiota/geany-preview) of several lightweight markup types... It needs refactoring... but works well enough. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1282#issuecomment-2077438240

[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)

2024-04-25 Thread xiota via Github-comments
@xiota commented on this pull request. > @@ -26,9 +26,9 @@ Prominent features Requirements -This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18), -GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to -work. If you intend

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-24 Thread xiota via Github-comments
@xiota commented on this pull request. > @@ -185,15 +191,30 @@ version_compare(const gchar *current_version) } -static void update_check_result_cb(SoupSession *session, -SoupMessage *msg, gpointer user_data) +static gchar *bytes_to_string(GBytes *bytes) +{ +gsize bytes_s

[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)

2024-04-24 Thread xiota via Github-comments
@b4n Thanks... I've squashed the commits. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#issuecomment-2076289869 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)

2024-04-24 Thread xiota via Github-comments
@xiota commented on this pull request. > @@ -185,15 +191,30 @@ version_compare(const gchar *current_version) } -static void update_check_result_cb(SoupSession *session, -SoupMessage *msg, gpointer user_data) +static gchar *bytes_to_string(GBytes *bytes) +{ +gsize bytes_s

[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)

2024-04-24 Thread xiota via Github-comments
@xiota pushed 1 commit. c8d5d229d73c2ddcbcfcca3fd3557f77c74d3d94 Markdown: Update version numbers -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1335/files/4003ca4cd882cdfb44cd86749d1c4630b0c10c56..c8d5d229d73c2ddcbcfcca3fd3557f77c74d3d94 You are receiving this because you

[Github-comments] [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)

2024-04-24 Thread xiota via Github-comments
Add support for webkit2gtk-4.1. Drop support for webkitgtk. Related: #1295 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1335 -- Commit Summary -- * Markdown: Allow building with webkit2gtk-4.1 * Markdown: Remove webkitgtk sup

[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)

2024-04-24 Thread xiota via Github-comments
* Loads and seems to function when built with either webkit2gtk 4.0 or 4.1. * Key bindings all work when conditions for their function are met. * The reload on save function works. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#issuecomment-

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Use luaL_Reg instead of luaL_reg (PR #1231)

2024-04-23 Thread xiota via Github-comments
This was a straightforward find/replace to update the name of a struct. It is a necessary precursor to other updates/fixes of this plugin. Please merge. Thank you. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1231#issuecomment-2074156447 Y

[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)

2024-04-23 Thread xiota via Github-comments
So... checking availability of any library on the oldest Ubuntu LTS release should be sufficient? For webkit2gtk, there are a couple discontinued functions that probably need to be updated. Ubuntu 20.04 could be supported with conditional compilation, but if there will be no new geany/plugins

[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)

2024-04-23 Thread xiota via Github-comments
@elextr In a comment somewhere, you mention you're on an LTS distro without access to webkit2gtk-4.1? So I can look up what libraries you have available, what distro and release is it? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#issuec

[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)

2024-04-23 Thread xiota via Github-comments
I don't use this plugin, but can test it to help facilitate its update if provided a list of things to check. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#issuecomment-2073071561 You are receiving this because you are subscribed to this t

[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)

2024-04-23 Thread xiota via Github-comments
So... waiting until 2025, when Ubuntu 20.04 is EOL, so can use [g_string_replace()](https://github.com/geany/geany-plugins/pull/1128#issuecomment-954651043)? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#issuecomment-2073015248 You are rec

[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)

2024-04-14 Thread xiota via Github-comments
Changed the options and how they interact because I wanted to see what it would be like. * scrollwheel_lines (4): Number of lines for normal scrolling. Still don't know how to get the system default. * scrollwheel_alt_factor (6): Multiplier when alt is pressed, instead of pgup/pgdown. This i

[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)

2024-04-14 Thread xiota via Github-comments
@xiota pushed 1 commit. 33e4ade264f5f09f3c886c60a08eb263847159eb Change filtering algorithm, add more options -- View it on GitHub: https://github.com/geany/geany/pull/3835/files/f6efbf6b55862187bfcfbb58c00ce209258cbc6b..33e4ade264f5f09f3c886c60a08eb263847159eb You are receiving this because

[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)

2024-04-14 Thread xiota via Github-comments
@xiota commented on this pull request. > sci_scroll_columns(editor->sci, amount); return TRUE; } + else if (!event->state || (editor_prefs.scrollwheel_zoom_disable && (event->state & GDK_CONTROL_MASK))) If I want to remove

[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)

2024-04-14 Thread xiota via Github-comments
@xiota commented on this pull request. > sci_scroll_columns(editor->sci, amount); return TRUE; } + else if (!event->state || (editor_prefs.scrollwheel_zoom_disable && (event->state & GDK_CONTROL_MASK))) I didn't unders

[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)

2024-04-13 Thread xiota via Github-comments
@xiota commented on this pull request. > sci_scroll_columns(editor->sci, amount); return TRUE; } + else if (!event->state || (editor_prefs.scrollwheel_zoom_disable && (event->state & GDK_CONTROL_MASK))) Some existing code

[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)

2024-04-13 Thread xiota via Github-comments
> Why is it transforming ctrl+scroll to scroll differently ... instead of doing > nothing ...? The mouse wheel would look broken if scrolling stopped when control is accidentally pressed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3835#issuecommen

[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)

2024-04-13 Thread xiota via Github-comments
@xiota commented on this pull request. > @@ -2681,6 +2681,9 @@ indent_hard_tab_width The size of a tab > character. Don't change8 editor_ime_interactionInput method editor (IME)'s candidate 0 to new

[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)

2024-04-13 Thread xiota via Github-comments
@xiota commented on this pull request. > +void sci_scroll_lines(ScintillaObject *sci, gint lines) +{ + SSM(sci, SCI_LINESCROLL, 0, (uptr_t) lines); +} + + Same could be said of... https://github.com/geany/geany/blob/a44df8bb570e5d43f882649826e5d34ca3907a63/src/sciwrappers.c#L1015-L1

[Github-comments] Re: [geany/geany] Add option to disable zooming (via the scroll wheel) (PR #2954)

2024-04-13 Thread xiota via Github-comments
Closed #2954. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2954#event-12457795627 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)

2024-04-13 Thread xiota via Github-comments
This PR adds two options to control scrollwheel behavior. * `scrollwheel_lines`: How many lines to scroll. * `scrollwheel_zoom_disable`: To disable zooming by control + scrollwheel. Control of vertical scrolling is taken away from Scintilla to provide consistent behavior when the control key is

[Github-comments] Re: [geany/geany] Add option to disable zooming (via the scroll wheel) (PR #2954)

2024-04-12 Thread xiota via Github-comments
@elextr Should unlocking zoom levels to be in a separate PR, or okay to bundle with the option to turn off scroll-wheel zooming? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2954#issuecomment-2052742604 You are receiving this because you are subscribe

[Github-comments] Re: [geany/geany] Add option to disable zooming (via the scroll wheel) (PR #2954)

2024-04-11 Thread xiota via Github-comments
@elextr I'll look into your suggestion. Assuming it works well, should it go into a new PR or modify this one? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2954#issuecomment-2050940140 You are receiving this because you are subscribed to this threa

[Github-comments] Re: [geany/geany] Add option to disable zooming (via the scroll wheel) (PR #2954)

2024-04-11 Thread xiota via Github-comments
@elextr Probability of getting this reviewed/merged if I rebase and update for current git head? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2954#issuecomment-2050874954 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add a 1px black border around the tab-switcher (Issue #3797)

2024-03-24 Thread xiota via Github-comments
I see now. Yes, different popup. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3797#issuecomment-2017027850 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add a 1px black border around the tab-switcher (Issue #3797)

2024-03-24 Thread xiota via Github-comments
Unknown reason, the tab switcher dialog on my computer is named GeanyDialog, and the CSS I pasted does work. Maybe the switcher dialog should be assigned a name (GeanyDialogSwitcher?) so that it can be styled more easily after the next release. -- Reply to this email directly or view it on Git

[Github-comments] Re: [geany/geany] Add a 1px black border around the tab-switcher (Issue #3797)

2024-03-24 Thread xiota via Github-comments
I found the name "GeanyDialog". Maybe following should be added to default `geany.css` because the existing dialog (at least on my computer) is a borderless rectangle that blends in with the background. ``` #GeanyDialog { border-width: 2px; border-style: solid; border-col

[Github-comments] Re: [geany/geany] Add option and keybinding to hide menubar (PR #2972)

2024-03-13 Thread xiota via Github-comments
> none of the Geany-plugins devs had enough interest in those capabilities or > enough time available at that point to examine it Features that devs have no interest in have low chance of being added. This applies to most projects. Would rather devs evaluate bug fix PRs than new features few o

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Support for LuaJIT and Lua 5.1-5.4 (PR #1238)

2023-10-09 Thread xiota via Github-comments
Rebased on master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1238#issuecomment-1754075288 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Support for LuaJIT and Lua 5.1-5.4 (PR #1238)

2023-10-09 Thread xiota via Github-comments
@xiota pushed 4 commits. 73f8ff294f5130892f9637d848e199f235b15354 GeanyLua: Use luaL_Reg instead of luaL_reg e99bc00050722d343e9419e68adf39421657d22d GeanyLua: Don't ignore with-lua-pkg configure option 53cc8414a2227eb9ca1d2e840a90d3d52e671e52 GeanyLua: Add support for Lu

[Github-comments] Re: [geany/geany] Update Scintilla to version 5.3.6 (PR #3551)

2023-09-12 Thread xiota via Github-comments
[0001-Fix-assertion-failure-on-some-system-when-an-INDIC_S.patch.gz](https://github.com/geany/geany/files/12593500/0001-Fix-assertion-failure-on-some-system-when-an-INDIC_S.patch.gz) See: * [geany-plugins#1272](https://github.com/geany/geany-plugins/issues/1272) * [scintilla/652df8](https://sour

[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with color-variant-selector emojis (Issue #1272)

2023-09-12 Thread xiota via Github-comments
@nyamatongwe When I tested, I put the conditional return statement before the `PLATFORM_ASSERT` line: ``` void SurfaceImpl::DrawRGBAImage(PRectangle rc, int width, int height, const unsigned char *pixelsImage) { if (width == 0) return; PLATFORM_ASSERT(context); ``` I noticed i

[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with color-variant-selector emojis (Issue #1272)

2023-09-12 Thread xiota via Github-comments
Isn't that too convoluted? Creating a PR for a PR? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1272#issuecomment-1716788396 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with color-variant-selector emojis (Issue #1272)

2023-09-12 Thread xiota via Github-comments
Geany no longer aborts with `if (width == 0) return;` pasted on a new line after `scintilla/gtk/PlatGTK.cxx:610`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1272#issuecomment-1716487056 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with color-variant-selector emojis (Issue #1272)

2023-09-11 Thread xiota via Github-comments
I built and installed geany as a package, but looking through the [PKGBUILD](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=geany-git), don't see anything turning off debug. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1272#issuecom

[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with color-variant-selector emojis (Issue #1272)

2023-09-11 Thread xiota via Github-comments
geany git/3787677de; without rebuilding plugins, same issue. Rebuilding geany-plugins 27af15f9 for geany-git (without reverts), same issue. Following obtained from this build. Configure output. ``` aclocal: installing 'build/cache/glib-gettext.m4' from '/usr/share/aclocal/glib-gettext.m4' ac

[Github-comments] Re: [geany/geany-plugins] Spell Check plugin crashes with ZWJ emojis (Issue #1272)

2023-09-11 Thread xiota via Github-comments
Note: Occurs when "Toggle spell check" option is enabled. Disabling the option, no crash. Same problem with 27af15f9 with reverts to allow use with Geany 1.38 (5e130960bc6b9f3b3158cdb35d27f6bba03ba3c5 and 01b19d2d401f49f220157f28cc5e53de491f71a9). Unable to build for Geany git/1.39 because L

[Github-comments] [geany/geany-plugins] Spell Check plugin crashes with ZWJ emojis (Issue #1272)

2023-09-11 Thread xiota via Github-comments
Spell Check plugin crashes whenever I paste text containing: 😀️ or 🙂️. I believe they are ZWJ emojis because searching for them in a search engine produces the following in the location bar: 😀%EF%B8%8F 🙂%EF%B8%8F. Pasting the non-ZWJ versions, 😀 and 🙂, does not cause the plugin to crash. Using

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-07 Thread xiota via Github-comments
@xiota pushed 1 commit. 5f6bf44a760c1470108225921bbe27fede592e88 Replace set-output with $GITHUB_OUTPUT -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/e831ca1eb3eec50fb1ab6095cb23e2a7d419de92..5f6bf44a760c1470108225921bbe27fede592e88 You are receiving this because

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-07 Thread xiota via Github-comments
Changed to `actions/checkout@v3` and `actions/cache@v3` because of message: > Node.js 12 actions are deprecated. ... There are some more messages. > The `save-state` command is deprecated and will be disabled soon. Please > upgrade to using Environment Files. For more information see: > https:

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-07 Thread xiota via Github-comments
@xiota pushed 1 commit. e831ca1eb3eec50fb1ab6095cb23e2a7d419de92 Use actions/checkout@v3 and actions/cache@v3 in workflow -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/01faecc2dde77f5b188f3d30d1317e9405b15c45..e831ca1eb3eec50fb1ab6095cb23e2a7d419de92 You are

[Github-comments] Re: [geany/geany-plugins] Project Organizer: Add option to open current folder in file manager and terminal (PR #1126)

2023-03-06 Thread xiota via Github-comments
Force push to rebase on master and remove some extraneous files from unrelated plugins that were accidentally added to the commit. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1126#issuecomment-1457541666 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Project Organizer: Add option to open current folder in file manager and terminal (PR #1126)

2023-03-06 Thread xiota via Github-comments
@xiota pushed 1 commit. 7e86828684c07622f2c2387db1785c73a2b04c50 Project Organizer: Add ability to open file manager and terminal -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1126/files/6cd488ae7a872e0812c19257488dcb24f598ec20..7e86828684c07622f2c2387db1785c73a2b04c50 You

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Support for LuaJIT and Lua 5.1-5.4 (PR #1238)

2023-03-06 Thread xiota via Github-comments
@xiota pushed 1 commit. 76dc5277a4688a30210d6587164e805ca96074d6 Remove multiterm plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1238/files/f35cc080cf4bbc87335198304172403525a77ee3..76dc5277a4688a30210d6587164e805ca96074d6 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
@xiota pushed 1 commit. 01faecc2dde77f5b188f3d30d1317e9405b15c45 Remove more pieces of multiterm -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/47d383eef6f6b0869b61768275037f8dffa9816b..01faecc2dde77f5b188f3d30d1317e9405b15c45 You are receiving this because you

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
@xiota pushed 1 commit. 47d383eef6f6b0869b61768275037f8dffa9816b Remove multiterm -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/271bb6008885595d868baf01ea62735f7261e82b..47d383eef6f6b0869b61768275037f8dffa9816b You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
I'll test a more complete removal of multiterm to see what happens. Can revert if it goes bad or otherwise unwanted. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#issuecomment-1457404773 You are receiving this because you are subscribed t

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
distcheck is evil: ``` config.status: error: cannot find input file: `multiterm/Makefile.in' ``` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#issuecomment-1457402260 You are receiving this because you are subscribed to this thread. Messag

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
When I run distcheck locally (not using Ubuntu though), the problem is vala cannot find vte. Maybe there is a separate package that vala needs to use vte? The reason the `--disable-*` flags don't work is distcheck runs configure *after* whatever it's doing that's failing. I'm going to try disa

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
@xiota pushed 2 commits. 00ab93929840cf88b8d14b8d5f04eddc432500d6 Disable multiterm in Makefile.am 271bb6008885595d868baf01ea62735f7261e82b Revert "Workflow, disable: devhelp, geanypy, multiterm, webhelper" -- View it on GitHub: https://github.com/geany/geany-plugins/pull/

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
> Thinking about it it makes sense that distcheck doesn't look at configure > options, it makes a tarball that is unconfigured (but _is_ `autogen.sh`ed). Is `autogen.sh` why multiterm is getting in there when it shouldn't? -- Reply to this email directly or view it on GitHub: https://github.co

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
@xiota pushed 1 commit. a6ffdb5acfa36999b80676357667541c58662349 Workflow, disable: devhelp, geanypy, multiterm, webhelper -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/8567c5278da79cdc18746ac95bf4118b2ade0269..a6ffdb5acfa36999b80676357667541c58662349 You are

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
@xiota commented on this pull request. > @@ -127,7 +127,7 @@ jobs: # markdown libmarkdown2-dev # markdown/webhelper -libwebkitgtk-3.0-dev +libwebkit2gtk-4.0-dev The Markdown plugin does work with `libwebkit2gtk-4.0-dev`. Gean

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
@xiota pushed 1 commit. 8567c5278da79cdc18746ac95bf4118b2ade0269 Remove devhelp and multiterm dependencies -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/afc78ddf6c32c3072b31b26bb53c687954bbda55..8567c5278da79cdc18746ac95bf4118b2ade0269 You are receiving this

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
Getting a distcheck failure related to `vte`. It may not build anymore on Ubuntu 20.04 because it's not in the repository. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1239#issuecomment-1457290925 You are receiving this because you are subscr

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
@xiota commented on this pull request. > @@ -127,7 +127,7 @@ jobs: # markdown libmarkdown2-dev # markdown/webhelper -libwebkitgtk-3.0-dev +libwebkit2gtk-4.0-dev `libwebkit2gtk-4.0-dev` is the dependency being used in the curr

[Github-comments] Re: [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
@xiota pushed 1 commit. afc78ddf6c32c3072b31b26bb53c687954bbda55 Add back some dependencies to workflow -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1239/files/d9e7c2340aab3af9356ad7c768ec40f2d4ee0c36..afc78ddf6c32c3072b31b26bb53c687954bbda55 You are receiving this because

[Github-comments] [geany/geany-plugins] Update GitHub workflow to Ubuntu 20.04 (PR #1239)

2023-03-06 Thread xiota via Github-comments
I recently saw this message after creating a pull request. > This is a scheduled Ubuntu-18.04 brownout. The Ubuntu-18.04 environment is deprecated and will be removed on April 1st, 2023. For more details, see https://github.com/actions/runner-images/issues/6002 > > Linux Build > GitHub Actions h

[Github-comments] Re: [geany/geany-plugins] GeanyLua: Add support LuaJIT and Lua 5.2-5.4 (PR #1238)

2023-03-06 Thread xiota via Github-comments
@xiota pushed 2 commits. 284085ab12815064d48b1a078d7c26af7e35893c Revert "Update workflow to use libwebkit2gtk-4.0-dev" f35cc080cf4bbc87335198304172403525a77ee3 Update workflow to update markdown/webhelper to libwebkit2gtk-4.0-dev -- View it on GitHub: https://github.com/geany/gea

  1   2   3   >