Added to gain experience with it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1502#issuecomment-320164217
Merged #1502.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1502#event-1192596863
@b4n, thats a very different PR to this since it means all users of
`is_string_style()` need to add extra tests for `is_regex_style()`.
Whilst I agree (see above) thats probably the "correct" solution, adding
regexen to string styles is a hack for now when resources to do the right thing
are
While I agree that regex shouldn't be considered regular code, I think it might
also not be a good idea to consider it a string for all the mentioned reasons
(different semantics basically). Without actually looking at all the code and
uses, I would still think we should rather special-case it
Looks fine to me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1502#issuecomment-316224297
I'd like to merge this soon so that we get it tested on master and ideally will
fit for 1.32. OK?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1502#issuecomment-316206191
> Not completely sure about SCE_PL_REGEX_VAR, it doesn't seem to be used in
> LexPerl.cxx, so hard to say what it is meant for.
Might be a leftover from a previous version, its tested against, but never set.
--
You are receiving this because you are subscribed to this thread.
Reply to this
I added the regex styles.
Not completely sure about `SCE_PL_REGEX_VAR`, it doesn't seem to be used in
LexPerl.cxx, so hard to say what it is meant for.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@eht16 pushed 1 commit.
39b6280 Add regex styles as string styles
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1502/files/aca4e1f10d58470c039221b3cb25e1d6aefcb94d..39b62801e82cb31fde8b89b4d867180aef208f24
I just added SCE_RB_STRING_Q* and SCE_C_USERLITERAL.
What do we want to about the regex styles?
Considering those styles as strings would "break" SpellCheck (provided we
change it to use `highlighting_is_*_style()` instead of its own mapping).
On the other hand, it could help the AutoClose
@eht16 pushed 1 commit.
aca4e1f Add more string styles
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1502/files/3fb9ab66a5c727bf17a072d593f734ca2c6b70d5..aca4e1f10d58470c039221b3cb25e1d6aefcb94d
@b4n, yeah, but autocomplete should not occur inside regexes as well as
comments and strings, I think there are multiple use-cases for these predicates
and we gotta be sure which one its meant to support.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
> What about REGEX types, they are usually a type of string, particularly
> SCE_C_REGEX but there are also SCE_HJ_REGEX, SCE_HJA_REGEX, SCE_PL_REGEX.
Are they strings? I agree it's not code, but I'm not quite sure it should be
string; it's rather another type of syntax than arbitrary data like
> I have no clue what SCE_C_USERLITERAL is.
Its a C++ thing :)
A class can define a suffix to go after a literal to make it define an instance
of the class instead of the type the literal usually makes. For example the
`std::string` literal `""s` is actually just a user defined literal,
Generally LGBI, but I'm only part way through, comments so far below, will go
further when I have time.
What about SCE_C_USERLITERAL its a type of string.
Also SCE_RB_STRING_QR and SCE_RB_STRING_QW
What about REGEX types, they are usually a type of string, particularly
SCE_C_REGEX but there
A bunch of string and comment styles were missing and so Geany could not
detect the corresponding styles in code.
Compared the mappings in `src/highlighting.c` against the list of used
Scintilla lexers in `scintilla/src/Catalogue.cxx` and added missing style
mappings.
I also added "stubs" for
16 matches
Mail list logo
