Merged since @elextr separated out the main issue with this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1482#issuecomment-320170618
Closed #1482 via b7c4bb0b4d3022bb0102627cb6baa854cec93dd1.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1482#event-1192628562
Ok, the overloading issue is separated to #1552, LGBI
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1482#issuecomment-316915168
@techee, things that are not used by the global filetypes will have two #es at
the start, things that are used will only have one. Its clear which are used in
global and which are not.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
Each setting in filetypes.c is read with [this
macro](https://github.com/geany/geany/blob/9f4407ca29ac4dd6401fbc0688fb8c244158ae3d/src/utils.h#L78)
rather than reading all of one config file then all of the other, but the
effect is the same, partial overriding.
And as you know build has a
> then config if not found
That's the key. I was asking if `config` is read unconditionally, and then
`configh` is read (if found) to override `config` partially.
How else does partial overriding work?
--
You are receiving this because you are subscribed to this thread.
Reply to this email
> I'd say if the user wants to override just something, he'll have to delete
> the parts of the file he doesn't want to override.
Thats why I suggested we add a`# ` to the front of each line (`s/^/# /g`).
Everything is still visible and you can still see which things are commented
out in the
> Without the fix Geany does not copy the filetype files (albeit accidentally),
> so the user config doesn't hide the system config, so currently Geany does
> the right, but user unfriendly, thing.
>
> "Fixing" the paths will make Geany do the wrong thing again so it shouldn't
> happen alone.
I just mean this PR is to fix simple bug in the code that caused a regression
from previous versions. If you want to change the behaviour overall, you should
make a new PR that properly removes/changes the affected code, leaving a bug in
the source code is not really a good idea, IMO.
--
You
Hmmm, on consideration, the whole idea of copying the global config is a bad
idea, the user configs should only contain the fields they want to change, not
hide the whole system config.
But of course just dropping the user in an empty config file is unhelpful too.
Maybe after creating the
Since filedef config files are now stored under the "filedef" subdirectory
of app->datadir, we need to add the subdirectory name when creating path
from the corresponding app->configdir otherwise the file isn't found.
You can view, comment on, or merge this pull request online at:
11 matches
Mail list logo
