> Just committed it but will try to add some more descriptive comments and
> commit message in the next days
Finally done.
I will squash the commits and take the last one's message.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
@eht16 pushed 1 commit.
3fd57630d001b066ed0e0e794c9039d77852a47f Convert working directory from UTF-8
to locale on Windows
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
> Btw, I tested successfully:
> * working directory with German umlaut, relative ASCII filename
> * working directory with German umlaut, relative filename with German
> umlaut
> * working directory with German umlaut, absolute path with German umlaut
> in directory, ASCII filename
>
Btw, I tested successfully:
- working directory with German umlaut, relative ASCII filename
- working directory with German umlaut, relative filename with German umlaut
- working directory with German umlaut, absolute path with German umlaut in
directory, ASCII filename
- working directory with
This works if we use `g_locale_from_utf8()` instead of
`utils_get_locale_from_utf8()` (the latter is just a no-op on Windows).
Just committed it but will try to add some more descriptive comments and commit
message in the next days, so my future me won't wonder so much in the next 12
years :).
@eht16 pushed 1 commit.
30706ad8ea2bcff39ebddd89cd72ae6d7d765368 Convert working directory from UTF-8
to locale on Windows
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
I did NOT test this and it's not the best solution, but given the mess about
encodings we have all around, it might be the easiest solution. So, does
something like this help?
```diff
diff --git a/src/libmain.c b/src/libmain.c
index f1fdb41ef..51c51d342 100644
--- a/src/libmain.c
+++
@elextr that makes a lot of sense to me, and would suggest that
`main_get_argv_filename()` should convert the working directory to locale (as
it'll be converted back form locale to UTF-8), or move the locale conversion
there instead *before* concatenating the wd to the arg.
--
You are
Yeah, the OPs description on #2652 makes it sound like the problem is when the
working directory has non-ASCII, not when the CLI filename has non-ASCII.
I'd look for a conversion missing where the wd is attached to the filename.
--
You are receiving this because you are subscribed to this
I'm not quite sure this makes sense, isn't `argv` in the OS encoding, which
wouldn't be GLib's *filename encoding* on Windows (it's UTF-8 there)?
I can't test, but I'm slightly skeptical if we don't have a reasonable
explanation.
--
You are receiving this because you are subscribed to this
Its unclear why the previous was added (by me) 12 years ago.
Maybe the code in main_handle_filename() or after has been
changed/improved so that it works now or the previous test case for
opening files from the command line was wrong.
This happens only when starting a new instance of Geany from
11 matches
Mail list logo
