Updated this PR in case anybody wants to give it a go. It’s quite simple and
has already been reviewed once by @b4n (and comments addressed).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pul
@kugel- No, I rebased this PR on top of another (new) PR that I now think
should be a prerequisite for it. Given that the present PR doesn’t seem to be
going anywhere, I think it can be left as is for now. Maybe #1537 has more luck
with merging, then I’ll update this one.
--
You are receiving
So you have separated the first commit to a new PR. This is good, but this one
should be updated.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1114#issuecomment-315274387
> @@ -274,6 +274,7 @@ enum GeanyKeyBindingID
> GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
> Keybinding. */
> GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
> Keybinding. */
> GEANY_KEYS_EDITOR_DELETELINETOBEGINNING,/**< Keybinding. */
> +
> @@ -560,6 +560,8 @@ static void init_default_kb(void)
> GDK_Left, GDK_MOD1_MASK, "nav_back", _("Navigate back a
> location"), NULL);
> add_kb(group, GEANY_KEYS_GOTO_FORWARD, NULL,
> GDK_Right, GDK_MOD1_MASK, "nav_forward", _("Navigate forward a
> location"), NU
> @@ -560,6 +560,8 @@ static void init_default_kb(void)
> GDK_Left, GDK_MOD1_MASK, "nav_back", _("Navigate back a
> location"), NULL);
> add_kb(group, GEANY_KEYS_GOTO_FORWARD, NULL,
> GDK_Right, GDK_MOD1_MASK, "nav_forward", _("Navigate forward a
> location"), NU
> @@ -560,6 +560,8 @@ static void init_default_kb(void)
> GDK_Left, GDK_MOD1_MASK, "nav_back", _("Navigate back a
> location"), NULL);
> add_kb(group, GEANY_KEYS_GOTO_FORWARD, NULL,
> GDK_Right, GDK_MOD1_MASK, "nav_forward", _("Navigate forward a
> location"), NU
> @@ -274,6 +274,7 @@ enum GeanyKeyBindingID
> GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
> Keybinding. */
> GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
> Keybinding. */
> GEANY_KEYS_EDITOR_DELETELINETOBEGINNING,/**< Keybinding. */
> +
> @@ -560,6 +560,8 @@ static void init_default_kb(void)
> GDK_Left, GDK_MOD1_MASK, "nav_back", _("Navigate back a
> location"), NULL);
> add_kb(group, GEANY_KEYS_GOTO_FORWARD, NULL,
> GDK_Right, GDK_MOD1_MASK, "nav_forward", _("Navigate forward a
> location"), NU
> @@ -560,6 +560,8 @@ static void init_default_kb(void)
> GDK_Left, GDK_MOD1_MASK, "nav_back", _("Navigate back a
> location"), NULL);
> add_kb(group, GEANY_KEYS_GOTO_FORWARD, NULL,
> GDK_Right, GDK_MOD1_MASK, "nav_forward", _("Navigate forward a
> location"), NU
> @@ -274,6 +274,7 @@ enum GeanyKeyBindingID
> GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
> Keybinding. */
> GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
> Keybinding. */
> GEANY_KEYS_EDITOR_DELETELINETOBEGINNING,/**< Keybinding. */
> +
> @@ -274,6 +274,7 @@ enum GeanyKeyBindingID
> GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
> Keybinding. */
> GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
> Keybinding. */
> GEANY_KEYS_EDITOR_DELETELINETOBEGINNING,/**< Keybinding. */
> +
> @@ -274,6 +274,7 @@ enum GeanyKeyBindingID
> GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
> Keybinding. */
> GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
> Keybinding. */
> GEANY_KEYS_EDITOR_DELETELINETOBEGINNING,/**< Keybinding. */
> +
> @@ -274,6 +274,7 @@ enum GeanyKeyBindingID
> GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
> Keybinding. */
> GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
> Keybinding. */
> GEANY_KEYS_EDITOR_DELETELINETOBEGINNING,/**< Keybinding. */
> +
> @@ -560,6 +560,8 @@ static void init_default_kb(void)
> GDK_Left, GDK_MOD1_MASK, "nav_back", _("Navigate back a
> location"), NULL);
> add_kb(group, GEANY_KEYS_GOTO_FORWARD, NULL,
> GDK_Right, GDK_MOD1_MASK, "nav_forward", _("Navigate forward a
> location"), NU
@vfaronov have patience, its only been a week with a release in between.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1114#issuecomment-233122501
@b4n Is there anything else I can do to help this pull request move forward?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1114#issuecomment-233121703
@b4n You’re right, “Go To” seems like a suitable group for this keybinding, as
it already has `nav_back`/`nav_forward` as well as `edit_togglemarker`. Updated.
@kugel- That’s probably a good idea, but a bit out of scope for me at the
moment. Feel free to look into it.
---
You are receiving this
On a related note, I often miss that the navqueue when searching. This can help
if I remember to add the current position, but would it be possible to add it
automatically when starting searching?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly
Otherwise looks mostly fine (untested yet). Bonus points for updating the docs
:)
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1114#issuecomment-230315746
> @@ -2175,6 +2177,11 @@ static gboolean cb_func_editor_action(guint key_id)
> case GEANY_KEYS_EDITOR_MOVELINEDOWN:
> sci_move_selected_lines_down(doc->editor->sci);
> break;
> +
> + case GEANY_KEYS_EDITOR_ADD_POSITION:
> +
> @@ -273,6 +273,7 @@ enum GeanyKeyBindingID
> GEANY_KEYS_FORMAT_SENDTOCMD7, /**<
> Keybinding. */
> GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
> Keybinding. */
> GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
> Keybindi
> @@ -273,6 +273,7 @@ enum GeanyKeyBindingID
> GEANY_KEYS_FORMAT_SENDTOCMD7, /**<
> Keybinding. */
> GEANY_KEYS_FORMAT_SENDTOCMD8, /**<
> Keybinding. */
> GEANY_KEYS_FORMAT_SENDTOCMD9, /**<
> Keybindi
Rationale is [on the devel@
list](http://lists.geany.org/pipermail/devel/2016-July/010042.html).
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1114
-- Commit Summary --
* Keybinding to remember location in history
-- File Changes --
24 matches
Mail list logo
