@b4n, on which GTK3 version, I know Geany runs with many, but really the only
stable one is 3.22.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1780#issuecomment-368291052
b4n approved this pull request.
Should be squashed, but LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1780#pullrequestreview-99132939
@elextr pushed 1 commit.
cabb606 Improve explanation
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1780/files/14f0f87d3643d20baa0f763e32cdee062b3dc4b5..cabb606087967e7d54b5d6de2e4a8bedcc9e6f07
b4n commented on this pull request.
> @@ -787,6 +787,9 @@ Building Plugins
The geany-plugins autotools script automatically detects the
installed system Geany and builds the plugins against that.
+Plugins will build with the version of GTK2/3 that the detected
+Geany was built with.
+1 for mentioning the ```--enable-gtk3``` option.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1780#issuecomment-368206722
elextr commented on this pull request.
> @@ -787,6 +787,9 @@ Building Plugins
The geany-plugins autotools script automatically detects the
installed system Geany and builds the plugins against that.
+Plugins will build with the version of GTK2/3 that the detected
+Geany was built with.
b4n requested changes on this pull request.
Otherwise, why not. Specifying a GTK3 version could be nice, but I don't
recall we decided on any yet.
Also, mentioning *2.24* is kind of irrelevant, as 2.24 is the forever latest
GTK2 version -- but that's another "issue".
> @@ -787,6 +787,9 @@
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1780
-- Commit Summary --
* Mention GTK 3 for the first time
-- File Changes --
M HACKING (9)
-- Patch Links --
https://github.com/geany/geany/pull/1780.patch
