Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread George Katevenis
Updated the manual. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2927#issuecomment-940231288

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread George Katevenis
@gkatev pushed 2 commits. 6c52d3ebe6383d96c8a6f6b524c69b6f0007deb8 Add UI option to hide the fold margin, while keeping code folding 243388414938773e9cd38f48aeb237ca041f50e0 Automatically unfold all code when folding is switched off in preferences -- You are receiving this because you are s

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread Vic
> When configuring the editor, it's useful to have everything "in reach", > instead of looking around in menus (you can't even click on menus while the > preferences are opened). ... > For example, with the 'hide fold margin' option, if you wanted to quickly > enable/disable it Good points. So

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread George Katevenis
So I don't have an opinion on whether folding should be allowed to be disabled or not, but currently it is, so I've implemented the new feature for all cases.. But, if you wanted to go ahead and remove the option to disable folding in the future, being able to hide the margin would satisfy those

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread Vic
Re: View: That sounds sensible to me. And if the setting is good for "View" menu, it shouldn't need to go into "Preferences" as well. > To be clear the comment that it is a bad idea was a general one, not > specifically aimed at this PR. Oh, I see now; my bad. -- You are receiving this becaus

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread elextr
> Is it a good idea to place these additions both in the Preferences and View > menu ? From what I can tell, many (or most) of the settings in View are > duplicates of those in Preferences. Maybe would be better to have in > Preferences only those that are not directly about Viewing the already-

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-11 Thread Vic
If you don't mind a simple user's opinion: I think these are all good changes; here's some questions and feedback: > UI Additions: Why do choose to place these additions both in the Preferences and View menu ? From what I can tell, many (or most) of the settings in View are duplicates of thos

Re: [Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-10 Thread elextr
I am not sure that being able to turn off folding is a good idea, IIUC parts of symbols handling uses it to locate the current block/function/construct. There may be other places its used as its the only part of Geany that provides structure information. Havn't looked at the changes but IRO yo

[Github-comments] [geany/geany] Option to hide the fold margin but keep folding (#2927)

2021-10-10 Thread George Katevenis
Hi, I've made changes that allow for keeping the fold margin non-visible, but still be able to fold code (eg. via the shortcuts). UI Additions: - "Show fold margin" in Preferences > Editor > Display. - "Show fold margin" in the View menu. If code folding is disabled: - The 1st UI addition become