Oh, for some reason I thought you had already merged it.
IRO the shebang, as you said in the comment, its not used in the build, it
would be only if someone wanted to run the script manually, but doesn't hurt to
update it.
--
You are receiving this because you are subscribed to this thread.
Re
This is a friendly reminder for @elextr :D.
I guess we are pretty much done with this, I think we should update the shebang
as said in https://github.com/geany/geany/pull/2903#issuecomment-940454201 but
then ready to merge?
--
You are receiving this because you are subscribed to this thread.
R
> python3 should always be present, python may not.
True but as said, in this case it doesn't matter. Autotools detect the Python
interpreter to use and then uses this to start the script, i.e. the shebang is
not evaluated at all (it executes something like `/usr/bin/python3
scripts/gen-api-gtk
python3 should always be present, python may not.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2903#issuecomment-940456637
@elextr do we want to use "python3" in the shebang of the script?
```
diff --git a/scripts/gen-api-gtkdoc.py b/scripts/gen-api-gtkdoc.py
index 75beb86c..7423257c 100755
--- a/scripts/gen-api-gtkdoc.py
+++ b/scripts/gen-api-gtkdoc.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
#
@kugel- approved this pull request.
So if you squash and add a little bit more information to the commit message
(even if it's just the statement "We migrating away from python2") I'm fine
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or vie
Yay, good thought.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2903#issuecomment-939569755
@b4n and me were wondering whether the generated header file will be different
from Python2 to Python3 while releasing 1.38.
So I gave it a try:
- For Python 3 (tested in a container, started like this: `docker run --rm -it
-v /tmp/shared:/shared debian:buster-slim`):
```
apt-get update && apt-g
@eht16 Ahhh, I know the pencil, thats how I made the
original, what I missed was selecting the branch on the dropdown on the left so
it wanted to make a new PR all the time.
@kugel- does this address your requested changes?
--
You are receiving this because you are sub
> > I've just edited `.travis.yml' in your branch (directly online via Github)
> > to make the change and a new build is running.
>
> How did you do that? As I said above I hadn't found a way and didn't think it
> was possible.
I guess it's simpler than you expect :):
I opened https://github.co
> I've just edited `.travis.yml' in your branch (directly online via Github) to
> make the change and a new build is running.
How did you do that? As I said above I hadn't found a way and didn't think it
was possible.
--
You are receiving this because you are subscribed to this thread.
Reply t
Also changed the title to try to describe better what this is about. We should
also squash the commits on merge and then set a commit message describing the
change.
This should address the mentioned formality issues.
--
You are receiving this because you are subscribed to this thread.
Reply to
12 matches
Mail list logo
