Merged #2862 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2862#event-5262829397
@codebrainz thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2862#issuecomment-913908549
@b4n yeah, the new Julia lexer uses std::string_view which is C++17 and was
causing G-P Travis failures until the distro version was updated to a modern
enough one to have C++17. And of course #2867 as soon as the next release is
done.
--
You are receiving this because you are subscribed to
@b4n approved this pull request.
Just tested with Debian Buster's regular g++ (8.3) which works, and ag++
wrapper hack (for it to fail):
```python3
#!/usr/bin/env python3
from os import execvp
from sys import argv
args = ['g++']
for arg in argv[1:]:
if arg.startswith('-std='):
I don't have a non-c++17 compiler to test, if there are no other objections or
alternatives will merge it in a week or so.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@b4n commented on this pull request.
> @@ -0,0 +1,962 @@
+# ===
+# https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html
+# ===
+#
Does autoconf find the macros automatically if the archive is installed?
Anyway this is just an upgrade of the existing C++11 test macros, not a new
thing. If somebody wants to take macros out and require a new dependency that
should be a separate PR where it can be discussed.
--
You are
There is a "autoconf-archive" package for Debian, Arch and probably most other
distros.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2862#issuecomment-902296395
The m4 files are downloaded from the Autoconf archive, they aren't shipped with
Autoconf where they would be copied from the system directory to the local m4
directory.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Do we need to copy the .m4 files? Shouldn't autogen.sh pull them?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2862#issuecomment-901367267
I suggest using this, @kugel- has already made a PR for Scintilla 5 and who
knows what that needs.
Of course its not _just_ the compiler, but also the standard library (which is
where string_view lives) that needs to be modern enough, but the compiler is
possibly a proxy for that ... maybe.
Yeah, as @elextr mentioned, the reason for the check is for an early failure
with a message explaining the compiler isn't supported.
Another way to do it would be to do a compile-test for only `std::string_view`
to also support non-C++17 compilers which might have already supported
This should be a failure in configure, hopefully with a message, instead of a
compile failure half way through make.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Doesn't a check only really useful if there is a fallback? If we fail hard
either way, why add a check?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2862#issuecomment-900047305
@elextr approved this pull request.
Thanks for that.
LGBI as much as I know.
And it indicates that AT doesn't even check for compiler standards, its a
separate m4, so I was able to add to my AT hate list which is long :grinning:
--
You are receiving this because you are subscribed to this
C++17 equivalent of previous Autoconf check that we got from the [Autoconf
Archive](https://www.gnu.org/software/autoconf-archive), which has since been
factored into two m4 files:
*
[ax_cxx_compile_stdcxx](https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html)
*
16 matches
Mail list logo
