Guess we get the clipboard fix in 5.1.4 then.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2867#issuecomment-950303373
> For the primary clipboard problem I opened
> https://sourceforge.net/p/scintilla/bugs/2287/. Surprisingly, it's the same
> for Scite and there was no open/closed issue for it.
JFTR: the primary cipboard problem has been fixed in
Thanks @kugel-!
The GeanyLua problem is already reported and linked.
For the primary clipboard problem I opened
https://sourceforge.net/p/scintilla/bugs/2287/. Surprisingly, it's the same for
Scite and there was no open/closed issue for it.
--
You are receiving this because you are
SciLexer.h fixed. Other problems are better tracked in distinct issues.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2867#issuecomment-939929530
> middle click paste in the editor widget doesn't work anymore (on Linux)
Works for external selections, ie in other apps. Looks vaguely like right
click might be moving the caret (and so removing the selection) before it
queries the selection to paste. Probably should be raised as a
> it seems we do not install include/geany/scintilla/SciLexer.h any longer. I
> guess this is not on purpose?
Ahhh, all my (and I guess @kugel-) testing was done by applying changes to an
existing build so we already had `SciLexer.h` installed. Indeed on a fresh
clone it is not installed,
Yay for early merge!
@kugel- I noticed to issues now that it is merged (which is good):
- the plugins fail to build (https://www.geany.org/p/KquBW/raw/) - maybe it's
the plugin's fault or maybe not. We should at least check if the changed
behavior is desired.
- middle click paste in the editor
@kugel- BOOM!!! now to try the upgrade process for Scintilla 5.1.2.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2867#issuecomment-939377596
Merged #2867 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2867#event-5438678406
> I think we're ready to merge here. I'd like to merge asap after 1.38 is out.
Agree, I've been using this since my comments above with no problem (but Geany
use is limited) and then we can test the upgrade process by going to 5.1.2
And thanks for doing it.
--
You are receiving this because
I think we're ready to merge here. I'd like to merge asap after 1.38 is out.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2867#issuecomment-924368071
Scintilla 5.1.2 is imminent. I'm currently planning to migrate to that in a
separate PR if that's OK, so that this PR can be merged earlier and the 5.1.{1
-> 2} diff can be treated on its own.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
During my discussions with Neil that produced the likely fix for the DevaVu
underlines he noticed that on Fedora 34 Wayland Gnome there were strange
artifacts in Scite if the scaling factor is changed with the font selection
page of Gnome Tweaks (say to 1.2 1.4 etc) see the top image
@elextr commented on this pull request.
> @@ -51,15 +54,15 @@
#include "CharacterSet.h"
#include "LexerModule.h"
-using namespace Scintilla;
+using namespace Lexilla;
static inline bool IsNewline(const int ch) {
return (ch == '\n' || ch == '\r');
Also Neil just committed a possible
And rectangular selections seems to work (the change to multiple selections was
one concern).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2867#issuecomment-912116601
> I'm about testing this on Windows. So far it built fine but I wasn't able yet
> to run Geany with the changes (due to unrelated problems with my build
> environment). Will test it later again once the other problems are resolved.
Tested and works fine. I didn't extensive testing but
I'm about testing this on Windows. So far it built fine but I wasn't able yet
to run Geany with the changes (due to unrelated problems with my build
environment). Will test it later again once the other problems are resolved.
--
You are receiving this because you are subscribed to this thread.
As far as Windows goes, probably best to wait until @eht16 can access his
laptop again to get his new Windows build Docker image, that will be GTK3 IIUC.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I was more thinking of checking if the build processes on Windows and macOS
worked. But also since Neil doesn't check Scintilla GTK on Windows or macOS
(AFAIK) they do need to be checked that there are no unforseen issues. Windows
and macOS are not the best supported platforms for GTK, so
> Windows? Macos?
Why do you think they need to be checked specifically? Don't we use the GTK
backend on those as well?
I might setup a windows vm, I guess I "want" one anyway to check meson.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
> I'll first look for any that contain only trivial changes
Good idea, eliminate those that git diff says have no real changes. Then
effort can go on those that need checking.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
I added a list of all lexers that we use. I'll first look for any that contain
only trivial changes (like namespace Scintilla -> Lexilla)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Windows? Macos? Other filetypes?
I'm interested in taking a look (on Linux) but it won't be for a few weeks.
Then I guess it means waiting for the release before merging something this big.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
@elextr @eht16 @b4n so it builds and from a quick look C and bash source code
looks alright. What are the next steps?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@kugel- pushed 1 commit.
cfc2b2294710d91a3ca3498e9d99960427a035f3 fixup! Update Scintilla to version
5.1.1
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@rdipardo commented on this pull request.
Almost there; it should be a simple matter of adding [some missing
headers](https://app.travis-ci.com/github/geany/geany/jobs/533113114#L2538):
```diff
diff --git a/scintilla/Makefile.am b/scintilla/Makefile.am
index f866ca48b..d6c85545e 100644
---
@kugel- pushed 1 commit.
e8096c76c742fbf39fadf64d9263f4ee4fd373b8 fixup! Update Scintilla to version
5.1.1
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@kugel- pushed 1 commit.
03a7f19a0921deadd11e568d5ed79adf1d8ca0e8 fixup! Update Scintilla to version
5.1.1
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@rdipardo commented on this pull request.
> @@ -51,15 +54,15 @@
#include "CharacterSet.h"
#include "LexerModule.h"
-using namespace Scintilla;
+using namespace Lexilla;
static inline bool IsNewline(const int ch) {
return (ch == '\n' || ch == '\r');
No problema; since "The Great
I removed a Makefile.am but didn't update configure.ac, that's probably why.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2867#issuecomment-901365856
@kugel- commented on this pull request.
> @@ -51,15 +54,15 @@
#include "CharacterSet.h"
#include "LexerModule.h"
-using namespace Scintilla;
+using namespace Lexilla;
static inline bool IsNewline(const int ch) {
return (ch == '\n' || ch == '\r');
I downloaded the last zip. I guess
@kugel- ummm, can you see why travis has failed? It looks like configure was
missing Makefile.in, but autogen.sh should have generated it IIUC?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@rdipardo commented on this pull request.
> @@ -51,15 +54,15 @@
#include "CharacterSet.h"
#include "LexerModule.h"
-using namespace Scintilla;
+using namespace Lexilla;
static inline bool IsNewline(const int ch) {
return (ch == '\n' || ch == '\r');
Correct me if I'm wrong, but it
Update to scintilla, incl. lexilla split-off.
Closes #2824
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2867
-- Commit Summary --
* Update Scintilla to version 5.1.1
* Update scintilla_changes.patch
* Update update-scintilla.sh
--
34 matches
Mail list logo
