Ok, thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1784#issuecomment-372100797
Closed #1784.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1784#event-1514966210
OK I found the root cause of the issue, which actually is a problem on our
side. See #1799 for details and a fix.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@b4n: thanks for the info. I also played around with the cursor a bit. I
managed to use it as a replacement but also noticed that it does not make any
difference. Setting selection mode to none also does not help.
> Obviously we can't filter anymore, but the selection/cursor doesn't jump
>
> Also, we really should be using the treeview's cursor rather than the
> selection, but well.
I haven't used cursors yet. How should it be used? Somewhat like this:
- on clicking a checkbox in the pluing manager set the cursor to the path given
to ```pm_plugin_toggled()```
- in
@LarsGit223 pushed 1 commit.
9e49575 plugin-manager: protect call to help function with NULL pointer check
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
> I think that first of all we should fix the code so that it doesn't only rely
> on the UI being insensitive not to crash.
Yes, both keybindings and preferences buttons don't seem to suffer the problem,
probably because of a similar test.
--
You are receiving this because you are subscribed
I think that first of all we should fix the code so that it doesn't only rely
on the UI being insensitive not to crash. At least, do something like this:
```diff
diff --git a/src/plugins.c b/src/plugins.c
index 32a0ee891..c036ea0dd 100644
--- a/src/plugins.c
+++ b/src/plugins.c
@@ -1865,7
I haven't thoroughly reviewed or tested the code, but I have absolutely no
objection over merging it nice and early in the release cycle.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
LGBI
I havn't had a chance to test it, but yeah, in the face of a GTK bug a
workaround is needed because even if the problem is fixed there are buggy
versions in the wild already.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
I think the workaround is acceptable. @elextr @b4n @codebrainz any objections?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1784#issuecomment-371514744
On fast-clicks/double-clicks on a plugin row the selected row can change
and the buttons (e.g. the "Help" button) can get out of sync. That means
that e.g. a plugin is selected which has not got an help function but
the "Help" button is activated. Clicking the button is such a situation
leads to a
12 matches
Mail list logo
