Re: [Github-comments] [geany/geany-plugins] "Too many #ifdef configurations" in Debugger plugin (#1014)

2020-10-14 Thread Enrico Tröger
Oops, even in the log I pasted here I completely overlooked the real error message and just concentrated on the (probably) harmless warning. My random excuse generator says: it was late. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view

Re: [Github-comments] [geany/geany-plugins] "Too many #ifdef configurations" in Debugger plugin (#1014)

2020-10-14 Thread elextr
Also most of the ifdefs are `GTK_CHECK_VERSION(3, 0, 0)` and I don't know how smart cppcheck is to know all instances of that macro will have the same value. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] "Too many #ifdef configurations" in Debugger plugin (#1014)

2020-10-14 Thread elextr
I was just going on the title of the issue, I'm sure @eht16 couldn't be wrong. :) And agree the variable is a false positive, the `widgets` array is an initialised static null terminated in a loop that stops on null. -- You are receiving this because you are subscribed to this thread. Reply

Re: [Github-comments] [geany/geany-plugins] "Too many #ifdef configurations" in Debugger plugin (#1014)

2020-10-14 Thread Colomban Wendling
Is the problem really the ifdefs, or the `widgets` variable? If it's the var, it looks like a false positive to me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] "Too many #ifdef configurations" in Debugger plugin (#1014)

2020-10-13 Thread elextr
For the ifdef IIUC cppcheck checks all possible paths through nested `#ifdefs` eg: ``` #ifdef A code 1 #else code 2 #endif ``` would have the whole file checked twice, once with code 1 and once with code 2 included, but when ifdefs are nested the number of combinations can explode and the

[Github-comments] [geany/geany-plugins] "Too many #ifdef configurations" in Debugger plugin (#1014)

2020-10-13 Thread Enrico Tröger
cppcheck 2.2 complains about many `ifdef`s in the Debugger plugin: ``` make[5]: Leaving directory '/build/geany-plugins-1.36-1+20201013git06a38f4/debugger/src' tpage.c:154:62: warning: Uninitialized variable: widgets [uninitvar]