Re: [Github-comments] [geany/geany-plugins] Lineoperations: version compare (#993)

2020-11-11 Thread nomadbyte
Could the version-sort be done with `strverscmp()` instead of `filevercmp()` from coreutils? There're some differences, but for the general use like "file-1.9" vs. "file-1.10" the `strverscmp()` should do just fine. And it's part of `glibc` (well, `#define _GNU_SOURCE 1`), so no need to copy

Re: [Github-comments] [geany/geany-plugins] Lineoperations: version compare (#993)

2020-08-03 Thread Sylvan Mostert
Closed #993. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/993#event-3618043126

Re: [Github-comments] [geany/geany-plugins] Lineoperations: version compare (#993)

2020-08-03 Thread Sylvan Mostert
I am closing this since I cannot merge it until I get this licensing resolved. I will open it if I figure things out. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] Lineoperations: version compare (#993)

2020-08-02 Thread elextr
> I guess I would have to get permission from anybody who made changes to > lineoperations under the old license. That is what other projects that have changed licenses did yeah, my glance at git said not many people, and hopefully they will reply yes to a request for permission. > Would

Re: [Github-comments] [geany/geany-plugins] Lineoperations: version compare (#993)

2020-08-02 Thread Sylvan Mostert
Can I update the lineoperations license to GPLv3+ without issues? I guess I would have to get permission from anybody who made changes to lineoperations under the old license. Would changing this license to GPLv3 cause problems in the future? -- You are receiving this because you are

Re: [Github-comments] [geany/geany-plugins] Lineoperations: version compare (#993)

2020-08-02 Thread elextr
Unfortunately filevercmp.c is GPL 3 and line operations is GPL 2 and those can't be combined, [see GNU](https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany-plugins] Lineoperations: version compare (#993)

2020-08-02 Thread Sylvan Mostert
This PR is in response to #944. Changes: - Changed preferences to radio buttons to support multiple compare types. ![lineops-version-compare-pref](https://user-images.githubusercontent.com/15589754/89134371-9f6b3980-d4f2-11ea-895e-b343363e5e54.png) - add version compare using filevercmp from