Merged #1024 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1024#event-3971178480
@b4n approved this pull request.
LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1024#pullrequestreview-525827142
@frlan pushed 1 commit.
2a8969f0f69ba5dba96298a314004d3adfff6300 PrettyPrinter: Fix declaration of
input_buffer
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@b4n True. Will update it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1024#issuecomment-723589309
@b4n requested changes on this pull request.
The problem is not freeing `input_buffer` which *should* be freed, but that the
`input_buffer` variable shouldn't be `const` (since
3fad1285599766a7932667688871c04610bd8651). The change you propose would lead
to leaking quite a lot of memory.
--
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1024
-- Commit Summary --
* PrettyPrinter: Dont try to free const gchar* input_buffer
-- File Changes --
M pretty-printer/src/PluginEntry.c (4)
-- Patch Links --