Re: [Github-comments] [geany/geany-plugins] geniuspaste plugin missing TLS certificate verification (#1078)

2021-06-16 Thread Enrico Tröger
Ok, I don't want to argue about this. Also I don't know enough about the "Windows trust". If it does work automagically, it's fine. If not, we probably will receive a couple of bug reports. Don't get me wrong, not using TLS is no better. -- You are receiving this because you are subscribed

Re: [Github-comments] [geany/geany-plugins] geniuspaste plugin missing TLS certificate verification (#1078)

2021-06-16 Thread Michael Catanzaro
> This is what I would doubt. Do you have any reference on this? The pasted > link is just the code but I could not find any hint about included > certificates. So I would assume "glib-networking" needs external certificate > resources as well (which is totally fine IMO). If you use the

Re: [Github-comments] [geany/geany-plugins] geniuspaste plugin missing TLS certificate verification (#1078)

2021-06-15 Thread Enrico Tröger
> > On Linux there's usually a central cert-db, but not sure there's such on > > Windows. > > I'm pretty sure that's not true. Or it just depends on how you define "central cert-db". Usually there is a system wide certificate store with common public root certificates and this store is

Re: [Github-comments] [geany/geany-plugins] geniuspaste plugin missing TLS certificate verification (#1078)

2021-06-15 Thread Michael Catanzaro
> On Linux there's usually a central cert-db, but not sure there's such on > Windows. I'm pretty sure that's not true. > What's the recommended way to handle TLS validation on Windows? The recommended way is to do nothing. Just use the default GTlsDatabase. [That's implemented

Re: [Github-comments] [geany/geany-plugins] geniuspaste plugin missing TLS certificate verification (#1078)

2021-06-15 Thread nomadbyte
It's quite trivial to change GeniusPaste to call `soup_session_new_with_options()` instead of the current `soup_session_async_new_with_options()`, the resulting object is still the `SoupSession`, and it seems that the plugin is in fact doing a **synchronous** send. We can implement the

[Github-comments] [geany/geany-plugins] geniuspaste plugin missing TLS certificate verification (#1078)

2021-05-25 Thread Michael Catanzaro
Hi, geniuspaste.c does not appear to be enabling TLS certificate verification on the SoupSessionAsync object it creates. [You have to do this manually when using the deprecated