No worries @eht16 , I know mistakes happen to humans. Cheers!
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#issuecomment-2002704998
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3769 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#event-12143071778
You are receiving this because you are subscribed to this thread.
Message ID:
> > > Adding ` workflow_dispatch:` might be a good idea to manually re-run the
> > > workflow.
> >
> >
> > I would still recommend this simple change.
> > And it seems the configuration still has syntax errors:
> > https://github.com/geany/geany/actions/runs/8135027731/workflow
>
> That seems
@andy5995 commented on this pull request.
> @@ -15,7 +15,7 @@ on:
# cancel already running builds of the same branch or pull request
concurrency:
- group: ci-${{ github.head_ref }} || concat(${{ github.ref }}
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
@andy5995 pushed 1 commit.
a8bb8700e1d55e63c71fa2850d9862d211178677 Change concurrency rules
--
View it on GitHub:
https://github.com/geany/geany/pull/3769/files/e5a73c9e3608ca7185c508fe8f0d1199a4a89078..a8bb8700e1d55e63c71fa2850d9862d211178677
You are receiving this because you are subscribed
@andy5995 commented on this pull request.
> @@ -8,6 +8,13 @@ on:
push:
branches:
- master
+- '**'
I totally see your point. I've reverted all changes to build.yml.
--
Reply to this email directly or view it on GitHub:
> > Adding ` workflow_dispatch:` might be a good idea to manually re-run the
> > workflow.
>
> I would still recommend this simple change.
>
> And it seems the configuration still has syntax errors:
> https://github.com/geany/geany/actions/runs/8135027731/workflow
That seems outdated. I added
@andy5995 pushed 1 commit.
e5a73c9e3608ca7185c508fe8f0d1199a4a89078 Add CodeQL Analysis workflow
--
View it on GitHub:
https://github.com/geany/geany/pull/3769/files/629514d67d1ae515686473f36f9c16725cf771e2..e5a73c9e3608ca7185c508fe8f0d1199a4a89078
You are receiving this because you are
> Adding ` workflow_dispatch:` might be a good idea to manually re-run the
> workflow.
I would still recommend this simple change.
And it seems the configuration still has syntax errors:
https://github.com/geany/geany/actions/runs/8135027731/workflow
--
Reply to this email directly or view
@eht16 commented on this pull request.
> @@ -8,6 +8,13 @@ on:
push:
branches:
- master
+- '**'
I don't see why, at least for this case it seems a bit beyond the goal.
If we have use cases for excluding files from triggering a CI run, we
can add them but no excluding only
@andy5995 commented on this pull request.
> @@ -8,6 +8,13 @@ on:
push:
branches:
- master
+- '**'
So it won't run when other yml files are changed. Trivial in this case, but I
figured you might want to add more path filters in the future:
@andy5995 pushed 1 commit.
629514d67d1ae515686473f36f9c16725cf771e2 Add CodeQL Analysis workflow
--
View it on GitHub:
https://github.com/geany/geany/pull/3769/files/d0ff4df5d1558ba4901c1dc53f864d25da96a1bf..629514d67d1ae515686473f36f9c16725cf771e2
You are receiving this because you are
@andy5995 pushed 1 commit.
d0ff4df5d1558ba4901c1dc53f864d25da96a1bf Add CodeQL Analysis workflow
--
View it on GitHub:
https://github.com/geany/geany/pull/3769/files/2c58e9dcc9f9fc5250e57b1eb53d66a9cd393448..d0ff4df5d1558ba4901c1dc53f864d25da96a1bf
You are receiving this because you are
@eht16 commented on this pull request.
> @@ -8,6 +8,13 @@ on:
push:
branches:
- master
+- '**'
And it causes an error:
```
Invalid workflow file: .github/workflows/build.yml#L8
You have an error in your yaml syntax on line 8
```
--
Reply to this email directly or view it
Thanks!
> Done. Some examples of this workflow include a cron schedule as well. Would
> you like that added, and if so, how often should it be scheduled?
I would say once in a month is a good start.
--
Reply to this email directly or view it on GitHub:
@eht16 commented on this pull request.
> @@ -8,6 +8,13 @@ on:
push:
branches:
- master
+- '**'
Why did you change this, what's the intention?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#pullrequestreview-1912989734
You are
> Sounds good.
>
> * For the next time, a description to describe what is the PR about and
> more importantly why, is generally a good idea.
Understood!
>
> * We could add `*.py` to the patterns and `python` to the matrix to also
> cover the Python helper scripts in the repository.
This pull request sets up GitHub code scanning for this repository. Once the
scans have completed and the checks have passed, the analysis results for this
pull request branch will appear on [this
overview](/geany/geany/security/code-scanning?query=pr%3A3769+is%3Aopen). Once
you merge this
@andy5995 pushed 1 commit.
2c58e9dcc9f9fc5250e57b1eb53d66a9cd393448 strip comments, add workflow_patch
trigger, enable python
--
View it on GitHub:
https://github.com/geany/geany/pull/3769/files/14ef5fe702b42309fcd9e0fd1088b28e871cb6c5..2c58e9dcc9f9fc5250e57b1eb53d66a9cd393448
You are
Adding ` workflow_dispatch:` might be a good idea to manually re-run the
workflow.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#issuecomment-1951381789
You are receiving this because you are subscribed to this thread.
Message ID:
Sounds good.
- For the next time, a description to describe what is the PR about and more
importantly why, is generally a good idea.
- We could add `*.py` to the patterns and `python` to the matrix to also cover
the Python helper scripts in the repository.
- Also, could you strip the commented
@andy5995
> ... an invite to be a collaborator.
You could also just open a PR in your fork from the branch with the CodeQL
workflow in it. If an alert doesn't appear automatically, there should be an
option to publish it.
--
Reply to this email directly or view it on GitHub:
@rdipardo Thank you for the explanation. @elextr I sent you an invite to be a
collaborator.
Another thing CodeQL does is when a workflow is in place, it gives alerts for
any problematic code that may be introduced in a pull request.
--
Reply to this email directly or view it on GitHub:
> Erm, the link doesn't work.
That's because:
> [y]ou need write permission to view a summary of all the alerts for a
> repository on the **Security** tab.
>
>
Erm, the link doesn't work.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#issuecomment-1950230681
You are receiving this because you are subscribed to this thread.
Message ID:
I enabled the default scan from my repository settings. The only problems it
found were related to Scintilla
https://github.com/andy5995/geany/security/code-scanning
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#issuecomment-1950228067
You are
Maybe you could try the
[CLI](https://docs.github.com/en/code-security/codeql-cli) version and see if
its useful first.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#issuecomment-1950224542
You are receiving this because you are subscribed to
It doesn't run. The message is
```
github/codeql-action/init@v3, github/codeql-action/autobuild@v3, and
github/codeql-action/analyze@v3 are not allowed to be used in geany/geany.
Actions in this workflow must be: within a repository owned by geany or
matching the following: actions/cache@v2,
28 matches
Mail list logo
