[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Enrico Tröger via Github-comments
> An aside: @eht16 congrats the Windows CI is working again. Interesting to see > the relative speeds, meson/ninja vs Autotools/gmake vs Autotools in a > container. Comparing Meson vs Autotools was already possible before. The Windows CI builds should be excluded from such comparisons because t

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Jiří Techet via Github-comments
Merged #3612 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3612#event-10692845087 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Jiří Techet via Github-comments
> BTW, what's the unit of the setting? pixels, chars, apples? The tooltip of the entry says "Characters to be visible on the tab label of the file". While it's a bit inaccurate wrt international text as @b4n noted, it's probably fine for "normal" projects and files. -- Reply to this email dire

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3612#pullrequestreview-1684973051 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Colomban Wendling via Github-comments
@kugel- @techee looks like it's code points if cursory reading is to be trusted (looks like it's based on `g_utf8_strlen()`). Anyway, LGBI and agree that it's not pretty in the prefs dialog as is. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3612#iss

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread elextr via Github-comments
> BTW, what's the unit of the setting? pixels, chars, apples? Good question, probably glyphs if its done by GTK, or bytes if its done by Geany :-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3612#issuecomment-1768271762 You are receiving this becaus

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Thomas Martitz via Github-comments
BTW, what's the unit of the setting? pixels, chars, apples? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3612#issuecomment-1768237069 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread elextr via Github-comments
Although I might have chosen , 1000 is fine, and after all its the default, not the maximum the user can set. So LGBI. An aside: @eht16 congrats the Windows CI is working again. Interesting to see the relative speeds, meson/ninja vs Autotools/gmake vs Autotools in a container. -- Reply to