[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-05-08 Thread Jiří Techet via Github-comments
Closing as this PR is obsoleted by #3490. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3457#issuecomment-1538242734 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-05-08 Thread Jiří Techet via Github-comments
Closed #3457. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3457#event-9189611694 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-04-16 Thread elextr via Github-comments
> Yes, we should definitely fix it before our regular 3-times-a-year Geany > release ;-) Three years a time? :grin: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3457#issuecomment-1510543694 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-04-16 Thread Jiří Techet via Github-comments
I'd say let's wait what @masatake thinks about https://github.com/universal-ctags/ctags/pull/3696. If a solution like that is accepted upstream, I'll backport the fix for Geany. If not, we'd have to figure out what to do. > I really think that's something we ought to fix before releasing at

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-04-16 Thread Colomban Wendling via Github-comments
@techee Do you think it'd be realistic to come up with a fix (nicer than this one) in Geany until something is done in U-CTags? I really think that's something we ought to fix before releasing at least. Maybe "just" have a diff on our side, if it's a simple enough change? not that I like the

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-04-16 Thread Colomban Wendling via Github-comments
@techee Do you think it'd be realistic to come up with a fix (nicer than this one) in Geany until something is done in U-CTags? I really think that's something we ought to fix before releasing at least. Maybe "just" have a diff on our side, if it's a simple enough change? not that I like the

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-04-12 Thread elextr via Github-comments
> But the main problem is that for isHeader() uctags defaults to TRUE for an > unknown file extension which is what I'd like to change. Ok, since Geany can't distinguish header from body (in the actual language there _is_ no distinction, a "header" is just what programmers call a C/C++ file

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-04-12 Thread Jiří Techet via Github-comments
> The thing that will complicate it is that a Geany user can set filetype, and > really uctags should use that, not its own determination. That would be hard to do with the hacky interface we have against uctags (and I don't want to introduce too many Geany-specific things to uctags which is

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-04-11 Thread elextr via Github-comments
The thing that will complicate it is that a Geany user can set filetype, and really uctags should use that, not its own determination. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3457#issuecomment-1504348370 You are receiving this because you are

[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)

2023-04-11 Thread Jiří Techet via Github-comments
I maybe have a better idea how to fix this issue - I think it's fixable in uctags. Will try to prepare a patch. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3457#issuecomment-1504235949 You are receiving this because you are subscribed to this