Merged #3903 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3903#event-13249976716
You are receiving this because you are subscribed to this thread.
Message ID:
OK, let's give this one week of silence - if nobody complains in the meantime,
I'll merge it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3903#issuecomment-2171306902
You are receiving this because you are subscribed to this thread.
Message ID:
> > Anyway, tested on native Windows and works.
>
> I think the question is more "is it OK to drop it" :)
The answer was given implicitly by testing it :).
I don't remember why those dialogs did exist and I'm not even sure there was a
distinct reason for.
Most of the Geany Windows stuff I wrote
> Anyway, tested on native Windows and works.
I think the question is more "is it OK to drop it" :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3903#issuecomment-2170593935
You are receiving this because you are subscribed to this thread.
Message ID
One thing worth noting is the reversed order of buttons with GTK dialogs vs
native Windows dialogs
![Screenshot 2024-06-15
193909](https://github.com/geany/geany/assets/713965/15e00747-922c-4fd1-ade8-245447531bc9)
![Screenshot 2024-06-15
193233](https://github.com/geany/geany/assets/713965/2ca
@eht16 approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3903#pullrequestreview-2120432970
You are receiving this because you are subscribed to this thread.
Message ID:
> > I'm all for it, but given I don't use Windows I don't think my vote is fair
> > 🙂
>
> Yeah, @eht16 is the official Windows guru and enthusiast :-)
I'm neither of those but I'm aware you like to assign this to me :).
Anyway, tested on native Windows and works.
--
Reply to this email direct
> I'm all for it, but given I don't use Windows I don't think my vote is fair 🙂
Yeah, @eht16 is the official Windows guru and enthusiast :-)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3903#issuecomment-2163358478
You are receiving this because you a
I'm all for it, but given I don't use Windows I don't think my vote is fair
:slightly_smiling_face:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3903#issuecomment-2163337152
You are receiving this because you are subscribed to this thread.
Message I