It seems to work without the guard as well.
The connect_proxy function is called four times here, but it's the same on
Linux and Windows and in either way, the search toolbar item still works after
re-ordering.
Since we cannot reproduce this anymore and the "fix" is so long ago, maybe it
was
@eht16 I merged this anyway, but feel free to still check whether the
shenanigans are still useful :wink:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3838#issuecomment-2065494154
You are receiving this because you are subscribed to this thread.
Merged #3838 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3838#event-12530458077
You are receiving this because you are subscribed to this thread.
Message ID:
> I don't remember the initial problems from 12 years ago, maybe it was GTK2
> releated or a bug in early GTK3 versions or so.
Any chance you could try removing the guard and see if anything weird happens?
Not that I remember any details about that though, only Git does remember
anything :)
Tested on Linux and Windows, works perfectly.
I don't remember the initial problems from 12 years ago, maybe it was GTK2
releated or a bug in early GTK3 versions or so.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3838#issuecomment-2054027526
You
@eht16 approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3838#pullrequestreview-1999562116
You are receiving this because you are subscribed to this thread.
Message ID:
@ntrel approved this pull request.
Looks good, thanks. Tested on Linux, works.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3838#pullrequestreview-1999546491
You are receiving this because you are subscribed to this thread.
Message ID:
