[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)

2024-05-31 Thread Enrico Tröger via Github-comments
Merged #3886 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3886#event-12996209621 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)

2024-05-26 Thread Colomban Wendling via Github-comments
LGTM given the comments you guys made. We should just squash those commits together when merging. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3886#issuecomment-2132216459 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)

2024-05-26 Thread Enrico Tröger via Github-comments
> @eht16 you're the de-facto expert here, remember you did some work on it, now > you're doomed 😁 Remember, this is certainly at least one decade ago and since then I successfully managed to avoid doing any PowerShell :). > I'll try and update this, but feel also free to take this PR over fixin

[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)

2024-05-26 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 7707c7a346a585bbb79e766bae912d389ad90b2b PowerShell: Add keyword "clean" and aliases "foreach" and "where" -- View it on GitHub: https://github.com/geany/geany/pull/3886/files/5a2a436e69550bed35fdc215baffb8c09a0fa25f..7707c7a346a585bbb79e766bae912d389ad90b2b You are rec

[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)

2024-05-26 Thread Colomban Wendling via Github-comments
@eht16 you're the de-facto expert here, remember you did some work on it, now you're doomed 😁 I'll try and update this, but feel also free to take this PR over fixing whatever you think makes sense. Again, all I did was looking at (possibly an older version of) the link and came up with this ju

[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)

2024-05-26 Thread Enrico Tröger via Github-comments
To the removed ones: - "default" - no idea - "where" - according to http://xahlee.info/powershell/powershell_aliases.html and https://superuser.com/a/1397265, "where" is an alias So, we could add "where" to the aliases list. I checked the aliases in PowerShell on my Windows 7 machine, there are

[Github-comments] Re: [geany/geany] PowerShell: Update keywords (PR #3886)

2024-05-25 Thread elextr via Github-comments
>From the link above, also missing "clean". What about the workflow keywords? >(He says knowing nothing about what a workflow is). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3886#issuecomment-2131564921 You are receiving this because you are subscr