[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-20 Thread Colomban Wendling via Github-comments
Merged #3719 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3719#event-11301067901 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-20 Thread Colomban Wendling via Github-comments
Yeah and the generated *geany-gtkdoc.h* are exactly the same, as expected. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3719#issuecomment-1864276588 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-20 Thread Enrico Tröger via Github-comments
I just generated the docs without the changes, comitted the results (`reference` and `xml` directories) into a new GIT repository and did the same with the changes applied. The resulting diff is only about the generated timestamps and the following: ```diff diff --git a/xml/Doxyfile.xml b/xml/D

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-19 Thread Colomban Wendling via Github-comments
@elextr should be easy enough, go ahead ;) I can check tomorrow, but if the HTML is the same I guess the rest follows though -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3719#issuecomment-1863617289 You are receiving this because you are subscribed t

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-19 Thread elextr via Github-comments
Did you diff the XML and the GRRR, sorry GIR? :smile: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3719#issuecomment-1863551310 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-19 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. Makes recent Doxygen happy, and generates the same documentation than without the change with both 1.8.13 (Debian 10) and 1.9.4 (Debian 12). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3719#pullrequestreview-178968

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-19 Thread Colomban Wendling via Github-comments
FWIW, this PR builds OK with 1.8.13 and generates *no* changes I could find (*doc/reference/* is the same, minus the build dates). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3719#issuecomment-1863435942 You are receiving this because you are subscri

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-13 Thread Enrico Tröger via Github-comments
> > `doxygen -u` doesn't set it to "TEXT" here but to "YES", not sure why. > > Does it? Here it does set it to `TEXT` as it warns about, Doxygen 1.9.4. 1.9.4 here as well. With current master it does change it to `TEXT`, with the changes of this PR it will stay at `YES`. > Is the complaint new

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-12 Thread elextr via Github-comments
Is the complaint new to a new versio0n of doxygen? And if we change it will it break old versions? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3719#issuecomment-1852938359 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-12 Thread Colomban Wendling via Github-comments
> `doxygen -u` seems to update a lot more of the config, mostly updating > comments. > > I did not check in detail. We could update the config using the command at > all, so far I only edited it manually to get the warnings resolved. I'm not suggesting we do that, at least not to actually chang

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-12 Thread Colomban Wendling via Github-comments
> The warning only said it is changed because `CLASS_DIAGRAM` were set before, > right? I guess so, yeah. > `doxygen -u` doesn't set it to "TEXT" here but to "YES", not sure why. Does it? Here it does set it to `TEXT` as it warns about, Doxygen 1.9.4. > I don't mind how we proceed, I'm no dox

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-12 Thread Enrico Tröger via Github-comments
`doxygen -u` seems to update a lot more of the config, mostly updating comments. I did not check in detail. We could update the config using the command at all, so far I only edited it manually to get the warnings resolved. The warning only said it is changed because `CLASS_DIAGRAM` were set bef

[Github-comments] Re: [geany/geany] Remove deprecated Doxygen settings (PR #3719)

2023-12-12 Thread Colomban Wendling via Github-comments
It might not matter, but `doxygen -u` sets `CLASS_GRAPH = TEXT` as it says in the warning, in addition to removing `CLASS_DIAGRAMS`. Should we do so, or even set it to `NO`, or maybe we don't actually care because we don't have actual classes anyway? -- Reply to this email directly or view it