Merged #3267 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3267#event-9845932718
You are receiving this because you are subscribed to this thread.
Message ID:
Fine by me to merge.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3267#issuecomment-1555906663
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- commented on this pull request.
> @@ -4746,8 +4746,12 @@ gboolean editor_goto_pos(GeanyEditor *editor, gint
> pos, gboolean mark)
sci_goto_pos(editor->sci, pos, TRUE);
editor->scroll_percent = 0.25F;
- /* finally switch to the page */
- document_show_tab(ed
> Haven't looked at this, but it may be affected by #3395.
I just tested the latest changes and it seems fine for me now.
Had only a minor remark but it is not critical at all.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3267#issuecomment-1537441161
@eht16 commented on this pull request.
> @@ -4746,8 +4746,12 @@ gboolean editor_goto_pos(GeanyEditor *editor, gint
> pos, gboolean mark)
sci_goto_pos(editor->sci, pos, TRUE);
editor->scroll_percent = 0.25F;
- /* finally switch to the page */
- document_show_tab(edi
@kugel- pushed 1 commit.
ec327b7c50221039ae90e9df04403fdff95c396a PR #3125 (commit 22aac44) broke that
accidentally by moving the
--
View it on GitHub:
https://github.com/geany/geany/pull/3267/files/8ff5462dcae8c635be6fdf08aa4f1d4b54fc399f..ec327b7c50221039ae90e9df04403fdff95c396a
You are rece
Haven't looked at this, but it may be affected by #3395.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3267#issuecomment-1427006837
You are receiving this because you are subscribed to this thread.
Message ID:
Seems to be a regression of this patch. I'm looking at it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3267#issuecomment-1340462940
You are receiving this because you are subscribed to this thread.
Message ID:
Looks fine.
The notebook page is properly saved and restored across Geany restarts, also
for projects, even independently. Great.
While testing I noticed one minor issue though I'm not sure whether it's new or
not:
when I close a project, the previous session is restored but the "current_page"
