[Github-comments] Re: [geany/geany] Return NULL from document_get_current() if document is 'untitled' (PR #3770)

@elextr explained this to me in detail at https://github.com/andy5995/pinner/commit/8151d8b0b16e4ff3e674d2ad7aaaf97c3b4179f6#commitcomment-138855981 I consider the matter resolved. :) Thank you @elextr -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/37

[Github-comments] Re: [geany/geany] Return NULL from document_get_current() if document is 'untitled' (PR #3770)

There was a little more conversation about this in https://github.com/andy5995/pinner/commit/8151d8b0b16e4ff3e674d2ad7aaaf97c3b4179f6#commitcomment-138854459 I wanted to mention that if you think is_valid should be 0 when file_name == NULL, I'd redo this PR so that happens on https://github.com

[Github-comments] Re: [geany/geany] Return NULL from document_get_current() if document is 'untitled' (PR #3770)

Closed #3770. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3770#event-11843007945 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Return NULL from document_get_current() if document is 'untitled' (PR #3770)

This break `document_get_current()` when the document has no filename. That means any functionality that uses `document_get_current()` won't work on a document that the user has not given a filename. I will add further comments on the plugin. -- Reply to this email directly or view it on GitH