Closed #3441.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3441#event-10742666505
You are receiving this because you are subscribed to this thread.
Message ID:
We already have a newer version of Scintilla. Closing.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3441#issuecomment-1775468908
You are receiving this because you are subscribed to this thread.
Message ID:
#3551 already includes lexilla 5.2.6, no need to apply this on-top.
This the author isn't replying anyway I would just close this. We must not
forget the GDScript fix though.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3441#issuecomment-1722315549
Works for me on top of #3551 but with very limited testing (C/C++/Python).
@kugel- have you had a chance to review?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3441#issuecomment-1722118102
You are receiving this because you are subscribed to this
@kugel-
> this seems to be an artifact of an earlier lexilla update.
I checked and in fact the GDScript filedef was never quite correct. It was
copied almost verbatim from the Python filedef without a significant change
since being added in f59e520.
A point-in-time build based on f59e520 is
@rdipardo good catch. However, this seems to be an artifact of an earlier
lexilla update. Would you mind creating a separate PR for that?
@Azq2 Why did you only update lexilla? We typically update both components
together. And regardless, there is lexilla 5.2.5. Can you please target that?
--
GDScript's new annotation style has not been fully integrated yet.
The [file type definition] still contains a `decorator=decorator` mapping. As a
result, annotations don't show in [GDScript files] (lines 49, 51):
Really sorry, but I'm in the middle of moving to a new home. I won't have spare
time for another week or three.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3441#issuecomment-1567444345
You are receiving this because you are subscribed to this
ping @kugel-
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3441#issuecomment-1565784488
You are receiving this because you are subscribed to this thread.
Message ID:
I hope to have a look here after my vacations in about two weeks
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3441#issuecomment-1510753081
You are receiving this because you are subscribed to this thread.
Message ID:
I guess updating one without the other is why Neil split them. So long as no
lexer needs a capability only available in a newer Scintilla it should be ok.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3441#issuecomment-1510376329
You are receiving
I wonder if it is OK to just update Lexilla and not Scintilla as well?
But probably better than nothing and we can update Scintilla afterwards anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3441#issuecomment-1510374543
You are receiving this
I can't test ATM, but looks good by inspection, all new styles seem to have
made it into `highlightingmappings.h`, well done.
I had a thought while inspecting that filetypes files should include all lexer
property settings, even if set to Lexilla default or commented out, since
Lexilla only
13 matches
Mail list logo
