Merged #3656 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3656#event-12551171089
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 sure, doesn't break anything if nobody wants to fix it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3656#issuecomment-2068044244
You are receiving this because you are subscribed to this thread.
Message ID:
Don't we want to merge this anyway? Maybe the performance impact is tolerable
and then it is still an improvement for Fortran users.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3656#issuecomment-2068027071
You are receiving this because you are subsc
Completely understandable @elextr about the lexer. We have a GSoC project this
year that aims at adding highlighting support in our language server so fingers
crossed Fortran can soon join the experiment.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/
> these intrinsic variables/methods should be conditional to module imports,
The code doing highlighting is called lexers because they are just that, pure
syntax, no semantics is available, so no knowledge of what is imported. Its
just whats in the lists.
There are some experiments with vario
@elextr Truth be told a lot of these intrinsic variables/methods should be
conditional to module imports, exactly in order to alleviate pressure from the
lexer/parser. In the fortls language server, we only start parsing for certain
tokens only if the modules are `USE`d. Our serialised data look
@gnikit thanks.
I just noticed a comment on the OP that some names are in more than one list.
That won't break anything, but it will have performance effects. The lexer has
to search all lists for every identifier it finds (so all your variable names,
function names, etc as well as keywords, i
@gnikit approved this pull request.
Things look fine, albeit a bit hard to read.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3656#pullrequestreview-1887316150
You are receiving this because you are subscribed to this thread.
Message ID:
"Somebody" who knows Fortran should check it, but none of the devs use Fortran
AFAIK so its waiting for any contributor.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3656#issuecomment-1885853473
You are receiving this because you are subscribed to thi
when will this PR be merged?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3656#issuecomment-1885081983
You are receiving this because you are subscribed to this thread.
Message ID:
10 matches
Mail list logo
