Merged #1257 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1257#event-10391068900
You are receiving this because you are subscribed to this thread.
Message ID:
Oops, missed the changes being added, fine by me.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1257#issuecomment-134368
You are receiving this because you are subscribed to this thread.
Message ID:
I'd like to merge this in a few days if there are no objections or further
remarks.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1257#issuecomment-113074
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 commented on this pull request.
> {
+ AoTasksUpdateTasksForDocArguments *arguments = data;
+ AoTasks *t = arguments->t;
+ GeanyDocument *doc = arguments->doc;
Alright, done and also in a few more places in the Addons plugin.
--
Reply to this email directly or view it
@eht16 pushed 1 commit.
b1ba03c3edc70677df578ee7282456e38f965af5 Use DOC_VALID macro across the Addons
plugin
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1257/files/d975ce3f6c1a8e03d94ceb73bfc635b84bf2a1cc..b1ba03c3edc70677df578ee7282456e38f965af5
You are receiving this b
@elextr commented on this pull request.
> {
+ AoTasksUpdateTasksForDocArguments *arguments = data;
+ AoTasks *t = arguments->t;
+ GeanyDocument *doc = arguments->doc;
I was thinking of DOCVALID()
--
Reply to this email directly or view it on GitHub:
https://github.com/geany
@elextr fine by you now?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1257#issuecomment-1627749597
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 commented on this pull request.
> {
+ AoTasksUpdateTasksForDocArguments *arguments = data;
+ AoTasks *t = arguments->t;
I think so. The `AoTasks` object exists as long as the Addons plugin is loaded,
independently of opened documents and independent of whether the Tasks add
@eht16 commented on this pull request.
> {
+ AoTasksUpdateTasksForDocArguments *arguments = data;
+ AoTasks *t = arguments->t;
+ GeanyDocument *doc = arguments->doc;
I don't know if there is more than checking `data` for `NULL`. BUt at least
I've added this.
--
Reply to th
@eht16 pushed 1 commit.
d975ce3f6c1a8e03d94ceb73bfc635b84bf2a1cc Add more sanity checks
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1257/files/d6cb2c252b314088dd1ae99bacb1a55794098c79..d975ce3f6c1a8e03d94ceb73bfc635b84bf2a1cc
You are receiving this because you are subscrib
@eht16 pushed 1 commit.
d6cb2c252b314088dd1ae99bacb1a55794098c79 Add more sanity checks
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1257/files/e06dced5ccd9aba9af257fb3fca68c3ab13157dd..d6cb2c252b314088dd1ae99bacb1a55794098c79
You are receiving this because you are subscrib
@elextr commented on this pull request.
Perhaps get the doc pointer first and check valid, then link the tasks object
lifetime to the doc (if it isn't already).
Otherwise get current doc in the callback, since tasks doesn't write to the doc
it won't do any harm if it scans tasks for the visible
12 matches
Mail list logo
