Merged #1336 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#event-13497551112
You are receiving this because you are subscribed to this thread.
Message ID:
@frlan IMO we *need* this for 2.1, see
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2171361614. I'll
merge this in a few days unless somebody complains.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-22117923
Tested on Windows and works.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2171874834
You are receiving this because you are subscribed to this thread.
Message ID:
I'll test the CI installers in the next days when time permits.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2171428358
You are receiving this because you are subscribed to this thread.
Message ID:
@frlan I think this should really land (or be rejected if need be) before 2.1
so we have libsoup3 support for every relevant plugin.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2171361614
You are receiving this because you a
I rebased this on master now #1342 is merged, as it has CI infrastructure
changes for building with libsoup3. Apart from that it's unchanged from the
previous version.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2171361210
@b4n pushed 4 commits.
c33ef2e6940770b4e191d587eac305c1fe99dd4a updatechecker: Port to libsoup3
c30ab99f05e2cd9b94981d95fe82db6b7ad8a729 updatechecker: Don't leak the libsoup
session
ce1e698249706bf49682032d29c519e316a18dc8 updatechecker: Avoid a deprecated call
e1c9ac30375ca025366472b6bd07542
This PR won (IMO), so it's the one to review @frlan
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2089096951
You are receiving this because you are subscribed to this thread.
Message ID:
> hum… @elextr @xiota so what's your conclusion? Depend on libsoup3 as this PR
> because it's HTTP, or depend on a GVFS backend for HTTP?
Waiting for
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079741003
If it works `?` #1340 `:` #1336
--
Reply to this email directly or v
See #1340 if wanted.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079550087
You are receiving this because you are subscribed to this thread.
Message ID:
Note that writing an async version of the feature, while reasonably easy, is a
little bit more work.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079476011
You are receiving this because you are subscribed to this thread.
M
hum… @elextr @xiota so what's your conclusion? Depend on libsoup3 as this PR
because it's HTTP, or depend on a GVFS backend for HTTP?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079474204
You are receiving this because you
Yeah I guess using GIO directly for this kind of super simple GET would make
sense Indeed. I also think that gvfs will indeed be part of all reasonable GIO
installations, but I could be wrong.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336
Someone could run the test program on windows or mac to find out. I no longer
have (easy) access to either.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078735830
You are receiving this because you are subscribed to this th
Well, I interpret the very first words in the readme "GVfs is a userspace
virtual filesystem implementation for GIO" to mean its part of GIO. IIUC it
provides the implementations for the abstract file/URL/dbus stream operations
in GIO and thats why you get an error if its not installed and you
It is separate from GIO. This is the project page:
https://gitlab.gnome.org/GNOME/gvfs
Debian package, appears to be `gvfs-backends`
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2078714133
You are receiving this because you
> Looks like it depends on gvfs... After uninstalling...
Well, IIUC GVFS is _part_ of GIO (not to be confused with GnomeVFS), so if its
uninstalled its not surprising parts of GIO don't work.
But that probably means reading URLs won't work on Windows, dunno about Macos,
so back to the soup I gu
I use whatever is provided by the package manager. Even on Debian, pkg-config
is a dummy package that redirects to pkgconf.
Their stance doesn't seem particularly "aggressive" in context because they
call out "passive-aggressive people who try to argue with us". Seems they
probably had some p
Yeah, `pkg-config` is the Freedesktop original, `pkgconf` would appear to be a
re-implementation. Your distro installs `pkgconf` and links the original
command to it so existing scripts will work, if they happen to conform to what
`pkgconf` considers "correct".
If an existing script fails beca
> Unfortunately the GIO docs don't say when `g_file_new_from_URI()` and the
> associated stream was supported (that I could see) but it works on the
> machine I'm on ATM which is pretty olde.
Looks like it depends on `gvfs`... After uninstalling...
```
$ ./test
Error reading uri.
```
> PS I ex
Unfortunately the GIO docs don't say when `g_file_new_from_URI()` and the
associated stream was supported (that I could see) but it works on the machine
I'm on ATM which is pretty olde.
PS I expect not everyone has your alias pkgconf == pkg-config :wink:
--
Reply to this email directly or view
Size check is needed if this route is taken for the plugin... That code was
intended to check whether `https://` is supported because I saw only `file://`
mentioned in the docs. Typical version string is <8 bytes. Even with words
like `alpha` or `pre-release`, I figured 32 bytes is enough for
@xiota neat, and simple, although it has one theoretical bug (though unlikely
in practice) [hint: what if 32 bytes were returned].
Just for general information, Geany used (a __long__ time ago) to avoid GIO,
which is probably why the plugin used libsoup directly. But now GIO is
required by Gea
> `g_file_new_for_uri()` and `g_file_read()` (or
> `g_file_read_async()/g_file_read_finish()`
It works...
```C
#include
#include
int main() {
GFile *file = g_file_new_for_uri("https://geany.org/service/version/";);
GError *error = NULL;
GFileInputStream *stream = g_file_read(file, NULL
I don't know enough about libsoup to sensibly review (and don't have the time
to learn), but since Geany uses GIO why not `g_file_new_for_uri()` and
`g_file_read()` (or `g_file_read_async()/g_file_read_finish()` to not block the
UI) instead of using libsoup directly?
--
Reply to this email dir
@b4n commented on this pull request.
> @@ -185,15 +191,30 @@ version_compare(const gchar *current_version)
}
-static void update_check_result_cb(SoupSession *session,
-SoupMessage *msg, gpointer user_data)
+static gchar *bytes_to_string(GBytes *bytes)
+{
+gsize bytes_size = g_bytes_
@xiota commented on this pull request.
> @@ -185,15 +191,30 @@ version_compare(const gchar *current_version)
}
-static void update_check_result_cb(SoupSession *session,
-SoupMessage *msg, gpointer user_data)
+static gchar *bytes_to_string(GBytes *bytes)
+{
+gsize bytes_size = g_byte
@elextr commented on this pull request.
> @@ -185,15 +191,30 @@ version_compare(const gchar *current_version)
}
-static void update_check_result_cb(SoupSession *session,
-SoupMessage *msg, gpointer user_data)
+static gchar *bytes_to_string(GBytes *bytes)
+{
+gsize bytes_size = g_byt
@xiota commented on this pull request.
> @@ -185,15 +191,30 @@ version_compare(const gchar *current_version)
}
-static void update_check_result_cb(SoupSession *session,
-SoupMessage *msg, gpointer user_data)
+static gchar *bytes_to_string(GBytes *bytes)
+{
+gsize bytes_size = g_byte
29 matches
Mail list logo
