[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)

2024-05-20 Thread Enrico Tröger via Github-comments
`#ebdfd8` seems fine to me. Let's see what @rovf says. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/71#issuecomment-2121252920 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)

2024-05-20 Thread Colomban Wendling via Github-comments
Better, but what about `#ebdfd8`? ![metallic-bottle-ebdfd8](https://github.com/geany/geany-themes/assets/793526/ad7c12be-4434-4a4b-942d-79e4b863570d) Still not great for readability, but a tad better and the whole theme doesn't focus on contrast it seems. Not that I care, it's indeed better to

[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)

2024-05-20 Thread Enrico Tröger via Github-comments
@b4n they are indeed. I gave `#e4d3c7` it try as a rather lighter brown than before. ![Screenshot_2024-05-20_17-12-06](https://github.com/geany/geany-themes/assets/617017/08e46fd5-ff29-44b5-be23-7abf865ef618) This might be better for selection background. Though this makes the braces and the

[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)

2024-03-29 Thread Colomban Wendling via Github-comments
I think the gray strings are a bit hard to read on that brown, but I have no opinion apart that the mentioned bug is indeed bad, and if this fixes it, good :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/71#issuecomment-2027700432 You are

[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)

2024-03-28 Thread Enrico Tröger via Github-comments
If there are no objections or improvement suggestions, I would like to merge to this in a week. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/71#issuecomment-2024695254 You are receiving this because you are subscribed to this thread. Message