[Github-comments] [geany/geany] Shortcut to add/insert semicolon to end of line (Discussion #3596)

2023-10-11 Thread Richard3134 via Github-comments
Hello, I am looking online and in Geany to find a way to setup this shortcut: ad/insert semicolon to EOL, I couldn't find any clue... In advance, sorry if I missed something somewhere... Is anyone could help me with this? Thanks a lot, Richard -- Reply to this email directly or view it on

[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)

2023-10-11 Thread inonehp via Github-comments
@inonehp pushed 1 commit. 6847d284c91f3858a9a491761a76a477bc575812 Updated the author name. -- View it on GitHub: https://github.com/geany/geany-themes/pull/62/files/d4014bfedde5da64ed82a217a8327b3da4870d03..6847d284c91f3858a9a491761a76a477bc575812 You are receiving this because you are

[Github-comments] Re: [geany/geany] update czech translation (PR #3595)

2023-10-11 Thread zenobit via Github-comments
@zen0bit pushed 1 commit. 0821da0a2600de5e9876dfd89777205e7e4fd40a update czech translation -- View it on GitHub: https://github.com/geany/geany/pull/3595/files/24ffd38abbd4e4e83c94a4b30b7d31ccc440831d..0821da0a2600de5e9876dfd89777205e7e4fd40a You are receiving this because you are subscribed

[Github-comments] [geany/geany] update czech translation (PR #3595)

2023-10-11 Thread zenobit via Github-comments
Definetly not final... You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3595 -- Commit Summary -- * update czech translation -- File Changes -- M po/cs.po (451) -- Patch Links -- https://github.com/geany/geany/pull/3595.patch

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-11 Thread Jiří Techet via Github-comments
Maybe should I also grab the latest version of the libreadtags library for this PR? I noticed you also submitted some patch to it in the spring. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3049#issuecomment-1758610973 You are receiving this because

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-11 Thread Jiří Techet via Github-comments
> I wrote most of it, it ought to be perfect  Oh, I'm syncing it in the wrong direction - I should have updated ctags with your code :-). I discovered one more problem - all parsers use `typeref:typename` but I just discovered after looking at Enrico's php tags file and at the php parser

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-11 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > { - gchar buf[BUFSIZ]; - gchar *p, *tab; + tagEntry entry; + tagFile *f = tagsOpen(tags_file, NULL); + const gchar *lang_kinds = tm_ctags_get_lang_kinds(lang); + GPtrArray *unknown_fields = g_ptr_array_new_full(10,

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-11 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + fclose(fp); /* the readtags library opens the file by itself */ + read_ctags_file(tags_file, mode, file_tags); > doesn't this happen? You are absolutely right. When `format=ctags` is found in the file, I added ```

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-11 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > @@ -436,7 +443,6 @@ static TMTag *new_tag_from_tags_file(TMSourceFile *file, > FILE *fp, TMParserType result = init_tag_from_file_alt(tag, file, fp); break; case TM_FILE_FORMAT_CTAGS: -

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-11 Thread Jiří Techet via Github-comments
@techee pushed 4 commits. 49386fb8c70a80019ef5cd75ba21ec86305759b2 Warn about using legacy # format=ctags and update documentation a2cf693790c238faf7ba32aa18b478b6eaa77dc6 Add a debug warning a4a7941d7a0a82a1ebc6edb1b90566e2d3851c05 Replace GPtrArray with GArray

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
> > Should we maybe better highlight the many ctags changes? > > I don't think it's necessary, the big refactorings weren't user-visible. But > maybe if #3049 gets merged, an "improved support of ctags file format" could > be mentioned so users know they can use these files and there should be

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. b11817519cb0e9d2232958c54ce6c3d37c1ec599 Improve wording for PR3042 item -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/e754f79d16dcac69bcad0da13a0fd2aaf03e6a65..b11817519cb0e9d2232958c54ce6c3d37c1ec599 You are receiving this because you are

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. On doc/images/build_menu_commands_dialog.png: I'll give it another try tomorrow. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1355787792 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > - if [ -z "${PATCH}" ] || [ "${PATCH}" = "0" ]; then - MINOR="$((MINOR-1))" - PATCH="90" + if [[ "${MINOR}" = "0" && (-z "${PATCH}" || "${PATCH}" = "0") ]]; then +

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 15ef1d536971a3c3be9eb0d6b4cd2363ab21fb08 Use b4n's simpler version -- View it on GitHub: https://github.com/geany/geany/pull/3594/files/2fa22afbb8e80683afa2ae8b5f35dcd8e8c1299e..15ef1d536971a3c3be9eb0d6b4cd2363ab21fb08 You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany-plugins] Fix ci version parser (PR #1278)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 3613117b9573798b17f1535cfa9e4b4973f6c4d6 Use b4n's simpler version -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1278/files/ee46cc185c39ac7e5ccbd1df5f078f76627119d8..3613117b9573798b17f1535cfa9e4b4973f6c4d6 You are receiving this because you are

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Jiří Techet via Github-comments
@eht16 Thanks for doing the boring job! > I left out names for Jiří and Thomas as you count as core developers for long > I'd say. This doesn't mean your work is less appreciated ❤️ No problem at all :-). > @techee are tere any macOS specific items missing? There were some fixes but nothing

[Github-comments] [geany/geany-plugins] Change popup not working in git-changebar after updating to Scintilla to 5.3.7 (Issue #1279)

2023-10-11 Thread Jiří Techet via Github-comments
To keep a healthy amount of breakages before the release, here's one for git-changebar. After updating Scintilla to 5.3.7, the popup that shows the diff when a mouse cursor is placed on the marker in the sidebar shows a wrong thing:

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-11 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > - if [ -z "${PATCH}" ] || [ "${PATCH}" = "0" ]; then - MINOR="$((MINOR-1))" - PATCH="90" + if [[ "${MINOR}" = "0" && (-z "${PATCH}" || "${PATCH}" = "0") ]]; then +

[Github-comments] [geany/geany-plugins] Fix ci version parser (PR #1278)

2023-10-11 Thread Enrico Tröger via Github-comments
The previous logic failed on 2.0 to make the new version number 1.99.99. This is fixed now even though the code is not perfect or good at all but should work well enough for its purposes. See also https://github.com/geany/geany/pull/3594. The additional log information are in pair with Geany

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-11 Thread Enrico Tröger via Github-comments
JFYI, it's even tested this time (left is the result, right is the input version): ``` 1.38.0 - 1.38.1_git_2023103518_173744b2b 1.37.99 - 1.38_git_2023103518_173744b2b 2.0.0 - 2.0.1 1.99.99 - 2.0_git_2023103518_173744b2b 2.1.89 - 2.1.90 2.0.99 - 2.1 2.2.0 - 2.2.1 2.89.99 - 2.90 ```

[Github-comments] [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-11 Thread Enrico Tröger via Github-comments
The previous logic failed on 2.0 to make the new version number 1.99.99. This is fixed now even though the code is not perfect or good at all but should work well enough for its purposes. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3594

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. On doc/images/build_menu_commands_dialog.png: I totally don't mind how we create the screenshots. I just don't want to do it 10 times and do not want to install a dozen VMs :). Trying X11 might get better results. Within Gnome, I didn't find any way to

[Github-comments] [geany/geany-plugins] Spellecheck: Update style mappings (PR #1277)

2023-10-11 Thread Enrico Tröger via Github-comments
Implicitly require Geany 2.0 for G-P as the SpellCheck plugin makes uses of new Scintilla API. Is this OK? You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1277 -- Commit Summary -- * Add missing style mappings for new and updated

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: Reducing the font size might be the reason for icons to look too big in comparison, whereas the display was just entirely scaled up somehow… I have no idea (my Bookworm looks as above, but it's not 100% stock),

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
> Thanks for updating the docs - I made a few tweaks. Thank you, applied them all. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1757863336 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. e754f79d16dcac69bcad0da13a0fd2aaf03e6a65 Update NEWS -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/6601ca02e3e589f1dc76ad89893cbf929420fe50..e754f79d16dcac69bcad0da13a0fd2aaf03e6a65 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 6601ca02e3e589f1dc76ad89893cbf929420fe50 Apply geany.txt suggestions from code review -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/02238c4c91b84fc5acd1907dcc6e015490f0fc2e..6601ca02e3e589f1dc76ad89893cbf929420fe50 You are receiving this because

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. On doc/images/build_menu_commands_dialog.png: I booted up a Debian Bookworm VM from the live ISO image without any modifications to the theme. The only thing changed was to reduce the font size, otherwise everything would be even bigger. There was

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread elextr via Github-comments
@elextr commented on this pull request. On doc/images/build_menu_commands_dialog.png: Yeah maybe, but there is a lot of padding above and below the icons, anyway its something to be looked at when re-taking the screengrab after the delete icon is fixed. -- Reply to this email directly or

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Nick Treleaven via Github-comments
@ntrel commented on this pull request. Thanks for updating the docs - I made a few tweaks. > Interface * The document list in the sidebar has a new tree view. This mode is the new default and existing installations automatically use it (PR#1813). +* Use dark-theme friendly

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: > Also as I said the set build tools dialog seems to have been expanded > vertically (as well as the icons). To me that looks like the dialog is making room for those ginormous icons :) -- Reply to this

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread elextr via Github-comments
@elextr commented on this pull request. On doc/images/build_menu_commands_dialog.png: Yeah ok, the delete icon seems to be larger than any other icon, see also the general startup preference dialog, compare the delete icons and the folder icons size on the paths lines, on my system the

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: Look at the clear icons. My version (yeah, no window borders, but you get the idea): ![image](https://github.com/geany/geany/assets/793526/c4a0bb35-960a-4db1-9a1c-d3c9a057e1ac) -- Reply to this email

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread elextr via Github-comments
@elextr commented on this pull request. On doc/images/build_menu_commands_dialog.png: Which icons? Looks pretty normal (for dead tortoise) except the set build commands looks like the window has been stretched vertically by the user. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Colomban Wendling via Github-comments
Thanks for updating all this! But… I really think there's a problem with the inline icons in the screenshots, they shouldn't be that big -- and they aren't on my end with Adwaita (which seems to be what you used, which makes sense to use IMO). -- Reply to this email directly or view it on

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/build_menu_commands_dialog.png: wait… how come the icons are so big? HiDPI issue? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#pullrequestreview-1671065957 You are receiving this because you

[Github-comments] Re: [geany/geany] Update URLs to use https consistenly (PR #3583)

2023-10-11 Thread Enrico Tröger via Github-comments
Merged #3583 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3583#event-10617025585 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Do not enable Scintilla's Change History by default (PR #3591)

2023-10-11 Thread Thomas Martitz via Github-comments
Fine with me -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3591#issuecomment-1757418527 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] CI: Use mingw posix crosscompiler (PR #3568)

2023-10-11 Thread Enrico Tröger via Github-comments
Merged #3568 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3568#event-10616848196 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/infrastructure] Builders: Use "posix" variant of the mingw64 cross compiler (PR #11)

2023-10-11 Thread Enrico Tröger via Github-comments
Merged #11 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/infrastructure/pull/11#event-10616757861 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/infrastructure] Builders: Ensure /etc/mtab is available on Docker mingw64 image build (PR #10)

2023-10-11 Thread Enrico Tröger via Github-comments
Merged #10 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/infrastructure/pull/10#event-10616745507 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-11 Thread Enrico Tröger via Github-comments
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3396#pullrequestreview-1670757655 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-11 Thread Enrico Tröger via Github-comments
Tested and works fine. Maybe we could squash some of the commits? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3396#issuecomment-1757385379 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Do not enable Scintilla's Change History by default (PR #3591)

2023-10-11 Thread Enrico Tröger via Github-comments
As said earlier, I also vote for disabling the feature by default. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3591#issuecomment-1757381211 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR #3551)

2023-10-11 Thread Enrico Tröger via Github-comments
"Change history" docs will be added in https://github.com/geany/geany/pull/3593. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3551#issuecomment-1757377893 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-11 Thread Enrico Tröger via Github-comments
Add NEWS for 2.0, update documentation screenshots and add docs for the Change history feature. Remarks for the NEWS items: - I left out names for Jiří and Thomas as you count as core developers for long Id say. This doesnt mean your work is less appreciated :heart: - I skipped many smaller or

[Github-comments] Re: [geany/geany] C++ goto declaration and goto definition show same list (Issue #3585)

2023-10-11 Thread Jiří Techet via Github-comments
> We could introduce the new action and map to ctrl+t, and "go to definition" > becomes unbound. If "go to declaration" is essentially the same thing (as of > now, until it's fixed) then unbind it too. I'm fine with that. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] C++ goto declaration and goto definition show same list (Issue #3585)

2023-10-11 Thread Jiří Techet via Github-comments
> Also as the original post said it never seemed to provide the definitions > list, so exactly what the users have gotten used to is questionable. Once again, it _does_ provide definitions list. We are only talking about the special case where you are on the definition already and it swaps to

[Github-comments] Re: [geany/geany] C++ goto declaration and goto definition show same list (Issue #3585)

2023-10-11 Thread Thomas Martitz via Github-comments
We could introduce the new action and map to ctrl+t, and "go to definition" becomes unbound. If "go to declaration" is essentially the same thing (as of now, until it's fixed) then unbind it too. If I explicitly use "go to definition" when I'm on a definition, then I probably don't want to go

[Github-comments] Re: [geany/geany] "Join Lines" doesn't explain the sequence of how the lines are joined. (Issue #3590)

2023-10-11 Thread elextr via Github-comments
As I said above, although there is no `_U` clash now, that does not exclude that there was a clash in the past, menus change. As I noted if anyone cares they can check in git history. Even when a clashing accelerator is removed from a menu it is still not a good idea to reorganise the rest

[Github-comments] Re: [geany/geany] "Join Lines" doesn't explain the sequence of how the lines are joined. (Issue #3590)

2023-10-11 Thread Peter C. S. Scholtens via Github-comments
I was not familiar with this _join lines_ feature, so possible there is no better way to introduce users to it. About the the `_U`, I see no collision with other keys in "en_US" language mode. See the screenshot below (so instead of `Alt`+`E`+`F`+`N` we could choose `Alt`+`E`+`F`+`U`):