Re: [gitorious] Log graph issues

2013-03-13 Thread Scott Allen
Thanks, this solved our internal private instance as well. -scott On Tue, Mar 12, 2013 at 4:58 AM, Christian Johansen chrisj...@gmail.comwrote: Hi Scott, I tracked this down to refnames with dots being sanitized and have the dots stripped. I changed the GitShell implementation to use

Re: [gitorious] Log graph issues

2013-03-12 Thread Christian Johansen
Hi Scott, I tracked this down to refnames with dots being sanitized and have the dots stripped. I changed the GitShell implementation to use Shellwords to properly escape the refnames, and now it works again. If you didn't have dots in the refnames where you didn't see a graph, let me know. On

RE: [gitorious] Log graph issues

2013-03-12 Thread Peter Kjellerstedt
@googlegroups.com] On Behalf Of Christian Johansen Sent: den 12 mars 2013 10:58 To: gitorious@googlegroups.com Subject: Re: [gitorious] Log graph issues Hi Scott, I tracked this down to refnames with dots being sanitized and have the dots stripped. I changed the GitShell implementation

Re: [gitorious] Log graph issues

2013-03-12 Thread Christian Johansen
Wouldn't it have been simpler (and more generic) to keep the original prototype for graph_log() and then just change: command sanitize(options.join( )) to: command options.shelljoin Interesting. `shelljoin` is new to me. The reason I had to change it around is that we don't

[gitorious] Log graph issues

2013-03-11 Thread Scott Allen
On an internal private instance, user's have noticed that certain branches are not being displayed with log graph feature, while other are. I found I was able to reproduce this on gitorious.org. Are others seeing this issue? https://gitorious.org/gitorious/mainline/graph/2.x-stable -scott --