Re: [Gluster-devel] Report ESTALE as ENOENT

On Wed, Oct 11, 2017 at 04:11:51PM +0530, Raghavendra G wrote: > On Thu, Mar 31, 2016 at 1:22 AM, J. Bruce Fields > wrote: > > > On Mon, Mar 28, 2016 at 04:21:00PM -0400, Vijay Bellur wrote: > > > I would prefer to: > > > > > > 1. Return ENOENT f

Re: [Gluster-devel] Report ESTALE as ENOENT

On Wed, Oct 11, 2017 at 07:26:43AM -0400, Raghavendra Gowdappa wrote: > Another place to not convert is for those cases where kernel retries the > operation on seeing an ESTALE. > > I guess we need to think through each operation and we cannot ESTALE to > ENOENT always. By the way, my advice w

Re: [Gluster-devel] Report ESTALE as ENOENT

https://review.gluster.org/18463 > > > > On Thu, Mar 31, 2016 at 1:22 AM, J. Bruce Fields > > wrote: > >> On Mon, Mar 28, 2016 at 04:21:00PM -0400, Vijay Bellur wrote: > >> > I would prefer to: > >> > > >> > 1. Return ENOENT for all sy

Re: [Gluster-devel] Report ESTALE as ENOENT

On Wed, Oct 18, 2017 at 10:19:13AM +0200, Michael Kerrisk (man-pages) wrote: > On 10/11/2017 04:02 PM, J. Bruce Fields wrote: > > On Wed, Oct 11, 2017 at 04:11:51PM +0530, Raghavendra G wrote: > >> On Thu, Mar 31, 2016 at 1:22 AM, J. Bruce Fields > >> wrote: > >&

Re: [Gluster-devel] Report ESTALE as ENOENT

On Mon, Oct 23, 2017 at 05:37:53PM +0200, Michael Kerrisk (man-pages) wrote: > On 20 October 2017 at 22:22, J. Bruce Fields wrote: > > The basic issue is that unlike on a local filesystem, NFS can't > > necessarily keep an unlinked but in-use object around; so attempts to >

Re: [Gluster-devel] Report ESTALE as ENOENT

On Mon, Mar 28, 2016 at 04:21:00PM -0400, Vijay Bellur wrote: > On 03/28/2016 09:34 AM, FNU Raghavendra Manjunath wrote: > > > >I can understand the concern. But I think instead of generally > >converting all the ESTALE errors ENOENT, probably we should try to > >analyze the errors that are generat

Re: [Gluster-devel] How to fix wrong telldir/seekdir usage

On Sat, Sep 13, 2014 at 09:02:55PM +0200, Emmanuel Dreyfus wrote: > In <1lrx1si.n8tms1igmi5pm%m...@netbsd.org> I explained why NetBSD > currently fails self-heald.t, but since the subjet is burried deep in a > thread, it might be worth starting a new one to talk about how to fix. > > In 3 places w

Re: [Gluster-devel] How to fix wrong telldir/seekdir usage

On Mon, Sep 15, 2014 at 07:57:21PM +0200, Emmanuel Dreyfus wrote: > J. Bruce Fields wrote: > > > 4) Report this as a bug to NetBSD. > > > > You may be correct about the letter of the spec, but specs don't > > necessarily capture all requirements. And as othe

Re: [Gluster-devel] Invalid DIR * usage in quota xlator

On Sun, Oct 12, 2014 at 10:09:01AM +0200, Emmanuel Dreyfus wrote: > When quota xlator is enabled, bricks get this: > > [2014-10-12 07:56:03.090516] E [posix.c:4874:posix_fill_readdir] > 0-patchy-posix: seekdir(-1154801456) failed on dir=0xb99cb250: Invalid > argument (offset reused from another DI

Re: [Gluster-devel] Invalid DIR * usage in quota xlator

On Wed, Oct 15, 2014 at 04:22:36AM +0200, Emmanuel Dreyfus wrote: > J. Bruce Fields wrote: > > > Is the result on non-Linux really to fail any readdir using an offset > > not returned from the current open? > > Yes, but thatnon-Linux behabvior is POSIX compliant. Linux j

Re: [Gluster-devel] Invalid DIR * usage in quota xlator

On Wed, Oct 15, 2014 at 01:26:19PM +0200, Emmanuel Dreyfus wrote: > Anand Avati wrote: > > > Is there a way to get hold of the directory entry cookies used by NFS > > readdir from user-space? some sort of a NetBSD specific syscall (like > > getdents of Linux)? > > NetBSD has getdents(2) too, but

Re: [Gluster-devel] Invalid DIR * usage in quota xlator

On Tue, Oct 14, 2014 at 03:43:49PM -0400, bfields wrote: > On Sun, Oct 12, 2014 at 10:09:01AM +0200, Emmanuel Dreyfus wrote: > > When quota xlator is enabled, bricks get this: > > > > [2014-10-12 07:56:03.090516] E [posix.c:4874:posix_fill_readdir] > > 0-patchy-posix: seekdir(-1154801456) failed o

Re: [Gluster-devel] Invalid DIR * usage in quota xlator

On Mon, Oct 13, 2014 at 08:57:11AM +, Emmanuel Dreyfus wrote: > On Mon, Oct 13, 2014 at 01:42:38PM +0530, Pranith Kumar Karampuri wrote: > > >No bug here, just suboptimal behavior, both in glusterfs and NetBSD FUSE. > > oh!, but shouldn't it get op_ret = 0 instead of op_ret -1, op_errno EINVAL?

Re: [Gluster-devel] Invalid DIR * usage in quota xlator

On Wed, Oct 15, 2014 at 07:42:25PM +0200, Emmanuel Dreyfus wrote: > J. Bruce Fields wrote: > > > You're assuming no filesystem uses -1 as a cookie? > > Might be true, but it's taking a small chance. > > Latest version does not work like this anymore: when E

Re: [Gluster-devel] Portable filesystem ACLs?

On Sun, Dec 14, 2014 at 07:24:52PM +0530, Soumya Koduri wrote: > > > On 12/12/2014 11:06 PM, Niels de Vos wrote: > >Hi, > > > >I started to look into getting some form of support for ACLs in gfapi. > > > >After a short discussion with Shyam, some investigation showed that our > >current implement

Re: [Gluster-devel] Readdir d_off encoding

On Tue, Dec 16, 2014 at 11:46:46AM -0500, Shyam wrote: > On 12/15/2014 09:06 PM, Anand Avati wrote: > >Replies inline > > > >On Mon Dec 15 2014 at 12:46:41 PM Shyam >> wrote: > > > >With the changes present in [1] and [2], > > > >A short explanation of the chang

Re: [Gluster-devel] Readdir d_off encoding

On Tue, Dec 16, 2014 at 04:22:20PM -0500, Shyam wrote: > On 12/16/2014 03:21 PM, J. Bruce Fields wrote: > >On Tue, Dec 16, 2014 at 11:46:46AM -0500, Shyam wrote: > >>On 12/15/2014 09:06 PM, Anand Avati wrote: > >>>Replies inline > >>> > >>>On

Re: [Gluster-devel] Readdir d_off encoding

On Mon, Dec 22, 2014 at 09:30:29AM -0500, Jeff Darcy wrote: > > The birthday paradox says that with a 44-bit hash we're more likely than > > not to start seeing collisions somewhere around 2^22 directory entries. > > That 16-million-entry-directory would have a lot of collisions. > > This is reall

Re: [Gluster-devel] Readdir d_off encoding

On Mon, Dec 22, 2014 at 09:30:29AM -0500, Jeff Darcy wrote: > By contrast, the failure mode for the map-caching approach - a simple > failure in readdir - is relatively benign. Such failures are also > likely to be less common, even if we adopt the *unprecedented* > requirement that the cache be s

Re: [Gluster-devel] Readdir d_off encoding

On Mon, Dec 22, 2014 at 12:04:03PM -0500, Jeff Darcy wrote: > > > The situation gets even worse if the bit-stealing is done at other > > > levels than at the bricks, and I haven't seen any such proposals that > > > deal with issues such as needing to renumber when disks are added or > > > removed.

Re: [Gluster-devel] Readdir d_off encoding

On Mon, Dec 22, 2014 at 02:06:42PM -0500, Jeff Darcy wrote: > None of these *completely* solve the problem. For that we need > something besides a client-side mapping cache. However, while I have > seen users do a lot of very strange things, running thousands of > concurrent readdir loops on a si

Re: [Gluster-devel] Readdir d_off encoding

On Mon, Dec 22, 2014 at 03:20:48PM -0500, Jeff Darcy wrote: > > I don't love the bit-stealing hack either, but in practice keep in mind > > this all seems to be about ext4. If you want reliable nfs readdir with > > 16M-entry directories and all the rest you can get that already with > > xfs. > >

Re: [Gluster-devel] Readdir d_off encoding

On Mon, Dec 22, 2014 at 04:20:58PM -0500, Jeff Darcy wrote: > > Maybe, but that'd have a pretty high bar to clear: we definitely don't > > want to break existing working xfs setups. > > Darn right it's a high bar. Is a single failed readdir under truly > exceptional (and so far only theoretical)

Re: [Gluster-devel] Readdir d_off encoding

On Mon, Dec 22, 2014 at 02:04:37PM -0500, J. Bruce Fields wrote: > It'd also be nice to see any proposals for a completely correct > solution, even if it's something that will take a while. All I can > think of is protocol extensions, but that's just what I know. I tried

Re: [Gluster-devel] Report ESTALE as ENOENT

On Thu, Feb 22, 2018 at 01:17:58PM +0530, Raghavendra G wrote: > On Wed, Oct 11, 2017 at 7:32 PM, J. Bruce Fields > wrote: > > > On Wed, Oct 11, 2017 at 04:11:51PM +0530, Raghavendra G wrote: > > > On Thu, Mar 31, 2016 at 1:22 AM, J. Bruce Fields > > > wrote: &

Re: [Gluster-devel] Report ESTALE as ENOENT

On Mon, Feb 26, 2018 at 11:20:49AM +0530, Raghavendra G wrote: > On Fri, Feb 23, 2018 at 6:33 AM, J. Bruce Fields > wrote: > > > On Thu, Feb 22, 2018 at 01:17:58PM +0530, Raghavendra G wrote: > > > For a local filesystem, we may not end up in ESTALE errors. But, when >

Re: [Gluster-devel] Report ESTALE as ENOENT

On Wed, Feb 28, 2018 at 08:15:13AM +0530, Raghavendra Gowdappa wrote: > On Wed, Feb 28, 2018 at 2:49 AM, J. Bruce Fields > wrote: > > That might work. Or, maybe better, take "ESTALE" as a sign that the > > parent directory is gone and give up on trying to remove