Re: [Gluster-devel] Automatic clang-format for GitHub PRs

2021-02-15 Thread Deepshikha Khandelwal
On Mon, Feb 15, 2021 at 12:29 PM Xavi Hernandez wrote: > > On Thu, Feb 11, 2021 at 5:50 PM Yaniv Kaul wrote: > >> >> >> On Thu, Feb 11, 2021 at 5:54 PM Amar Tumballi wrote: >> >>> >>> >>> On Thu, 11 Feb, 2021, 9:19 pm Xavi Hernandez, >>> wrote: >>> On Wed, Feb 10, 2021 at 1:33 PM Amar Tum

Re: [Gluster-devel] Automatic clang-format for GitHub PRs

2021-02-14 Thread Xavi Hernandez
On Thu, Feb 11, 2021 at 5:50 PM Yaniv Kaul wrote: > > > On Thu, Feb 11, 2021 at 5:54 PM Amar Tumballi wrote: > >> >> >> On Thu, 11 Feb, 2021, 9:19 pm Xavi Hernandez, >> wrote: >> >>> On Wed, Feb 10, 2021 at 1:33 PM Amar Tumballi wrote: >>> On Wed, Feb 10, 2021 at 3:29 PM Xavi He

Re: [Gluster-devel] Automatic clang-format for GitHub PRs

2021-02-11 Thread Yaniv Kaul
On Thu, Feb 11, 2021 at 5:54 PM Amar Tumballi wrote: > > > On Thu, 11 Feb, 2021, 9:19 pm Xavi Hernandez, > wrote: > >> On Wed, Feb 10, 2021 at 1:33 PM Amar Tumballi wrote: >> >>> >>> >>> On Wed, Feb 10, 2021 at 3:29 PM Xavi Hernandez >>> wrote: >>> Hi all, I'm wondering if enfor

Re: [Gluster-devel] Automatic clang-format for GitHub PRs

2021-02-11 Thread Amar Tumballi
On Thu, 11 Feb, 2021, 9:19 pm Xavi Hernandez, wrote: > On Wed, Feb 10, 2021 at 1:33 PM Amar Tumballi wrote: > >> >> >> On Wed, Feb 10, 2021 at 3:29 PM Xavi Hernandez >> wrote: >> >>> Hi all, >>> >>> I'm wondering if enforcing clang-format for all patches is a good idea... >>> >>> I've recently

Re: [Gluster-devel] Automatic clang-format for GitHub PRs

2021-02-11 Thread Xavi Hernandez
On Wed, Feb 10, 2021 at 1:33 PM Amar Tumballi wrote: > > > On Wed, Feb 10, 2021 at 3:29 PM Xavi Hernandez > wrote: > >> Hi all, >> >> I'm wondering if enforcing clang-format for all patches is a good idea... >> >> I've recently seen patches where clang-format is doing changes on parts >> of the

Re: [Gluster-devel] Automatic clang-format for GitHub PRs

2021-02-10 Thread Amar Tumballi
On Wed, Feb 10, 2021 at 3:29 PM Xavi Hernandez wrote: > Hi all, > > I'm wondering if enforcing clang-format for all patches is a good idea... > > I've recently seen patches where clang-format is doing changes on parts of > the code that have not been touched by the patch. Given that all files wer

[Gluster-devel] Automatic clang-format for GitHub PRs

2021-02-10 Thread Xavi Hernandez
Hi all, I'm wondering if enforcing clang-format for all patches is a good idea... I've recently seen patches where clang-format is doing changes on parts of the code that have not been touched by the patch. Given that all files were already formatted by clang-format long ago, this shouldn't happe